drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent
Subsystems (4)
Heiko Stuebner
maintainerPATCH 1/1 drm/rockchip: vop: add rk3188 hs_start interrupt as dsp_hold equivalent
The hs_start interrupt on rk3188 fires at the start of a new frame, so serves essentially the same purpose as the dsp_hold_valid irq in checking when the last frame got delivered when going to standby. So define it to fix a hang on atomic_disable of the vop because the completion never really completed before.
--- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/rockchip/rockchip_vop_reg.c +5 -1
@@ -465,7 +465,11 @@ static const struct vop_win_data rk3188_vop_win_data[] = { };static const int rk3188_vop_intrs[] = { -0 , +/* +* hs_start interrupt fires at frame-start, so serves +* the same purpose as dsp_hold in the driver. +*/ +DSP_HOLD_VALID_INTR ,FS_INTR ,LINE_FLAG_INTR ,BUS_ERROR_INTR ,
Signature · 6 lines
2.18.0 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi heiko,
nice solution.
Quoted 20 lines · Heiko Stuebner
The
hs_startinterrupt on rk3188 fires at the start of a new frame, so serves essentially the same purpose as thedsp_hold_validirq in checking when the last frame got delivered when going to standby. So define it to fix a hang onatomic_disableof the vop because the completion never really completed before.Fixes 428e15cc41e3 ("drm/rockchip: vop: add rk3188 vop definitions")Signed-off-by Heiko Stuebner <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/rockchip/rockchip_vop_reg.c +0
-0@@ -465,7 +465,11 @@ static const struct vop_win_data rk3188_vop_win_data[] = { };
drivers/gpu/drm/rockchip/rockchip_vop_reg.c static const struct vop_win_data rk3188_vop_win_data[] = { · line 475
Quoted 10 lines
drivers/gpu/drm/rockchip/rockchip_vop_reg.c +5
-1static const int rk3188_vop_intrs[] = { -0 , +/* +* hs_start interrupt fires at frame-start, so serves +* the same purpose as dsp_hold in the driver. +*/ +DSP_HOLD_VALID_INTR ,FS_INTR ,LINE_FLAG_INTR ,BUS_ERROR_INTR ,
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi heiko,
nice solution.
Quoted 20 lines · Heiko Stuebner
The
hs_startinterrupt on rk3188 fires at the start of a new frame, so serves essentially the same purpose as thedsp_hold_validirq in checking when the last frame got delivered when going to standby. So define it to fix a hang onatomic_disableof the vop because the completion never really completed before.Fixes 428e15cc41e3 ("drm/rockchip: vop: add rk3188 vop definitions")Signed-off-by Heiko Stuebner <[email protected]>--- drivers/gpu/drm/rockchip/rockchip_vop_reg.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)drivers/gpu/drm/rockchip/rockchip_vop_reg.c +0
-0@@ -465,7 +465,11 @@ static const struct vop_win_data rk3188_vop_win_data[] = { };
drivers/gpu/drm/rockchip/rockchip_vop_reg.c static const struct vop_win_data rk3188_vop_win_data[] = { · line 475
Quoted 10 lines
drivers/gpu/drm/rockchip/rockchip_vop_reg.c +5
-1static const int rk3188_vop_intrs[] = { -0 , +/* +* hs_start interrupt fires at frame-start, so serves +* the same purpose as dsp_hold in the driver. +*/ +DSP_HOLD_VALID_INTR ,FS_INTR ,LINE_FLAG_INTR ,BUS_ERROR_INTR ,
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Am Sonntag, 23. September 2018, 14:37:30 CEST schrieb Heiko Stuebner:
Quoted 8 lines
The
hs_startinterrupt on rk3188 fires at the start of a new frame, so serves essentially the same purpose as thedsp_hold_validirq in checking when the last frame got delivered when going to standby. So define it to fix a hang onatomic_disableof the vop because the completion never really completed before.Fixes 428e15cc41e3 ("drm/rockchip: vop: add rk3188 vop definitions")Signed-off-by Heiko Stuebner <[email protected]>
applied to drm-misc-next with Sandy's Review.
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel