kernel-yocto.bbclass: fix "referenced before assignment" error
PATCH 1/1 kernel-yocto.bbclass: fix "referenced before assignment" error
From: Max Kellermann <[email protected]>
If "scc --configs" fails, do_kernel_configcheck() crashes like this:
0338: try:
0339: configs = subprocess.check_output(['scc', '--configs', '-o', s + '/.kernel-meta'], env=env).decode('utf-8')
0340: except subprocess.CalledProcessError:
*** 0341: bb.fatal( "Cannot gather config fragments for audit: %s" % configs)
0342:
0343: try:
0344: subprocess.check_call(['kconf_check', '--report', '-o',
0345: '%s/%s/cfg' % (s, kmeta), d.getVar('B') + '/.config', s, configs], cwd=s, env=env)Exception: UnboundLocalError: local variable 'configs' referenced before assignment
This crash bug was introduced by commit21de5cc43cfedc703e5bc0515507a6dae36afb74
Signed-off-by Max Kellermann <[email protected]>
--- meta/classes/kernel-yocto.bbclass | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
meta/classes/kernel-yocto.bbclass +2 -2
@@ -337,8 +337,8 @@ python do_kernel_configcheck() { try: configs = subprocess.check_output(['scc', '--configs', '-o', s + '/.kernel-meta'], env=env).decode('utf-8') - except subprocess.CalledProcessError: - bb.fatal( "Cannot gather config fragments for audit: %s" % configs) + except subprocess.CalledProcessError as e: + bb.fatal( "Cannot gather config fragments for audit: %s" % e.output.decode("utf-8") ) try: subprocess.check_call(['kconf_check', '--report', '-o',
Signature · 1 line
2.19.0