ts-xen-build-prep: install libgnutls28-dev for libvirt build
PATCH 1/1 ts-xen-build-prep: install libgnutls28-dev for libvirt build
d54ecf31b2 placed the build dependency in a wrong file. This patch reverts it and adds the dependency to the right file.
---
Cc: Jim Fehlig <[email protected]>
--- Osstest/Toolstack/libvirt.pm | 2 +- ts-xen-build-prep | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)
Osstest/Toolstack/libvirt.pm +1 -1
@@ -26,7 +26,7 @@ use XML::LibXML; sub new { my ($class, $ho, $methname,$asset) = @_; - my @extra_packages = qw(libavahi-client3 libgnutls28-dev); + my @extra_packages = qw(libavahi-client3); my $nl_lib = "libnl-3-200"; $nl_lib = "libnl1" if ($ho->{Suite} =~ m/wheezy/); push(@extra_packages, $nl_lib);
ts-xen-build-prep +2 -1
@@ -208,7 +208,8 @@ sub prep () { libxml2-utils libxml2-dev libdevmapper-dev w3c-dtd-xhtml libxml-xpath-perl libelf-dev - ccache nasm checkpolicy ebtables); + ccache nasm checkpolicy ebtables + libgnutls28-dev); if ($ho->{Suite} !~ m/squeeze|wheezy/) { push(@packages, qw(ocaml-nox ocaml-findlib));
Signature · 7 lines
2.11.0 _______________________________________________ Xen-devel mailing list [email protected] https://lists.xenproject.org/mailman/listinfo/xen-devel
Wei Liu writes ("[OSSTEST PATCH] ts-xen-build-prep: install libgnutls28-dev for libvirt build"):
Quoted 2 lines
d54ecf31b2placed the build dependency in a wrong file. This patch reverts it and adds the dependency to the right file.
Now that I look at this properly and at the context, I think that we need to add a runtime dependency to libvirt.pm, here:
Osstest/Toolstack/libvirt.pm use XML::LibXML; · line 29
Quoted 10 lines
Osstest/Toolstack/libvirt.pm +1
-1@@ -26,7 +26,7 @@ use XML::LibXML; sub new { my ($class, $ho, $methname,$asset) = @_; - my @extra_packages = qw(libavahi-client3 libgnutls28-dev); + my @extra_packages = qw(libavahi-client3);
Since if libvirt has gnutls as a build-dep some bit of it is probably linked against it and will fail otherwise. I think the right answer is therefore
+ my @extra_packages = qw(libavahi-client3 libgnutls30);
(in addition to the hunk in ts-xen-build-prep).
Ian.
_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel