Skip to contentSkip to conversation

staging: dgnc: Fix Kconfig help header and text

PATCH In review sehro rautenkranz 4 participants 11 messages Sep 25, 2018 – Oct 2, 2018 2 messages not in the archive Staging

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: dgnc: Fix Kconfig help header and text

Replace Kconfig help header and text to match other modules. Issue found by checkpatch.

---
 drivers/staging/dgnc/Kconfig | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/staging/dgnc/Kconfig +6 -2
index 032c2a795238..c845b357b53d 100644
@@ -2,5 +2,9 @@ config DGNC
        tristate "Digi Neo and Classic PCI Products"
        default n
        depends on TTY && PCI
-       ---help---
-       Driver for the Digi International Neo and Classic PCI based product line.
+       help
+            Say Y here to enable support for the Digi International Neo and
+            Classic PCI based product line.
+
+            To compile this driver as a module, say M here: the module will be
+            called dgnc
Signature · 1 line
2.19.0
#1 lore raw
Quoted 5 lines · sehro rautenkranz

Replace Kconfig help header and text to match other modules. Issue found by checkpatch.

---

Hi,

Documentation/process/coding-style.rst says:

Lines under a ``config`` definition
are indented with one tab, while help text is indented an additional two spaces.

Quoted 10 lines
 drivers/staging/dgnc/Kconfig | 8 ++++++--
 1 file changed, 6 insertions(+), 2 deletions(-)
drivers/staging/dgnc/Kconfig +0 -0
index 032c2a795238..c845b357b53d 100644
@@ -2,5 +2,9 @@ config DGNC
        tristate "Digi Neo and Classic PCI Products"

drivers/staging/dgnc/Kconfig config DGNC · line 10

Quoted 10 lines
drivers/staging/dgnc/Kconfig +6 -2
        default n
        depends on TTY && PCI
-       ---help---
-       Driver for the Digi International Neo and Classic PCI based product line.
+       help
+            Say Y here to enable support for the Digi International Neo and
+            Classic PCI based product line.
+
+            To compile this driver as a module, say M here: the module will be
+            called dgnc

thanks,

Signature · 1 line
~Randy
#2 lore raw

PATCH 1/1 staging: dgnc: Fix Kconfig help header and text

Replace Kconfig help header and text to match other modules. Issue found my checkpatch.

Spacing adjusted to match Documentation/process/coding-style.rst. Issue reported by [email protected].

---
 drivers/staging/dgnc/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/dgnc/Kconfig +4 -4
index c845b357b53d..7361d6cd73d4 100644
@@ -3,8 +3,8 @@ config DGNC
        default n
        depends on TTY && PCI
        help
-            Say Y here to enable support for the Digi International Neo and
-            Classic PCI based product line.
+                 Say Y here to enable support for the Digi International Neo and
+                 Classic PCI based product line.
 
-            To compile this driver as a module, say M here: the module will be
-            called dgnc
+                 To compile this driver as a module, say M here: the module will be
+                 called dgnc
Signature · 1 line
2.19.0
#3 lore raw
Quoted 2 lines · sehro rautenkranz

Replace Kconfig help header and text to match other modules. Issue found my checkpatch.

by checkpatch.

Quoted 3 lines

Spacing adjusted to match Documentation/process/coding-style.rst. Issue reported by [email protected].

Quoted 13 lines
---
 drivers/staging/dgnc/Kconfig | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/dgnc/Kconfig +0 -0
index c845b357b53d..7361d6cd73d4 100644
@@ -3,8 +3,8 @@ config DGNC
        default n
        depends on TTY && PCI

drivers/staging/dgnc/Kconfig config DGNC · line 10

Quoted 10 lines
drivers/staging/dgnc/Kconfig +4 -4
        help
-            Say Y here to enable support for the Digi International Neo and
-            Classic PCI based product line.
+                 Say Y here to enable support for the Digi International Neo and
+                 Classic PCI based product line.
 
-            To compile this driver as a module, say M here: the module will be
-            called dgnc
+                 To compile this driver as a module, say M here: the module will be
+                 called dgnc

That indentation is still not correct. :(

Signature · 1 line
~Randy
#4 lore raw

PATCH 1/1 staging: dgnc: Fix Kconfig help header and text

Replace Kconfig help header and text to match other modules. Issue found my checkpatch.

Spacing adjusted to match Documentation/process/coding-style.rst. Issue reported by [email protected]. (try 2)

---
 drivers/staging/dgnc/Kconfig | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)
drivers/staging/dgnc/Kconfig +9 -5
index 032c2a795238..0f7537eb27d8 100644
@@ -1,6 +1,10 @@
 config DGNC
-       tristate "Digi Neo and Classic PCI Products"
-       default n
-       depends on TTY && PCI
-       ---help---
-       Driver for the Digi International Neo and Classic PCI based product line.
+	tristate "Digi Neo and Classic PCI Products"
+	default n
+	depends on TTY && PCI
+	help
+         Say Y here to enable support for the Digi International Neo and
+         Classic PCI based product line.
+
+         To compile this driver as a module, say M here: the module will be
+         called dgnc
Signature · 1 line
2.19.0
#5 lore raw
Quoted 5 lines · sehro rautenkranz

Replace Kconfig help header and text to match other modules. Issue found my checkpatch.

Spacing adjusted to match Documentation/process/coding-style.rst. Issue reported by [email protected]. (try 2)

The "try 2" needs go to below the --- line.

Also, you need to properly version your patches so that I have a clue as to which is the "latest" one.

Quoted 1 line

You forgot Randy's Reported-by.

Also, properly Capitalize your name.

v3?

thanks,

greg k-h

#6 lore raw
Quoted 12 lines · Greg Kroah-Hartman
Quoted 5 lines · sehro rautenkranz

Replace Kconfig help header and text to match other modules. Issue found my checkpatch.

Spacing adjusted to match Documentation/process/coding-style.rst. Issue reported by [email protected]. (try 2)

The "try 2" needs go to below the --- line.

Also, you need to properly version your patches so that I have a clue as to which is the "latest" one.

Quoted 7 lines
Quoted 1 line

You forgot Randy's Reported-by.

Also, properly Capitalize your name.

v3?

and the help text is still not indented correctly:
use one tab + 2 spaces for help text.

Signature · 1 line
~Randy
#7 lore raw

PATCH v3 1/1 staging: dgnc: Fix Kconfig help header and text

Replace Kconfig help header and text to match other modules. Issue found by checkpatch.

Spacing adjusted to match Documentation/process/coding-style.rst. Issue reported by [email protected].

---
 drivers/staging/dgnc/Kconfig | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)
drivers/staging/dgnc/Kconfig +9 -5
index 032c2a795238..9f4f52c9c27d 100644
@@ -1,6 +1,10 @@
 config DGNC
-       tristate "Digi Neo and Classic PCI Products"
-       default n
-       depends on TTY && PCI
-       ---help---
-       Driver for the Digi International Neo and Classic PCI based product line.
+	tristate "Digi Neo and Classic PCI Products"
+	default n
+	depends on TTY && PCI
+	help
+	  Say Y here to enable support for the Digi International Neo and
+	  Classic PCI based product line.
+
+	  To compile this driver as a module, say M here: the module will be
+	  called dgnc
Signature · 1 line
2.19.0

A message that is not in the archive (sent off-list or not yet received): CA+t4uCMAgpNtpdLfxNY_cmx7WONKOYjiaTBDGRNd+7H_GUdRAA@mail.gmail.com

#9 lore raw
Quoted 6 lines · Lidza Louina

I haven't done work on this driver in a long time. I looked up the devices, and they seem to already have an existing Linux driver: https://www.digi.com/products/usb-and-serial-connectivity/serial-cards/digineo and https://www.digi.com/support/productdetail?pid=1694

I've contacted the company to see if the driver is still needed in staging. I'll send an update once they get back to me.

Lidza

Good luck with that. Digi obsoleted ALL their PCI serial cards several months ago. They would not even respond to requests from me to include their firmware for their PCI dgap cards into the kernel firmware package. The card for the dgnc driver is a pci-e card that may still be supported by them however. Also there does appear to be an already in kernel driver for these "PCI-e" cards too. It actually works as I have a couple of these cards. The module name is "jsm".

03:00.0 Serial controller: Digi International Device 00f0 (rev 02) (prog-if 02 [16550])
Subsystem: Digi International Device 00f0
Control: I/O- Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B- DisINTx-
Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
Interrupt: pin A routed to IRQ 29
Region 0: Memory at f7200000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [40] Power Management version 2
Flags: PMEClk+ DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot+,D3cold-)
Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
Kernel driver in use: jsm
Kernel modules: jsm

Regards
Mark

A message that is not in the archive (sent off-list or not yet received): CA+t4uCPFZSTjyN-Wd3ppOp-edAXfSSTTdT8uab+-E53=Htv9+A@mail.gmail.com

#11 lore raw
Quoted 45 lines · Lidza Louina

On Mon, Oct 1, 2018 at 8:09 AM Mark Hounschell <[email protected] <mailto:[email protected]>> wrote:

On 9/28/18 3:59 PM, Lidza Louina wrote:
> I haven't done work on this driver in a long time. I looked up the > devices, and they seem to already have an existing Linux driver:
>
https://www.digi.com/products/usb-and-serial-connectivity/serial-cards/digineo and

> https://www.digi.com/support/productdetail?pid=1694
>
> I've contacted the company to see if the driver is still needed in > staging. I'll send an update once they get back to me. >
> Lidza
>

Good luck with that. Digi obsoleted ALL their PCI serial cards several months ago. They would not even respond to requests from me to include their firmware for their PCI dgap cards into the kernel firmware package. The card for the dgnc driver is a pci-e card that may still be supported by them however. Also there does appear to be an already in kernel driver for these "PCI-e" cards too. It actually works as I have a
couple of these cards. The module name is "jsm".

03:00.0 Serial controller: Digi International Device 00f0 (rev 02) (prog-if 02 [16550])
         Subsystem: Digi International Device 00f0
         Control: I/O- Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B- DisINTx-
         Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
         Interrupt: pin A routed to IRQ 29
         Region 0: Memory at f7200000 (32-bit, non-prefetchable)
[size=4K]
         Capabilities: [40] Power Management version 2
                 Flags: PMEClk+ DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot+,D3cold-)
                 Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME- Kernel driver in use: jsm
         Kernel modules: jsm

Quoted 6 lines

Regards
Mark

Thanks for the heads up Mark. I've totally neglected this driver and should have caught this earlier. I'm okay with removing it from staging. We can bring it back if they need it.

It may actually be my fault that Greg-KH added the dgnc driver to staging. Shortly after Digi stopped supporting their PCI cards, I had some contact with Greg-KH and sent him all the Digi GPL drivers that I was using at the time for possible inclusion. Digi was no longer maintaining them. I did not know at the time about the jsm driver already being there.

The dgnc driver supports the following PCI cards:

#define PCI_DEVICE_CLASSIC_4_DID                0x0028
#define PCI_DEVICE_CLASSIC_8_DID                0x0029
#define PCI_DEVICE_CLASSIC_4_422_DID            0x00D0
#define PCI_DEVICE_CLASSIC_8_422_DID            0x00D1

The jsm driver supports all of these plus their newer PCI-e cards:

#define PCI_DEVICE_ID_CLASSIC_4         0x0028
#define PCI_DEVICE_ID_CLASSIC_8         0x0029
#define PCI_DEVICE_ID_CLASSIC_4_422     0x00D0
#define PCI_DEVICE_ID_CLASSIC_8_422     0x00D1
#define PCI_DEVICE_ID_NEO_4             0x00B0
#define PCI_DEVICE_ID_NEO_1_422         0x00CC
#define PCI_DEVICE_ID_NEO_1_422_485     0x00CD
#define PCI_DEVICE_ID_NEO_2_422_485     0x00CE
#define PCIE_DEVICE_ID_NEO_8            0x00F0
#define PCIE_DEVICE_ID_NEO_4            0x00F1
#define PCIE_DEVICE_ID_NEO_4RJ45        0x00F2
#define PCIE_DEVICE_ID_NEO_8RJ45        0x00F3

So I think it is safe to remove the dgnc driver from staging. I also think the PCI-e versions defined above are actually still available from Digi as current products.

Regards
Mark

#12 lore raw
In reply to a message not in the archive
Quoted 42 lines · Lidza Louina
Quoted 40 lines · Mark Hounschell
Quoted 3 lines · Lidza Louina

I haven't done work on this driver in a long time. I looked up the devices, and they seem to already have an existing Linux driver:

https://www.digi.com/products/usb-and-serial-connectivity/serial-cards/digineo and

Quoted 7 lines

https://www.digi.com/support/productdetail?pid=1694

I've contacted the company to see if the driver is still needed in staging. I'll send an update once they get back to me.

Lidza

Good luck with that. Digi obsoleted ALL their PCI serial cards several months ago. They would not even respond to requests from me to include their firmware for their PCI dgap cards into the kernel firmware package. The card for the dgnc driver is a pci-e card that may still be supported by them however. Also there does appear to be an already in kernel driver for these "PCI-e" cards too. It actually works as I have a couple of these cards. The module name is "jsm".

03:00.0 Serial controller: Digi International Device 00f0 (rev 02) (prog-if 02 [16550])
Subsystem: Digi International Device 00f0
Control: I/O- Mem+ BusMaster- SpecCycle- MemWINV- VGASnoop-
ParErr- Stepping- SERR- FastB2B- DisINTx-
Status: Cap+ 66MHz+ UDF- FastB2B+ ParErr- DEVSEL=fast >TAbort-
<TAbort- <MAbort- >SERR- <PERR- INTx-
Interrupt: pin A routed to IRQ 29
Region 0: Memory at f7200000 (32-bit, non-prefetchable) [size=4K]
Capabilities: [40] Power Management version 2
Flags: PMEClk+ DSI- D1- D2- AuxCurrent=0mA
PME(D0-,D1-,D2-,D3hot+,D3cold-)
Status: D0 NoSoftRst- PME-Enable- DSel=0 DScale=0 PME-
Kernel driver in use: jsm
Kernel modules: jsm

Quoted 7 lines
Quoted 3 lines

Regards
Mark

Thanks for the heads up Mark. I've totally neglected this driver and should have caught this earlier. I'm okay with removing it from staging. We can bring it back if they need it.

Ok, I'll go delete it, thanks.

greg k-h