atmodem/sms: no mms support for Gemalto

PATCH In review Giacinto Cifelli 2 participants 3 messages Sep 26, 2018 – Sep 27, 2018

Share & tools

Giacinto Cifelli

author

2018-09-26 11:32 UTC #0 lore raw

PATCH 1/1 atmodem/sms: no mms support for Gemalto

---
 drivers/atmodem/sms.c | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

drivers/atmodem/sms.c +11 -6

index 64d0f6e8..db04cb1e 100644
@@ -219,16 +219,21 @@ static void at_cmgs(struct ofono_sms *sms, const unsigned char *pdu,
 	char buf[512];
 	int len;
 
-	switch(data->vendor) {
-	case OFONO_VENDOR_GEMALTO:
-		break;
-	default:
-		if (mms) {
+	if (mms) {
+
+		switch (data->vendor) {
+
+		case OFONO_VENDOR_GEMALTO:
+			/* no mms support */
+			break;
+
+		default:
 			snprintf(buf, sizeof(buf), "AT+CMMS=%d", mms);
 			g_at_chat_send(data->chat, buf, none_prefix,
 					NULL, NULL, NULL);
+			break;
+
 		}
-		break;
 	}
 
 	len = snprintf(buf, sizeof(buf), "AT+CMGS=%d\r", tpdu_len);

Signature · 1 line

2.17.1

Denis Kenzior

2018-09-26 21:34 UTC #1 lore raw

Hi Giacinto,

Quoted 4 lines · Giacinto Cifelli

---
  drivers/atmodem/sms.c | 17 +++++++++++------
  1 file changed, 11 insertions(+), 6 deletions(-)

This patch doesn't apply. I'm guessing it is on top of your local tree and not on top of origin/master.

Regards,
-Denis

Giacinto Cifelli

author

2018-09-27 02:10 UTC #2 lore raw

Hi Denis,

Quoted 11 lines · Denis Kenzior

Hi Giacinto,
Quoted 4 lines · Giacinto Cifelli
---
  drivers/atmodem/sms.c | 17 +++++++++++------
  1 file changed, 11 insertions(+), 6 deletions(-)
This patch doesn't apply. I'm guessing it is on top of your local tree and not on top of origin/master.

yes, I have forgotten to commit out the previous version :( I am going to resubmit soon.

Quoted 3 lines

Regards,
-Denis