Skip to contentSkip to conversation

Fix error handling in at_cmt_notify()

PATCH In review Pavel Machek 2 participants 2 messages Sep 27, 2018

lore
Share & tools
lore

Pavel Machek

author
#0 lore raw

PATCH 1/1 Fix error handling in at_cmt_notify()

at_cmt_notify() calls ofono_error even in case stuff is okay. Fix that.

drivers/atmodem/sms.c +2 -0
index 68b89862..217971e7 100644
@@ -440,6 +436,8 @@ static void at_cmt_notify(GAtResult *result, gpointer user_data)
 	if (data->vendor != OFONO_VENDOR_SIMCOM)
 		at_ack_delivery(sms);
 
+	return;
+
 err:
 	ofono_error("Unable to parse CMT notification");
 }
Signature · 2 lines
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
#1 lore raw

Hi Pavel,

Quoted 4 lines · Pavel Machek

at_cmt_notify() calls ofono_error even in case stuff is okay. Fix that.

I think this was already fixed upstream.

Regards,
-Denis