Skip to contentSkip to conversation

Bad MAINTAINERS pattern in section 'DONGWOON DW9807 LENS VOICE COIL DRIVER'

DISCUSSION Joe Perches 1 participant 1 message Sep 28, 2018 Media (V4L/DVB)

lore
Share & tools
lore

Joe Perches

author Reviewed-by Jacopo Mondi Reviewed-by Tomasz Figa
#0 lore raw

Please fix this defect appropriately.

linux-next MAINTAINERS section:

	4447	DONGWOON DW9807 LENS VOICE COIL DRIVER
	4448	M:	Sakari Ailus <[email protected]>
	4449	L:	[email protected]
	4450	T:	git git://linuxtv.org/media_tree.git
	4451	S:	Maintained
-->	4452	F:	drivers/media/i2c/dw9807.c
	4453	F:	Documentation/devicetree/bindings/media/i2c/dongwoon,dw9807-vcm.txt

Commit that introduced this:

commit 5b0a205466578432ce8faadd08f8d7ef895a180f
Author: Alan Chiang <[email protected]>
Date: Tue Apr 24 22:12:08 2018 -0400

media: dw9807: Add dw9807 vcm driver

DW9807 is a 10 bit DAC from Dongwoon, designed for linear control of voice coil motor.

This driver creates a V4L2 subdevice and
provides control to set the desired focus.

  MAINTAINERS                |   7 +
  drivers/media/i2c/Kconfig  |  10 ++
  drivers/media/i2c/Makefile |   1 +
  drivers/media/i2c/dw9807.c | 329 +++++++++++++++++++++++++++++++++++++++++++++
  4 files changed, 347 insertions(+)

Last commit with drivers/media/i2c/dw9807.c

commit e6c17ada3188e0deb43652b0eed249f37e0d44b0

Author: Sakari Ailus <[email protected]>
Date:   Fri Jul 20 17:07:15 2018 -0400

media: dw9807-vcm: Recognise this is just the VCM bit of the device

The dw9807 contains a voice coil lens driver as well as an EEPROM. This driver is just for the VCM. Reflect this in the driver's name --- this is already the case for the compatible string, for instance.

 drivers/media/i2c/Kconfig                    | 2 +-
 drivers/media/i2c/Makefile                   | 2 +-
 drivers/media/i2c/{dw9807.c => dw9807-vcm.c} | 0
 3 files changed, 2 insertions(+), 2 deletions(-)