Bad MAINTAINERS pattern in section 'SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER'
Please fix this defect appropriately.
linux-next MAINTAINERS section:
12851 SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER 12852 M: Łukasz Stelmach <[email protected]> 12853 L: [email protected] 12854 S: Maintained 12855 F: drivers/char/hw_random/exynos-trng.c
--> 12856 F: Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
Commit that introduced this:
commit 6cd225cc5d8a6526b2bea41955882be55d4f109e
Author: Łukasz Stelmach <[email protected]>
Date: Fri Dec 22 17:48:35 2017 +0100
hwrng: exynos - add Samsung Exynos True RNG driver
Add support for True Random Number Generator found in Samsung Exynos 5250+ SoCs.
MAINTAINERS | 7 ++ drivers/char/hw_random/Kconfig | 12 ++ drivers/char/hw_random/Makefile | 1 + drivers/char/hw_random/exynos-trng.c | 237 +++++++++++++++++++++++++++++++++++ 4 files changed, 257 insertions(+)
No commit with Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt found
Quoted 27 lines · when Joe Perches
Please fix this defect appropriately.
linux-next
MAINTAINERSsection:12851 SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER 12852 M: Łukasz Stelmach <[email protected]> 12853 L: [email protected] 12854 S: Maintained 12855 F: drivers/char/hw_random/exynos-trng.c--> 12856 F:
Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txtCommit that introduced this:
commit
6cd225cc5d8a6526b2bea41955882be55d4f109e
Author: Łukasz Stelmach <[email protected]>
Date: Fri Dec 22 17:48:35 2017 +0100hwrng: exynos - add Samsung Exynos True RNG driver
Add support for True Random Number Generator found in Samsung Exynos 5250+ SoCs.
Signed-off-by Łukasz Stelmach <[email protected]>Reviewed-by Krzysztof Kozlowski <[email protected]>Signed-off-by Herbert Xu <[email protected]>
Quoted 7 lines
MAINTAINERS | 7 ++ drivers/char/hw_random/Kconfig | 12 ++ drivers/char/hw_random/Makefile | 1 + drivers/char/hw_random/exynos-trng.c | 237 +++++++++++++++++++++++++++++++++++ 4 files changed, 257 insertions(+)No commit with
Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txtfound
Please merge the version 3[1] of the patch you've acked[2].
[1] https://www.spinics.net/lists/linux-samsung-soc/msg61372.html
[2] https://www.spinics.net/lists/linux-samsung-soc/msg61272.html
Signature · 3 lines
Łukasz Stelmach Samsung R&D Institute Poland Samsung Electronics
Quoted 35 lines · Łukasz Stelmach
Quoted 33 lines · when Joe Perches
Please fix this defect appropriately.
linux-next
MAINTAINERSsection:12851 SAMSUNG EXYNOS TRUE RANDOM NUMBER GENERATOR (TRNG) DRIVER 12852 M: Łukasz Stelmach <[email protected]> 12853 L: [email protected] 12854 S: Maintained 12855 F: drivers/char/hw_random/exynos-trng.c --> 12856 F: Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txtCommit that introduced this:
commit
6cd225cc5d8a6526b2bea41955882be55d4f109e
Author: Łukasz Stelmach <[email protected]>
Date: Fri Dec 22 17:48:35 2017 +0100hwrng: exynos - add Samsung Exynos True RNG driver
Add support for True Random Number Generator found in Samsung Exynos 5250+ SoCs.
Signed-off-by Łukasz Stelmach <[email protected]>Reviewed-by Krzysztof Kozlowski <[email protected]>Signed-off-by Herbert Xu <[email protected]>MAINTAINERS | 7 ++ drivers/char/hw_random/Kconfig | 12 ++ drivers/char/hw_random/Makefile | 1 + drivers/char/hw_random/exynos-trng.c | 237 +++++++++++++++++++++++++++++++++++ 4 files changed, 257 insertions(+)
Quoted 3 lines
Quoted 1 line
No commit with
Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txtfoundPlease merge the version 3[1] of the patch you've acked[2].
Bindings in a series go in with the rest of the series. If you want me to apply please resend as I don't have year old patches in my inbox.
Rob
PATCH 1/1 dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings
Add binding documentation for the True Random Number Generator found on Samsung Exynos 5250+ SoCs.
--- .../bindings/rng/samsung,exynos5250-trng.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt new file +17 -0
@@ -0,0 +1,17 @@ +Exynos True Random Number Generator + +Required properties: + +- compatible : Should be "samsung,exynos5250-trng". +- reg : Specifies base physical address and size of the registers map. +- clocks : Phandle to clock-controller plus clock-specifier pair. +- clock-names : "secss" as a clock name. + +Example: + + rng@10830600 { + compatible = "samsung,exynos5250-trng"; + reg = <0x10830600 0x100>; + clocks = <&clock CLK_SSS>; + clock-names = "secss"; + };
Signature · 1 line
2.19.0
Re: [PATCH] dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings
Quoted 9 lines · Łukasz Stelmach
Add binding documentation for the True Random Number Generator found on Samsung Exynos 5250+ SoCs.
Signed-off-by Łukasz Stelmach <[email protected]>--- .../bindings/rng/samsung,exynos5250-trng.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
Mine and Rob's tags disappeared already once (v2->v3) and... now again (from v3 to here). Just amend the commit in your local repo and add them permanently.
Best regards,
Krzysztof
Quoted 26 lines
Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt new file +17
-1@@ -0,0 +1,17 @@ +Exynos True Random Number Generator + +Required properties: + +- compatible : Should be "samsung,exynos5250-trng". +- reg : Specifies base physical address and size of the registers map. +- clocks : Phandle to clock-controller plus clock-specifier pair. +- clock-names : "secss" as a clock name. + +Example: + + rng@10830600 { + compatible = "samsung,exynos5250-trng"; + reg = <0x10830600 0x100>; + clocks = <&clock CLK_SSS>; + clock-names = "secss"; + }; --2.19.0
PATCH 1/1 dt-bindings: hwrng: Add Samsung Exynos 5250+ True RNG bindings
In reply to Łukasz StelmachAdd binding documentation for the True Random Number Generator found on Samsung Exynos 5250+ SoCs.
---
This time with proper tags, as requested.
Kind regards,
ŁS
.../bindings/rng/samsung,exynos5250-trng.txt | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) create mode 100644 Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt
Documentation/devicetree/bindings/rng/samsung,exynos5250-trng.txt new file +17 -0
@@ -0,0 +1,17 @@ +Exynos True Random Number Generator + +Required properties: + +- compatible : Should be "samsung,exynos5250-trng". +- reg : Specifies base physical address and size of the registers map. +- clocks : Phandle to clock-controller plus clock-specifier pair. +- clock-names : "secss" as a clock name. + +Example: + + rng@10830600 { + compatible = "samsung,exynos5250-trng"; + reg = <0x10830600 0x100>; + clocks = <&clock CLK_SSS>; + clock-names = "secss"; + };
Signature · 1 line
2.19.0