drm: Convert to using %pOFn instead of device_node.name
Subsystems (4)
PATCH v2 1/1 drm: Convert to using %pOFn instead of device_node.name
In preparation to remove the node name pointer from struct device_node, convert printf users to use the %pOFn format specifier.
For drm_modes.c, the full node path is already printed out, so printing just the node name a 2nd time is redundant and can be removed.
---
v2:
- Add to commit msg that we're dropping redundant printing of node name.
drivers/gpu/drm/drm_modes.c | 4 ++-- drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/drm_modes.c +2 -2
@@ -716,8 +716,8 @@ int of_get_drm_display_mode(struct device_node *np,if (bus_flags)drm_bus_flags_from_videomode (&vm, bus_flags); -pr_debug ("%pOF: got %dx%d display mode from %s\n" , - np, vm.hactive, vm.vactive, np->name); +pr_debug ("%pOF: got %dx%d display mode\n" , + np, vm.hactive, vm.vactive);drm_mode_debug_printmodeline (dmode);return 0 ;
drivers/gpu/drm/msm/hdmi/hdmi.c +1 -1
@@ -579,7 +579,7 @@ static int msm_hdmi_bind(struct device *dev, struct device *master, void *data) hdmi_cfg = (struct hdmi_platform_config *)of_device_get_match_data (dev);if (!hdmi_cfg) { -dev_err (dev,"unknown hdmi_cfg: %s\n" , of_node->name); +dev_err (dev,"unknown hdmi_cfg: %pOFn\n" , of_node);return -ENXIO ; }
Signature · 6 lines
2.17.1 _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
Daniel Vetter
AppliedQuoted 15 lines · Rob Herring
In preparation to remove the node name pointer from struct
device_node, convert printf users to use the %pOFn format specifier.For
drm_modes.c, the full node path is already printed out, so printing just the node name a 2nd time is redundant and can be removed.Cc Gustavo Padovan <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Sean Paul <[email protected]>Cc David Airlie <[email protected]>Acked-by Rob Clark <[email protected]>Signed-off-by Rob Herring <[email protected]>
Quoted 3 lines
---
v2:
- Add to commit msg that we're dropping redundant printing of node name.
Applied, thanks for the patch.
Aside, still don't want drm-misc commit rights so you can offload these yourself?
Cheers, Daniel
Quoted 40 lines
drivers/gpu/drm/drm_modes.c | 4 ++-- drivers/gpu/drm/msm/hdmi/hdmi.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)drivers/gpu/drm/drm_modes.c +2
-2@@ -716,8 +716,8 @@ int of_get_drm_display_mode(struct device_node *np,if (bus_flags)drm_bus_flags_from_videomode (&vm, bus_flags); -pr_debug ("%pOF: got %dx%d display mode from %s\n" , - np, vm.hactive, vm.vactive, np->name); +pr_debug ("%pOF: got %dx%d display mode\n" , + np, vm.hactive, vm.vactive);drm_mode_debug_printmodeline (dmode);return 0 ;drivers/gpu/drm/msm/hdmi/hdmi.c +1
-1@@ -579,7 +579,7 @@ static int msm_hdmi_bind(struct device *dev, struct device *master, void *data) hdmi_cfg = (struct hdmi_platform_config *)of_device_get_match_data (dev);if (!hdmi_cfg) { -dev_err (dev,"unknown hdmi_cfg: %s\n" , of_node->name); +dev_err (dev,"unknown hdmi_cfg: %pOFn\n" , of_node);return -ENXIO ; }Signature · 6 lines
2.17.1 _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoted 21 lines · Daniel Vetter
Quoted 15 lines · Rob Herring
In preparation to remove the node name pointer from struct
device_node, convert printf users to use the %pOFn format specifier.For
drm_modes.c, the full node path is already printed out, so printing just the node name a 2nd time is redundant and can be removed.Cc Gustavo Padovan <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Sean Paul <[email protected]>Cc David Airlie <[email protected]>Acked-by Rob Clark <[email protected]>Signed-off-by Rob Herring <[email protected]>Quoted 3 lines
---
v2:
- Add to commit msg that we're dropping redundant printing of node name.
Quoted 1 line
Applied, thanks for the patch.
It appears this hasn't been.
Quoted 2 lines
Aside, still don't want drm-misc commit rights so you can offload these yourself?
No thanks.
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Quoted 22 lines · Rob Herring
Quoted 21 lines · Daniel Vetter
Quoted 18 lines · Rob Herring
In preparation to remove the node name pointer from struct
device_node, convert printf users to use the %pOFn format specifier.For
drm_modes.c, the full node path is already printed out, so printing just the node name a 2nd time is redundant and can be removed.Cc Gustavo Padovan <[email protected]>Cc Maarten Lankhorst <[email protected]>Cc Sean Paul <[email protected]>Cc David Airlie <[email protected]>Acked-by Rob Clark <[email protected]>Signed-off-by Rob Herring <[email protected]>---
v2:
- Add to commit msg that we're dropping redundant printing of node name.
Quoted 3 lines
Quoted 1 line
Applied, thanks for the patch.
It appears this hasn't been.
It is, just not yet in linux-next. I'll kick the drm-misc maintainers to roll the trees forward.
-Daniel
Quoted 11 lines
Quoted 3 lines
Aside, still don't want drm-misc commit rights so you can offload these yourself?
No thanks.
Rob
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch