staging: rtl8712: Remove unnecessary parentheses
PATCH 1/1 staging: rtl8712: Remove unnecessary parentheses
Remove unnecessary parentheses between 'address-of' operators and a struct members.
Issues found with checkpatch.pl
--- drivers/staging/rtl8712/rtl871x_io.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/rtl8712/rtl871x_io.c +3 -3
@@ -68,7 +68,7 @@ static uint _init_intf_hdl(struct _adapter *padapter,set_intf_option (&pintf_hdl->intf_option);set_intf_funs (pintf_hdl);set_intf_ops (&pintf_hdl->io_ops); - pintf_priv->intf_dev = (u8 *)&(padapter->dvobjpriv); + pintf_priv->intf_dev = (u8 *)&padapter->dvobjpriv;if (init_intf_priv (pintf_priv) == _FAIL) goto _init_intf_hdl_fail;return _SUCCESS;
@@ -92,7 +92,7 @@ static uint register_intf_hdl(u8 *dev, struct intf_hdl *pintfhdl) pintfhdl->intf_option =0 ; pintfhdl->adapter = dev; - pintfhdl->intf_dev = (u8 *)&(adapter->dvobjpriv); + pintfhdl->intf_dev = (u8 *)&adapter->dvobjpriv;if (!_init_intf_hdl (adapter, pintfhdl)) goto register_intf_hdl_fail;return _SUCCESS;
@@ -135,7 +135,7 @@ uint r8712_alloc_io_queue(struct _adapter *adapter)list_add_tail (&pio_req->list, &pio_queue->free_ioreqs); pio_req++; } -if ((register_intf_hdl ((u8 *)adapter, &(pio_queue->intf))) == _FAIL) +if ((register_intf_hdl ((u8 *)adapter, &pio_queue->intf)) == _FAIL) goto alloc_io_queue_fail; adapter->pio_queue = pio_queue;return _SUCCESS;
Signature · 1 line
2.17.1
Quoted 2 lines · Dafna Hirschfeld
Remove unnecessary parentheses between 'address-of' operators and a struct members.
There is a small confusion about singular and plural here. Perhaps the simplest would be "and struct members".
Welcome back and good jon on remembering how all the pieces of a patch fit together :)
julia
Quoted 48 lines
Issues found with checkpatch.pl
Signed-off-by Dafna Hirschfeld <[email protected]>--- drivers/staging/rtl8712/rtl871x_io.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/rtl8712/rtl871x_io.c +3
-4@@ -68,7 +68,7 @@ static uint _init_intf_hdl(struct _adapter *padapter,set_intf_option (&pintf_hdl->intf_option);set_intf_funs (pintf_hdl);set_intf_ops (&pintf_hdl->io_ops); - pintf_priv->intf_dev = (u8 *)&(padapter->dvobjpriv); + pintf_priv->intf_dev = (u8 *)&padapter->dvobjpriv;if (init_intf_priv (pintf_priv) == _FAIL) goto _init_intf_hdl_fail;return _SUCCESS;@@ -92,7 +92,7 @@ static uint register_intf_hdl(u8 *dev, struct intf_hdl *pintfhdl) pintfhdl->intf_option =0 ; pintfhdl->adapter = dev; - pintfhdl->intf_dev = (u8 *)&(adapter->dvobjpriv); + pintfhdl->intf_dev = (u8 *)&adapter->dvobjpriv;if (!_init_intf_hdl (adapter, pintfhdl)) goto register_intf_hdl_fail;return _SUCCESS;@@ -135,7 +135,7 @@ uint r8712_alloc_io_queue(struct _adapter *adapter)list_add_tail (&pio_req->list, &pio_queue->free_ioreqs); pio_req++; } -if ((register_intf_hdl ((u8 *)adapter, &(pio_queue->intf))) == _FAIL) +if ((register_intf_hdl ((u8 *)adapter, &pio_queue->intf)) == _FAIL) goto alloc_io_queue_fail; adapter->pio_queue = pio_queue;return _SUCCESS; --2.17.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20180929151608.25401-1-dafna3%40gmail.com.
For more options, visit https://groups.google.com/d/optout.