mpd: fix yocto-check-layer issue with mulitmedia
PATCH 1/1 mpd: fix yocto-check-layer issue with mulitmedia
ERROR: Nothing PROVIDES 'faad2' (but /home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb DEPENDS on or otherwise requires it)
enable aac only if LICENSE_FLAGS is commercial
[v2]
fix typo in commit message
rebase on latest master
--- meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb +2 -1
@@ -26,7 +26,8 @@ S = "${WORKDIR}/git" EXTRA_OECONF = "enable_bzip2=yes" EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}" -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib" +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib" +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}" PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2" PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
Signature · 1 line
2.17.1
Quoted 7 lines · Armin Kuster
ERROR: Nothing PROVIDES 'faad2' (but
/home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bbDEPENDS on or otherwise requires it)enable aac only if
LICENSE_FLAGSis commercial[v2]
fix typo in commit message
rebase on latest master
This belongs to cover later or under ---.
Quoted 11 lines
Signed-off-by Armin Kuster <[email protected]>--- meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb +0
-0
meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb S = "${WORKDIR}/git" · line 30
Quoted 6 lines
meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb +2
-1@@ -26,7 +26,8 @@ S = "${WORKDIR}/git" EXTRA_OECONF = "enable_bzip2=yes" EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}" -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib" +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib" +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}"
This removes much more than just aac now.
Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?
Quoted 11 lines
meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb +0
-0PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2" PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"Signature · 7 lines
2.17.1 -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Quoted 9 lines · Martin Jansa
Quoted 7 lines · Armin Kuster
ERROR: Nothing PROVIDES 'faad2' (but
/home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bbDEPENDS on or otherwise requires it)enable aac only if
LICENSE_FLAGSis commercial[v2]
fix typo in commit message
rebase on latest masterThis belongs to cover later or under ---.
I failed to have a [V2] in the subject. I guess a V3 is inorder for that.
Can you point me to the doc that says where a [v2] comments in a git header should be. I can not find it. I seem to be reminded that when I do revisions I am doing them wrong.
I don't see reference to this policy:
https://www.openembedded.org/wiki/Styleguide#Patches
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
per kernel process:
"The |---| marker line serves the essential purpose of marking for patch handling tools where the changelog message ends."
Are you saying I should violate that?
is there somewhere else I should be looking?
- armin
Quoted 32 lines
Quoted 11 lines
Signed-off-by Armin Kuster <[email protected]>--- meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb +0
-0meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb S = "${WORKDIR}/git" · line 30
Quoted 6 lines
meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb +2
-1@@ -26,7 +26,8 @@ S = "${WORKDIR}/git" EXTRA_OECONF = "enable_bzip2=yes" EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}" -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib" +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib" +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}"This removes much more than just aac now.
Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?
Quoted 11 lines
meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb +0
-0PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2" PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"Signature · 7 lines
2.17.1 -- _______________________________________________ Openembedded-devel mailing list [email protected] http://lists.openembedded.org/mailman/listinfo/openembedded-devel
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
The --- marker line serves the essential purpose of marking for patch handling tools where the changelog message ends.
One good use for the additional comments after the --- marker is for a diffstat, to show what files have changed, and the number of inserted and deleted lines per file. A diffstat is especially useful on bigger patches. Other comments relevant only to the moment or the maintainer, not suitable for the permanent changelog, should also go here. A good example of such comments might be patch changelogs which describe what has changed between the v1 and v2 version of the patch.
Quoted 74 lines · On Sat, Sep 29, 2018 at 10:16 PM akuster808 <[email protected]> wrote:
On 09/29/2018 12:46 PM, Martin Jansa wrote:
On Sat, Sep 29, 2018 at 12:31:05PM -0700, Armin Kuster wrote:
ERROR: Nothing PROVIDES 'faad2' (but
/home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bbDEPENDS on or otherwise requires it)enable aac only if
LICENSE_FLAGSis commercial[v2]
fix typo in commit message
rebase on latest masterThis belongs to cover later or under ---.
I failed to have a [V2] in the subject. I guess a V3 is inorder for that.
Can you point me to the doc that says where a [v2] comments in a git header should be. I can not find it. I seem to be reminded that when I do revisions I am doing them wrong.
I don't see reference to this policy:
https://www.openembedded.org/wiki/Styleguide#Patches
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
https://www.kernel.org/doc/html/latest/process/submitting-patches.htmlper kernel process:
"The --- marker line serves the essential purpose of marking for patch handling tools where the changelog message ends."
Are you saying I should violate that?is there somewhere else I should be looking?
- armin
Signed-off-by Armin Kuster <[email protected]> <[email protected]>--- meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb +2
-1@@ -26,7 +26,8 @@ S = "${WORKDIR}/git" EXTRA_OECONF = "enable_bzip2=yes" EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}" <$%[email protected]('DISTRO_FEATURES','systemd','--with-systemdsystemunitdir=$%7Bsystemd_unitdir%7D/system/','--without-systemdsystemunitdir',d)%7D> -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib" +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib" +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}" <$%[email protected]('LICENSE_FLAGS','commercial','aac','',d)%7D>This removes much more than just aac now.
Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?
PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2" PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
--
2.17.1--
_______________________________________________
Openembedded-devel mailing [email protected]://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 6 lines · Martin Jansa
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
The --- marker line serves the essential purpose of marking for patch handling tools where the changelog message ends.
Quoted 8 lines
One good use for the additional comments after the --- marker is for a diffstat, to show what files have changed, and the number of inserted and deleted lines per file. A diffstat is especially useful on bigger patches. Other comments relevant only to the moment or the maintainer, not suitable for the permanent changelog, should also go here. A good example of such comments might be patch changelogs which describe what has changed between the v1 and v2 version of the patch.
yeah, i have fixed it locally no need for next rev
Quoted 82 lines · On Sat, Sep 29, 2018 at 10:16 PM akuster808 <[email protected]> wrote:
Quoted 64 lines · Martin Jansa
On Sat, Sep 29, 2018 at 12:31:05PM -0700, Armin Kuster wrote:
ERROR: Nothing PROVIDES 'faad2' (but
/home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bbDEPENDS on or otherwise requires it)enable aac only if
LICENSE_FLAGSis commercial[v2]
fix typo in commit message
rebase on latest masterThis belongs to cover later or under ---.
I failed to have a [V2] in the subject. I guess a V3 is inorder for that.
Can you point me to the doc that says where a [v2] comments in a git header should be. I can not find it. I seem to be reminded that when I do revisions I am doing them wrong.
I don't see reference to this policy:
https://www.openembedded.org/wiki/Styleguide#Patches
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
https://www.kernel.org/doc/html/latest/process/submitting-patches.htmlper kernel process:
"The --- marker line serves the essential purpose of marking for patch handling tools where the changelog message ends."
Are you saying I should violate that?is there somewhere else I should be looking?
- armin
Signed-off-by Armin Kuster <[email protected]> <[email protected]>--- meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb +2
-1@@ -26,7 +26,8 @@ S = "${WORKDIR}/git" EXTRA_OECONF = "enable_bzip2=yes" EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}" <$%[email protected]('DISTRO_FEATURES','systemd','--with-systemdsystemunitdir=$%7Bsystemd_unitdir%7D/system/','--without-systemdsystemunitdir',d)%7D> -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib" +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib" +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}" <$%[email protected]('LICENSE_FLAGS','commercial','aac','',d)%7D>This removes much more than just aac now.
Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?
Quoted 11 lines
PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2" PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
--
2.17.1--
_______________________________________________
Openembedded-devel mailing [email protected]://lists.openembedded.org/mailman/listinfo/openembedded-devel--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Quoted 16 lines · Khem Raj
Quoted 6 lines · Martin Jansa
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
The --- marker line serves the essential purpose of marking for patch handling tools where the changelog message ends.
Quoted 8 lines
One good use for the additional comments after the --- marker is for a diffstat, to show what files have changed, and the number of inserted and deleted lines per file. A diffstat is especially useful on bigger patches. Other comments relevant only to the moment or the maintainer, not suitable for the permanent changelog, should also go here. A good example of such comments might be patch changelogs which describe what has changed between the v1 and v2 version of the patch.
Quoted 1 line
yeah, i have fixed it locally no need for next rev
Only the commit message, right?
Because the PACKAGECONFIG is still incorrect in:
http://cgit.openembedded.org/meta-openembedded-contrib/commit/?h=yoe/mut&id=14a9f80296aa0141ea9a065439970f8fc1e0c36b
There is also typo in the subject and
"mpd: enable aac PACKAGECONFIG only with commercial LICENSE_FLAGS
* fix yocto-check-layer issue with multimedia"
would be better commit message IMHO.
Quoted 82 lines
Quoted 82 lines · On Sat, Sep 29, 2018 at 10:16 PM akuster808 <[email protected]> wrote:
Quoted 64 lines · Martin Jansa
On Sat, Sep 29, 2018 at 12:31:05PM -0700, Armin Kuster wrote:
ERROR: Nothing PROVIDES 'faad2' (but
/home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bbDEPENDS on or otherwise requires it)enable aac only if
LICENSE_FLAGSis commercial[v2]
fix typo in commit message
rebase on latest masterThis belongs to cover later or under ---.
I failed to have a [V2] in the subject. I guess a V3 is inorder for that.
Can you point me to the doc that says where a [v2] comments in a git header should be. I can not find it. I seem to be reminded that when I do revisions I am doing them wrong.
I don't see reference to this policy:
https://www.openembedded.org/wiki/Styleguide#Patches
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
https://www.kernel.org/doc/html/latest/process/submitting-patches.htmlper kernel process:
"The --- marker line serves the essential purpose of marking for patch handling tools where the changelog message ends."
Are you saying I should violate that?is there somewhere else I should be looking?
- armin
Signed-off-by Armin Kuster <[email protected]> <[email protected]>--- meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb +2
-1@@ -26,7 +26,8 @@ S = "${WORKDIR}/git" EXTRA_OECONF = "enable_bzip2=yes" EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}" <$%[email protected]('DISTRO_FEATURES','systemd','--with-systemdsystemunitdir=$%7Bsystemd_unitdir%7D/system/','--without-systemdsystemunitdir',d)%7D> -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib" +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib" +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}" <$%[email protected]('LICENSE_FLAGS','commercial','aac','',d)%7D>This removes much more than just aac now.
Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?
Quoted 11 lines
PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2" PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
--
2.17.1--
_______________________________________________
Openembedded-devel mailing [email protected]://lists.openembedded.org/mailman/listinfo/openembedded-devel--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Signature · 1 line
Martin 'JaMa' Jansa jabber: [email protected]
Correct. Armin I think a v3 is better.
Quoted 117 lines · Martin Jansa
Quoted 16 lines · Khem Raj
Quoted 6 lines · Martin Jansa
https://www.kernel.org/doc/html/latest/process/submitting-patches.html
The --- marker line serves the essential purpose of marking for patch handling tools where the changelog message ends.
Quoted 8 lines
One good use for the additional comments after the --- marker is for a diffstat, to show what files have changed, and the number of inserted and deleted lines per file. A diffstat is especially useful on bigger patches. Other comments relevant only to the moment or the maintainer, not suitable for the permanent changelog, should also go here. A good example of such comments might be patch changelogs which describe what has changed between the v1 and v2 version of the patch.
Quoted 1 line
yeah, i have fixed it locally no need for next rev
Only the commit message, right?
Because the PACKAGECONFIG is still incorrect in:
http://cgit.openembedded.org/meta-openembedded-contrib/commit/?h=yoe/mut&id=14a9f80296aa0141ea9a065439970f8fc1e0c36bThere is also typo in the subject and
"mpd: enable aac PACKAGECONFIG only with commercialLICENSE_FLAGS* fix yocto-check-layer issue with multimedia"
would be better commit message IMHO.
Quoted 71 lines
Quoted 71 lines · On Sat, Sep 29, 2018 at 10:16 PM akuster808 <[email protected]> wrote:
Quoted 69 lines · Martin Jansa
On Sat, Sep 29, 2018 at 12:31:05PM -0700, Armin Kuster wrote:
ERROR: Nothing PROVIDES 'faad2' (but
/home/akuster/oss/maint/meta-openembedded/meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bbDEPENDS on or otherwise requires it)enable aac only if
LICENSE_FLAGSis commercial[v2]
fix typo in commit message
rebase on latest masterThis belongs to cover later or under ---.
I failed to have a [V2] in the subject. I guess a V3 is inorder for that.
Can you point me to the doc that says where a [v2] comments in a git header should be. I can not find it. I seem to be reminded that when I do revisions I am doing them wrong.
I don't see reference to this policy:
https://www.openembedded.org/wiki/Styleguide#Patches
https://www.openembedded.org/wiki/Commit_Patch_Message_Guidelines
https://www.kernel.org/doc/html/latest/process/submitting-patches.htmlper kernel process:
"The --- marker line serves the essential purpose of marking for patch handling tools where the changelog message ends."
Are you saying I should violate that?is there somewhere else I should be looking?
- armin
Signed-off-by Armin Kuster <[email protected]> <[email protected]>--- meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)meta-multimedia/recipes-multimedia/musicpd/mpd_0.20.21.bb +2
-1@@ -26,7 +26,8 @@ S = "${WORKDIR}/git" EXTRA_OECONF = "enable_bzip2=yes" EXTRA_OECONF += "${@bb.utils.contains('DISTRO_FEATURES', 'systemd', '--with-systemdsystemunitdir=${systemd_unitdir}/system/', '--without-systemdsystemunitdir', d)}" <$%[email protected]('DISTRO_FEATURES','systemd','--with-systemdsystemunitdir=$%7Bsystemd_unitdir%7D/system/','--without-systemdsystemunitdir',d)%7D> -PACKAGECONFIG ??= "aac alsa ao bzip2 daemon ffmpeg fifo flac fluidsynth iso9660 jack libsamplerate libwrap httpd mms mpg123 modplug sndfile upnp openal opus oss recorder vorbis wavpack zlib" +PACKAGECONFIG ??= "alsa ao bzip2 ffmpeg flac fluidsynth iso9660 jack libsamplerate mms mpg123 modplug sndfile upnp openal opus vorbis wavpack zlib" +PACKAGECONFIG += "${@bb.utils.contains('LICENSE_FLAGS', 'commercial', 'aac', '', d)}" <$%[email protected]('LICENSE_FLAGS','commercial','aac','',d)%7D>This removes much more than just aac now.
Why did you remove daemon, fifo, libwrap, httpd, oss, recorder, vorbis?
PACKAGECONFIG[aac] = "--enable-aac,--disable-aac,faad2" PACKAGECONFIG[alsa] = "--enable-alsa,--disable-alsa,alsa-lib"
--
2.17.1Quoted 11 lines
Quoted 11 lines
Quoted 6 lines
--
_______________________________________________
Openembedded-devel mailing [email protected]://lists.openembedded.org/mailman/listinfo/openembedded-devel--
_______________________________________________
Openembedded-devel mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-devel--
Martin 'JaMa' Jansa jabber: [email protected]