wpan-hwsim: hardware simulator configuration utility

PATCH In review Alexander Aring 2 participants 4 messages Oct 1, 2018 – Oct 4, 2018

Subsystems (2)

Kbuild IEEE 802.15.4

lore

Share & tools

lore

Alexander Aring

author

2018-10-01 04:27 UTC #0 lore raw

PATCH v2 1/1 wpan-hwsim: hardware simulator configuration utility

This patch adds initial support for wpan-hwsim utility to control the mac802154_hwsim driver over netlink.

Signed-off-by Alexander Aring <[email protected]>

---

Forgot if I ever send v2 but my local change has the last complain. So I resend.

changes since v2:
- help and version both do not need an argument, please use no_argument
- printf("wpan-hwsim " PACKAGE_VERSION "\n");

 Makefile.am                  |   1 +
 configure.ac                 |   1 +
 wpan-hwsim/Makefile.am       |   8 +
 wpan-hwsim/mac802154_hwsim.h |  73 +++++++
 wpan-hwsim/wpan-hwsim.c      | 510 +++++++++++++++++++++++++++++++++++++++++++
 5 files changed, 593 insertions(+)
 create mode 100644 wpan-hwsim/Makefile.am
 create mode 100644 wpan-hwsim/mac802154_hwsim.h
 create mode 100644 wpan-hwsim/wpan-hwsim.c

Makefile.am +1 -0

index 37f18b6..3f15825 100644
@@ -21,4 +21,5 @@ AM_LDFLAGS = \
 SUBDIRS = \
 	src \
 	wpan-ping \
+	wpan-hwsim \
 	examples

configure.ac +1 -0

index 5dd59dc..a983532 100644
@@ -56,6 +56,7 @@ AC_CONFIG_FILES([
         Makefile
 	src/Makefile
 	wpan-ping/Makefile
+	wpan-hwsim/Makefile
 	examples/Makefile
 ])

wpan-hwsim/Makefile.am new file +8 -0

new file mode 100644
index 0000000..f688cd9
@@ -0,0 +1,8 @@
+bin_PROGRAMS = wpan-hwsim
+
+wpan_hwsim_SOURCES = wpan-hwsim.c
+
+wpan_hwsim_CFLAGS = $(AM_CFLAGS) $(LIBNL3_CFLAGS)
+wpan_hwsim_LDADD = $(LIBNL3_LIBS)
+
+EXTRA_DIST = README.wpan-hwsim

wpan-hwsim/mac802154_hwsim.h new file +73 -0

73 lines not on this page · raw message

wpan-hwsim/wpan-hwsim.c new file +510 -0

510 lines not on this page · raw message

Signature · 1 line

2.11.0

Stefan Schmidt

maintainer

2018-10-03 15:01 UTC #1 lore raw

Hello.

Quoted 4 lines · Alexander Aring

This patch adds initial support for wpan-hwsim utility to control the mac802154_hwsim driver over netlink.
Signed-off-by Alexander Aring <[email protected]>

Quoted 8 lines

---
Forgot if I ever send v2 but my local change has the last complain. So I resend.
changes since v2:
- help and version both do not need an argument, please use no_argument
- printf("wpan-hwsim " PACKAGE_VERSION "\n");

Patch has been applied to wpan-tools. Thanks for fixing up my review comments.

Seems we want to get out a new wpan-tools release in the next weeks to have this utility available. I will see what I can do.

regards
Stefan Schmidt

Alexander Aring

author

2018-10-03 21:20 UTC #2 lore raw

Hi,

Quoted 16 lines · Stefan Schmidt

Hello.
Quoted 4 lines · Alexander Aring
This patch adds initial support for wpan-hwsim utility to control the mac802154_hwsim driver over netlink.
Signed-off-by Alexander Aring <[email protected]>
Quoted 8 lines
---
Forgot if I ever send v2 but my local change has the last complain. So I resend.
changes since v2:
- help and version both do not need an argument, please use no_argument
- printf("wpan-hwsim " PACKAGE_VERSION "\n");

Quoted 6 lines

Patch has been applied to wpan-tools. Thanks for fixing up my review comments.
Seems we want to get out a new wpan-tools release in the next weeks to have this utility available. I will see what I can do.

wait please for a fix... I forgot that dot longarg needs no_argument as well...

I begin to hate that interface. I need to define it for short with ':' and then again for long in this struct. I do short sometimes only... I will never do long args again, I fall into mistakes.

btw: I getting an expert to making python bindings... maybe I should make a lib only in C and then all tools getting python based. :-) At least for the next tool which I want to write.

- Alex

Stefan Schmidt

maintainer

2018-10-04 17:27 UTC #3 lore raw

Hello.

Quoted 22 lines · Alexander Aring

Hi,
Quoted 19 lines · Stefan Schmidt
Hello.
Quoted 4 lines · Alexander Aring
This patch adds initial support for wpan-hwsim utility to control the mac802154_hwsim driver over netlink.
Signed-off-by Alexander Aring <[email protected]>
Quoted 8 lines
---
Forgot if I ever send v2 but my local change has the last complain. So I resend.
changes since v2:
- help and version both do not need an argument, please use no_argument
- printf("wpan-hwsim " PACKAGE_VERSION "\n");
Patch has been applied to wpan-tools. Thanks for fixing up my review comments.

Quoted 6 lines

Quoted 3 lines
Seems we want to get out a new wpan-tools release in the next weeks to have this utility available. I will see what I can do.
wait please for a fix... I forgot that dot longarg needs no_argument as well...

No problem. We have time to get fixes in. Juts wanted to make sure we get a new release with the hwsim utility out to match the latest kernel release.

Quoted 3 lines

I begin to hate that interface. I need to define it for short with ':' and then again for long in this struct. I do short sometimes only... I will never do long args again, I fall into mistakes.

Yeah, getopt is not the nicest interface, but doing command line option handling by hand is not nice either.

regards
Stefan Schmidt