Skip to contentSkip to conversation

ssb: chipcommon: fix fall-through annotation

PATCH In review Gustavo A. R. Silva 3 participants 3 messages Oct 3, 2018 – Oct 5, 2018 Sonics silicon backplane driver (ssb)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ssb: chipcommon: fix fall-through annotation

Replace "Fallthough" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough

---
 drivers/ssb/driver_chipcommon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ssb/driver_chipcommon.c +1 -1
index 99a4656..3861cb6 100644
@@ -425,7 +425,7 @@ void ssb_chipco_get_clockcontrol(struct ssb_chipcommon *cc,
 			*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_M2);
 			break;
 		}
-		/* Fallthough */
+		/* Fall through */
 	default:
 		*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_SB);
 	}
Signature · 1 line
2.7.4
maintainer Acked-by on v1 1/1
#1 lore raw
Quoted 15 lines · On Wed, 3 Oct 2018 14:01:02 +0200 "Gustavo A. R. Silva"…

Replace "Fallthough" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough

---
 drivers/ssb/driver_chipcommon.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/ssb/driver_chipcommon.c +0 -0
index 99a4656..3861cb6 100644

drivers/ssb/driver_chipcommon.c void ssb_chipco_get_clockcontrol(struct ssb_chipcommon *cc, · line 431

Quoted 8 lines
drivers/ssb/driver_chipcommon.c +1 -1
@@ -425,7 +425,7 @@ void ssb_chipco_get_clockcontrol(struct ssb_chipcommon *cc,
 			*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_M2);
 			break;
 		}
-		/* Fallthough */
+		/* Fall through */
 	default:
 		*m = chipco_read32(cc, SSB_CHIPCO_CLOCK_SB);
 	}
Signature · 1 line
Michael
#2 lore raw
In reply to Gustavo A. R. Silva
Quoted 7 lines · Gustavo A. R. Silva

Replace "Fallthough" with a proper "fall through" annotation.

This fix is part of the ongoing efforts to enabling -Wimplicit-fallthrough

Patch applied to wireless-drivers-next.git, thanks.

74aa3586c599 ssb: chipcommon: fix fall-through annotation

Signature · 3 lines
https://patchwork.kernel.org/patch/10624745/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches