Skip to contentSkip to conversation

mfd: cros_ec: Do not attempt to register a non-positive IRQ number

PATCH In review Enrico Granata 1 participant 1 message Oct 3, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/2 mfd: cros_ec: Do not attempt to register a non-positive IRQ number

From: Enrico Granata <[email protected]>

Add a layer of sanity checking to cros_ec_register against attempting to register IRQ values that are not strictly greater than 0.

---
 drivers/mfd/cros_ec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/mfd/cros_ec.c +1 -1
index 65a9757a6d21..d6b21e11cad6 100644
@@ -118,7 +118,7 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
 		return err;
 	}
 
-	if (ec_dev->irq) {
+	if (ec_dev->irq > 0) {
 		err = devm_request_threaded_irq(dev, ec_dev->irq, NULL,
 				ec_irq_thread, IRQF_TRIGGER_LOW | IRQF_ONESHOT,
 				"chromeos-ec", ec_dev);
Signature · 1 line
2.19.0.605.g01d371f741-goog