Skip to contentSkip to conversation

ndctl, check-labels: correct check-labels message wording

PATCH In review Robert Elliott 2 participants 2 messages Oct 3, 2018 – Oct 4, 2018 libnvdimm: non-volatile memory device

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ndctl, check-labels: correct check-labels message wording

ndctl check-labels prints the number of labels, not the number of nmems. Changed the print for:

$ ndctl check-labels nmem0 nmem1
from:
    successfully verified 510 nmems
to:
    successfully verified 510 nmem labels
---
 ndctl/dimm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
ndctl/dimm.c +1 -1
index a4203f3..699ab57 100644
@@ -1147,7 +1147,7 @@ int cmd_check_labels(int argc, const char **argv, void *ctx)
 	int count = dimm_action(argc, argv, ctx, action_check, base_options,
 			"ndctl check-labels <nmem0> [<nmem1>..<nmemN>] [<options>]");
 
-	fprintf(stderr, "successfully verified %d nmem%s\n",
+	fprintf(stderr, "successfully verified %d nmem label%s\n",
 			count >= 0 ? count : 0, count > 1 ? "s" : "");
 	return count >= 0 ? 0 : EXIT_FAILURE;
 }
Signature · 6 lines
2.14.4

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm
Reviewed-by on v1 1/1
#1 lore raw
Quoted 9 lines · Robert Elliott

ndctl check-labels prints the number of labels, not the number of nmems. Changed the print for:

$ ndctl check-labels nmem0 nmem1
from:
    successfully verified 510 nmems
to:
    successfully verified 510 nmem labels

Looks good to me.

Quoted 22 lines
---
 ndctl/dimm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
ndctl/dimm.c +1 -2
index a4203f3..699ab57 100644
@@ -1147,7 +1147,7 @@ int cmd_check_labels(int argc, const char **argv, void *ctx)
        int count = dimm_action(argc, argv, ctx, action_check, base_options,
                        "ndctl check-labels <nmem0> [<nmem1>..<nmemN>] [<options>]");
 
-       fprintf(stderr, "successfully verified %d nmem%s\n",
+       fprintf(stderr, "successfully verified %d nmem label%s\n",
                        count >= 0 ? count : 0, count > 1 ? "s" : "");
        return count >= 0 ? 0 : EXIT_FAILURE;
 }
--

2.14.4

Quoted 4 lines

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm

_______________________________________________
Linux-nvdimm mailing list
[email protected]
https://lists.01.org/mailman/listinfo/linux-nvdimm