staging: emxx_udc: Remove unused device_desc declaration
PATCH 1/1 staging: emxx_udc: Remove unused device_desc declaration
Clang warns:
drivers/staging/emxx_udc/emxx_udc.c:1373:37: warning: variable 'device_desc' is not needed and will not be emitted [-Wunneeded-internal-declaration]
static struct usb_device_descriptor device_desc = {
^1 warning generated.
This definition hasn't been attached to anything since the driver was introduced in commit 33aa8d45a4fe ("staging: emxx_udc: Add Emma Mobile USB Gadget driver") and neither GCC nor Clang emit any reference to the variable in the final assembly. The only reason GCC doesn't warn about this variable being unused is the sizeof function.
---
This seems kind of wrong given this is a USB driver but there isn't an instance of a platform_driver in the kernel tree having a usb device descriptor declaration so I'm unsure of how to handle this warning aside from just removing the definition but I'm certainly open to suggestions.
drivers/staging/emxx_udc/emxx_udc.c | 19 ------------------- 1 file changed, 19 deletions(-)
drivers/staging/emxx_udc/emxx_udc.c +0 -19
@@ -1368,25 +1368,6 @@ static void _nbu2ss_set_endpoint_stall( } } -/*-------------------------------------------------------------------------*/ -/* Device Descriptor */ -static struct usb_device_descriptor device_desc = { - .bLength =sizeof (device_desc), - .bDescriptorType =USB_DT_DEVICE , - .bcdUSB =cpu_to_le16 (0x0200 ), - .bDeviceClass =USB_CLASS_VENDOR_SPEC , - .bDeviceSubClass =0x00 , - .bDeviceProtocol =0x00 , - .bMaxPacketSize0 =64 , - .idVendor =cpu_to_le16 (0x0409 ), - .idProduct =cpu_to_le16 (0xfff0 ), - .bcdDevice =0xffff , - .iManufacturer =0x00 , - .iProduct =0x00 , - .iSerialNumber =0x00 , - .bNumConfigurations =0x01 , -}; -/*-------------------------------------------------------------------------*/ static void _nbu2ss_set_test_mode (struct nbu2ss_udc *udc,u32 mode) {
Signature · 1 line
2.19.0
Quoted 16 lines · Nathan Chancellor
Clang warns:
drivers/staging/emxx_udc/emxx_udc.c:1373:37: warning: variable 'device_desc' is not needed and will not be emitted [-Wunneeded-internal-declaration]static struct usb_device_descriptor device_desc = { ^1 warning generated.
This definition hasn't been attached to anything since the driver was introduced in commit
33aa8d45a4fe("staging:emxx_udc: Add Emma Mobile USB Gadget driver") and neither GCC nor Clang emit any reference to the variable in the final assembly. The only reason GCC doesn't warn about this variable being unused is the sizeof function.
Quoted 8 lines
Reported-by Nick Desaulniers <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>---
This seems kind of wrong given this is a USB driver but there isn't an instance of a
platform_driverin the kernel tree having a usb device descriptor declaration so I'm unsure of how to handle this warning aside from just removing the definition but I'm certainly open to suggestions.
In drivers under drivers/usb/gadget/legacy/{ether|mass_storage|hid}.c, it seems that addresses of instances of struct usb_device_descriptor are stored in instances of struct usb_composite_driver eth_driver that are passed to module_usb_composite_driver().
drivers/staging/emxx_udc/emxx_udc.c doesn't mention anything about being a composite driver, and I don't know if there are multiple devices to warrant a composite driver? Composite seems to imply "more than one gadget" while the path to drivers using this interface under drivers/usb/gadget/legacy/ seem to imply there's a modern (non-legacy) usb gadget interface that could potentially be used instead.
If this was never intended to be a composite usb driver, or there's some reason why it doesn't make sense for it to be one, then this code is likely dead and your fix is correct. If it's not, maybe folks who know more about the USB interfaces have another solution to make this a composite usb driver?
Quoted 37 lines
drivers/staging/emxx_udc/emxx_udc.c | 19 ------------------- 1 file changed, 19 deletions(-)drivers/staging/emxx_udc/emxx_udc.c +0
-20@@ -1368,25 +1368,6 @@ static void _nbu2ss_set_endpoint_stall( } } -/*-------------------------------------------------------------------------*/ -/* Device Descriptor */ -static struct usb_device_descriptor device_desc = { - .bLength =sizeof (device_desc), - .bDescriptorType =USB_DT_DEVICE , - .bcdUSB =cpu_to_le16 (0x0200 ), - .bDeviceClass =USB_CLASS_VENDOR_SPEC , - .bDeviceSubClass =0x00 , - .bDeviceProtocol =0x00 , - .bMaxPacketSize0 =64 , - .idVendor =cpu_to_le16 (0x0409 ), - .idProduct =cpu_to_le16 (0xfff0 ), - .bcdDevice =0xffff , - .iManufacturer =0x00 , - .iProduct =0x00 , - .iSerialNumber =0x00 , - .bNumConfigurations =0x01 , -}; -/*-------------------------------------------------------------------------*/ static void _nbu2ss_set_test_mode (struct nbu2ss_udc *udc,u32 mode) { --2.19.0
Signature · 2 lines
Thanks, ~Nick Desaulniers
Greg KH
maintainerQuoted 39 lines · Nick Desaulniers
Quoted 16 lines · Nathan Chancellor
Clang warns:
drivers/staging/emxx_udc/emxx_udc.c:1373:37: warning: variable 'device_desc' is not needed and will not be emitted [-Wunneeded-internal-declaration]static struct usb_device_descriptor device_desc = { ^1 warning generated.
This definition hasn't been attached to anything since the driver was introduced in commit
33aa8d45a4fe("staging:emxx_udc: Add Emma Mobile USB Gadget driver") and neither GCC nor Clang emit any reference to the variable in the final assembly. The only reason GCC doesn't warn about this variable being unused is the sizeof function.Quoted 8 lines
Reported-by Nick Desaulniers <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>---
This seems kind of wrong given this is a USB driver but there isn't an instance of a
platform_driverin the kernel tree having a usb device descriptor declaration so I'm unsure of how to handle this warning aside from just removing the definition but I'm certainly open to suggestions.In drivers under drivers/usb/gadget/legacy/{ether|mass_storage|hid}.c, it seems that addresses of instances of
struct usb_device_descriptorare stored in instances ofstruct usb_composite_driver eth_driverthat are passed tomodule_usb_composite_driver().
drivers/staging/emxx_udc/emxx_udc.cdoesn't mention anything about being a composite driver, and I don't know if there are multiple devices to warrant a composite driver? Composite seems to imply "more than one gadget" while the path to drivers using this interface underdrivers/usb/gadget/legacy/seem to imply there's a modern (non-legacy) usb gadget interface that could potentially be used instead.
Quoted 5 lines
If this was never intended to be a composite usb driver, or there's some reason why it doesn't make sense for it to be one, then this code is likely dead and your fix is correct. If it's not, maybe folks who know more about the USB interfaces have another solution to make this a composite usb driver?
I'll take the patch, the code looks wrong, it should not be needed here.
thanks,
greg k-h