Skip to contentSkip to conversation

EDAC, dsm_edac: Wrap ACPI DSM methods for address translation

PATCH New Borislav Petkov 1 participant 1 message Oct 4, 2018 EDAC-core

lore
Share & tools
lore

Borislav Petkov

author maintainer
#0 lore raw

PATCH 4/5 EDAC, dsm_edac: Wrap ACPI DSM methods for address translation

Quoted 6 lines · Tony

The plan going forward is that EDAC drivers can be much smaller. They just need to discover memory controller and DIMM topology and register a handler on the mce_decode_chain. All the work in turning system addresses into DIMM addresses can be handled by a call to the BIOS (which knows how to do this, and the people writing it have resources to validate on way more configurations than I can).

So this sounds like drivers/acpi/acpi_extlog.c which you guys did. Is that thing being abandoned now too, for yet another thing?

And that extlog thing is under drivers/acpi/. So even if the DSM stuff is *maybe* going to be part of the ACPI spec, I believe drivers/acpi/ is where it should go. As in: preparing to become part of ACPI :-)

But, there's another aspect: is this DSM interface going to be used only by EDAC or some other subsystems? (It seems so.)

Because if it is going to be used by EDAC only and EDAC drivers will reg/unreg with it, then I guess making it part of the EDAC core, would probably be more fitting. Something like drivers/edac/dsm.c and then you don't have to have another module which needs to sync with the *actual* EDAC module...

Practically, this is going to be enabled on 99.9% of the boxes so making it part of the core is, I guess, just as well.