firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
Subsystems (2)
Rodrigo Vivi
maintainerPATCH 1/1 firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
From: Anusha Srivatsa <[email protected]>
Add missing MODULE_FIRMWARE while loading DMC ICL.
v2: Add Fixes tag. (Rodrigo)
v3: Rebase by Rodrigo after 7fe78985cd08 ("drm/i915/csr: restructure CSR firmware definition macros")
--- drivers/gpu/drm/i915/intel_csr.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_csr.c +1 -0
@@ -37,6 +37,7 @@#define ICL_CSR_PATH "i915/icl_dmc_ver1_07.bin"#define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)#define ICL_CSR_MAX_FW_SIZE 0x6000 +MODULE_FIRMWARE (ICL_CSR_PATH );#define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bin"#define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✗ Fi.CI.CHECKPATCH: warning for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)
== Series Details ==
== Series Details ==
Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)
URL : https://patchwork.freedesktop.org/series/49678/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
751aeeb3a90f firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
-:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 7fe78985cd08 ("drm/i915/csr: restructure CSR firmware definition macros")'
#9:
v3: Rebase by Rodrigo after 7fe78985cd08 ("drm/i915/csr: restructure CSRtotal: 1 errors, 0 warnings, 0 checks, 7 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerRe: ✗ Fi.CI.CHECKPATCH: warning for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)
Quoted 11 lines · Patchwork
== Series Details ==
Series:
firmware/dmc/icl: Add missingMODULE_FIRMWARE()for Icelake. (rev2)
URL : https://patchwork.freedesktop.org/series/49678/
State : warning== Summary ==
$ dim checkpatch origin/drm-tip 751aeeb3a90f firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. -:9: ERROR:GIT_COMMIT_ID: Please use git commit description style 'commit <12+ chars of sha1> ("<title line>")' - ie: 'commit 7fe78985cd08 ("drm/i915/csr: restructure CSR firmware definition macros")'
I think we need to change dim cite to use exact same line as cp requires :/
Quoted 9 lines
#9:
v3: Rebase by Rodrigo after7fe78985cd08("drm/i915/csr: restructure CSRtotal: 1 errors, 0 warnings, 0 checks, 7 lines checked
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerPATCH 1/1 firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
In reply to PatchworkFrom: Anusha Srivatsa <[email protected]>
Add missing MODULE_FIRMWARE while loading DMC ICL.
v2: Add Fixes tag. (Rodrigo)
v3: Rebase by Rodrigo after commit 7fe78985cd08 ("drm/i915/csr:
restructure CSR firmware definition macros")
v4: Rodrigo fixing his own mess on commit mentioning on v3
comment above.
--- drivers/gpu/drm/i915/intel_csr.c | 1 + 1 file changed, 1 insertion(+)
drivers/gpu/drm/i915/intel_csr.c +1 -0
@@ -37,6 +37,7 @@#define ICL_CSR_PATH "i915/icl_dmc_ver1_07.bin"#define ICL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)#define ICL_CSR_MAX_FW_SIZE 0x6000 +MODULE_FIRMWARE (ICL_CSR_PATH );#define CNL_CSR_PATH "i915/cnl_dmc_ver1_07.bin"#define CNL_CSR_VERSION_REQUIRED CSR_VERSION(1, 7)
Signature · 6 lines
2.17.1 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Em Qui, 2018-10-04 às 15:36 -0700, Rodrigo Vivi escreveu:
Quoted 11 lines
From: Anusha Srivatsa <[email protected]>
Add missing
MODULE_FIRMWAREwhile loading DMC ICL.v2: Add Fixes tag. (Rodrigo)
v3: Rebase by Rodrigo after commit7fe78985cd08("drm/i915/csr:
restructure CSR firmware definition macros")
v4: Rodrigo fixing his own mess on commit mentioning on v3
comment above.Fixes 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.")
Yes, please. I wasted time because I lacked this commit.
Quoted 22 lines
Cc Rodrigo Vivi <[email protected]>Cc Paulo Zanoni <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]> (v2)Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_csr.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/i915/intel_csr.c +0
-0@@ -37,6 +37,7 @@#define ICL_CSR_PATH "i915/icl_dmc_ver1_07.bin"
#defineICL_CSR_VERSION_REQUIREDCSR_VERSION(1, 7)
#defineICL_CSR_MAX_FW_SIZE0x6000
+MODULE_FIRMWARE(ICL_CSR_PATH);
Quoted 3 lines
#define
CNL_CSR_PATH"i915/cnl_dmc_ver1_07.bi
n"
#defineCNL_CSR_VERSION_REQUIREDCSR_VERSION(1, 7)
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Rodrigo Vivi
maintainerQuoted 11 lines · Paulo Zanoni
Em Qui, 2018-10-04 às 15:36 -0700, Rodrigo Vivi escreveu:
Quoted 10 lines
From: Anusha Srivatsa <[email protected]>
Add missing
MODULE_FIRMWAREwhile loading DMC ICL.v2: Add Fixes tag. (Rodrigo)
v3: Rebase by Rodrigo after commit7fe78985cd08("drm/i915/csr:
restructure CSR firmware definition macros")
v4: Rodrigo fixing his own mess on commit mentioning on v3
comment above.
Quoted 5 lines
Quoted 1 line
Fixes 4445930f1c4a ("firmware/dmc/icl: load v1.07 on icelake.")Yes, please. I wasted time because I lacked this commit.
Tested-by Paulo Zanoni <[email protected]>
pushed, thanks
Quoted 23 lines
Quoted 23 lines
Cc Rodrigo Vivi <[email protected]>Cc Paulo Zanoni <[email protected]>Cc Jani Nikula <[email protected]>Signed-off-by Anusha Srivatsa <[email protected]>Reviewed-by Rodrigo Vivi <[email protected]> (v2)Signed-off-by Rodrigo Vivi <[email protected]>--- drivers/gpu/drm/i915/intel_csr.c | 1 + 1 file changed, 1 insertion(+)drivers/gpu/drm/i915/intel_csr.c +0
-0@@ -37,6 +37,7 @@#define ICL_CSR_PATH "i915/icl_dmc_ver1_07.bin"
#defineICL_CSR_VERSION_REQUIREDCSR_VERSION(1, 7)
#defineICL_CSR_MAX_FW_SIZE0x6000
+MODULE_FIRMWARE(ICL_CSR_PATH);
Quoted 7 lines
Quoted 3 lines
#define
CNL_CSR_PATH"i915/cnl_dmc_ver1_07.bi
n"
#defineCNL_CSR_VERSION_REQUIREDCSR_VERSION(1, 7)_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev3)
In reply to Patchwork== Series Details ==
== Series Details ==
Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev3)
URL : https://patchwork.freedesktop.org/series/49678/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4932 -> Patchwork_10367 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49678/revisions/3/mbox/
== Changes ==
No changes found
== Participating hosts (48 -> 41) ==
Additional (1): fi-pnv-d510
Missing (8): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-icl-u2 fi-bwr-2160 fi-bsw-cyan fi-ctg-p8600 fi-bdw-samus
== Build changes ==
* Linux: CI_DRM_4932 -> Patchwork_10367
CI_DRM_4932: 21f90148bf7adb33d82580013a5697a6bbb88248 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4669: 5f40e617cd9c1e089f4a2d79c53a417d891e3e3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10367: 19ea29a1d3529803eeb934b1f05a16d240df5e22 @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
19ea29a1d352 firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10367/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev3)
In reply to Patchwork== Series Details ==
== Series Details ==
Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev3)
URL : https://patchwork.freedesktop.org/series/49678/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4932_full -> Patchwork_10367_full =
== Summary - WARNING ==
Minor unknown changes coming with Patchwork_10367_full need to be verified manually.
If you think the reported changes have nothing to do with the changes introduced in Patchwork_10367_full, please notify your bug team to allow them to document this new failure mode, which will reduce false positives in CI.
== Possible new issues ==
Here are the unknown changes that may have been introduced in Patchwork_10367_full:
=== IGT changes ===
==== Warnings ====
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-move:
shard-snb: PASS -> SKIP== Known issues ==
Here are the changes found in Patchwork_10367_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_eio@in-flight-internal-10ms:
shard-glk: PASS -> FAIL (fdo#105957)
igt@gem_exec_await@wide-contexts:
shard-apl: PASS -> FAIL (fdo#106680)
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-c:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956) +2
igt@kms_cursor_crc@cursor-128x128-suspend:
shard-glk: PASS -> FAIL (fdo#103232) +1
igt@kms_cursor_crc@cursor-128x42-random:
shard-apl: PASS -> FAIL (fdo#103232) +2
igt@kms_cursor_crc@cursor-256x256-suspend:
shard-apl: PASS -> FAIL (fdo#103232, fdo#103191)
igt@kms_cursor_legacy@2x-long-cursor-vs-flip-legacy:
shard-hsw: PASS -> FAIL (fdo#105767)
igt@kms_cursor_legacy@cursor-vs-flip-toggle:
shard-hsw: PASS -> FAIL (fdo#103355)
igt@kms_cursor_legacy@cursorb-vs-flipb-toggle:
shard-glk: PASS -> DMESG-WARN (fdo#106538, fdo#105763)
igt@kms_fbcon_fbt@psr:
shard-skl: NOTRUN -> FAIL (fdo#107882)
igt@kms_flip@flip-vs-expired-vblank:
shard-skl: PASS -> FAIL (fdo#105363)
igt@kms_flip@flip-vs-expired-vblank-interruptible:
shard-glk: PASS -> FAIL (fdo#105363, fdo#102887)
igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-indfb-draw-mmap-wc:
shard-skl: PASS -> FAIL (fdo#105682) +1
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-pwrite:
shard-apl: PASS -> FAIL (fdo#103167) +2
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
shard-glk: PASS -> FAIL (fdo#103167) +3
{igt@kms_plane_alpha_blend@pipe-a-alpha-opaque-fb}:
shard-skl: NOTRUN -> FAIL (fdo#108145) +2
{igt@kms_plane_alpha_blend@pipe-a-coverage-7efc}:
shard-skl: PASS -> FAIL (fdo#108145)
{igt@kms_plane_alpha_blend@pipe-c-alpha-opaque-fb}:
shard-glk: PASS -> FAIL (fdo#108145)
igt@kms_plane_multiple@atomic-pipe-b-tiling-x:
shard-apl: PASS -> FAIL (fdo#103166) +1
igt@kms_setmode@basic:
shard-hsw: PASS -> FAIL (fdo#99912)
igt@kms_universal_plane@universal-plane-pipe-c-functional:
shard-glk: PASS -> FAIL (fdo#103166) +3
==== Possible fixes ====
igt@kms_busy@extended-pageflip-hang-newfb-render-b:
shard-glk: DMESG-WARN (fdo#107956) -> PASS
igt@kms_ccs@pipe-b-crc-sprite-planes-basic:
shard-glk: FAIL (fdo#108145) -> PASS
igt@kms_color@pipe-a-ctm-max:
shard-apl: FAIL (fdo#108147) -> PASS
igt@kms_cursor_crc@cursor-256x256-onscreen:
shard-glk: FAIL (fdo#103232) -> PASS
igt@kms_cursor_crc@cursor-64x21-sliding:
shard-apl: FAIL (fdo#103232) -> PASS +2
igt@kms_draw_crc@draw-method-xrgb8888-render-untiled:
shard-skl: FAIL -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-cur-indfb-draw-mmap-gtt:
shard-apl: FAIL (fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-fullscreen:
shard-glk: FAIL (fdo#103167) -> PASS +2
igt@kms_frontbuffer_tracking@fbcpsr-rgb565-draw-mmap-gtt:
shard-skl: FAIL (fdo#105682) -> PASS
igt@kms_plane@plane-position-covered-pipe-a-planes:
shard-glk: FAIL (fdo#103166) -> PASS +2
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
igt@pm_rpm@modeset-lpsp-stress-no-wait:
shard-skl: INCOMPLETE (fdo#107807) -> PASS {name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#102887 https://bugs.freedesktop.org/show_bug.cgi?id=102887
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103191 https://bugs.freedesktop.org/show_bug.cgi?id=103191
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103355 https://bugs.freedesktop.org/show_bug.cgi?id=103355
fdo#105363 https://bugs.freedesktop.org/show_bug.cgi?id=105363
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#105767 https://bugs.freedesktop.org/show_bug.cgi?id=105767
fdo#105957 https://bugs.freedesktop.org/show_bug.cgi?id=105957
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107882 https://bugs.freedesktop.org/show_bug.cgi?id=107882
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#108147 https://bugs.freedesktop.org/show_bug.cgi?id=108147
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4932 -> Patchwork_10367
CI_DRM_4932: 21f90148bf7adb33d82580013a5697a6bbb88248 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4669: 5f40e617cd9c1e089f4a2d79c53a417d891e3e3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10367: 19ea29a1d3529803eeb934b1f05a16d240df5e22 @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10367/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)
In reply to Rodrigo Vivi== Series Details ==
== Series Details ==
Series: firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake. (rev2)
URL : https://patchwork.freedesktop.org/series/49678/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4932 -> Patchwork_10366 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/49678/revisions/2/mbox/
== Known issues ==
Here are the changes found in Patchwork_10366 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
== Participating hosts (48 -> 40) ==
Additional (1): fi-pnv-d510
Missing (9): fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-icl-u2 fi-bwr-2160 fi-bsw-cyan fi-ctg-p8600 fi-icl-u fi-bdw-samus
== Build changes ==
* Linux: CI_DRM_4932 -> Patchwork_10366
CI_DRM_4932: 21f90148bf7adb33d82580013a5697a6bbb88248 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4669: 5f40e617cd9c1e089f4a2d79c53a417d891e3e3c @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10366: 751aeeb3a90f190fb115cc679f45fbed941d27cf @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
751aeeb3a90f firmware/dmc/icl: Add missing MODULE_FIRMWARE() for Icelake.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10366/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx