Skip to contentSkip to conversation

nvmem: lpc18xx_eeprom: fix compile warning

PATCH In review Gustavo A. R. Silva 2 participants 3 messages Oct 5, 2018

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 nvmem: lpc18xx_eeprom: fix compile warning

Fix the following warning by removing unused variable ret:

drivers/nvmem/lpc18xx_eeprom.c: In function ?lpc18xx_eeprom_remove?:
drivers/nvmem/lpc18xx_eeprom.c:258:6: warning: unused variable ?ret? [-Wunused-variable]

  int ret;
      ^~~
---
 drivers/nvmem/lpc18xx_eeprom.c | 1 -
 1 file changed, 1 deletion(-)
drivers/nvmem/lpc18xx_eeprom.c +0 -1
index b42dbad..66cff1e 100644
@@ -255,7 +255,6 @@ static int lpc18xx_eeprom_probe(struct platform_device *pdev)
 static int lpc18xx_eeprom_remove(struct platform_device *pdev)
 {
 	struct lpc18xx_eeprom_dev *eeprom = platform_get_drvdata(pdev);
-	int ret;
 
 	clk_disable_unprepare(eeprom->clk);
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 9 lines · Gustavo A. R. Silva

Fix the following warning by removing unused variable ret:

drivers/nvmem/lpc18xx_eeprom.c: In function ?lpc18xx_eeprom_remove?:
drivers/nvmem/lpc18xx_eeprom.c:258:6: warning: unused variable ?ret? [-Wunused-variable]

   int ret;
       ^~~

There is already a patch submitted fix this

https://lore.kernel.org/patchwork/patch/995032/

-srini

Quoted 17 lines
---
  drivers/nvmem/lpc18xx_eeprom.c | 1 -
  1 file changed, 1 deletion(-)
drivers/nvmem/lpc18xx_eeprom.c +0 -1
index b42dbad..66cff1e 100644
@@ -255,7 +255,6 @@ static int lpc18xx_eeprom_probe(struct platform_device *pdev)
  static int lpc18xx_eeprom_remove(struct platform_device *pdev)
  {
  	struct lpc18xx_eeprom_dev *eeprom = platform_get_drvdata(pdev);
-	int ret;
 
  	clk_disable_unprepare(eeprom->clk);
 
#2 lore raw
Quoted 11 lines · Srinivas Kandagatla
Quoted 8 lines · Gustavo A. R. Silva

Fix the following warning by removing unused variable ret:

drivers/nvmem/lpc18xx_eeprom.c: In function ?lpc18xx_eeprom_remove?:
drivers/nvmem/lpc18xx_eeprom.c:258:6: warning: unused variable ?ret? [-Wunused-variable]
?? int ret;
?????? ^~~

Quoted 6 lines
Quoted 1 line

There is already a patch submitted fix this

?https://lore.kernel.org/patchwork/patch/995032/

Oh, good to know.

Thanks, Srini.
--
Gustavo