NFC: st21nfca: Mark expected switch fall-through

PATCH New Gustavo A. R. Silva 1 participant 1 message Oct 5, 2018 NFC

lore

Share & tools

lore

Gustavo A. R. Silva

author

2018-10-05 07:23 UTC #0 lore raw

PATCH 1/1 NFC: st21nfca: Mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1373889 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/nfc/st21nfca/dep.c | 1 +
 1 file changed, 1 insertion(+)

drivers/nfc/st21nfca/dep.c +1 -0

index 3420c51..6219e92 100644
@@ -620,6 +620,7 @@ static void st21nfca_im_recv_dep_res_cb(void *context, struct sk_buff *skb,
 		switch (ST21NFCA_NFC_DEP_PFB_TYPE(dep_res->pfb)) {
 		case ST21NFCA_NFC_DEP_PFB_ACK_NACK_PDU:
 			pr_err("Received a ACK/NACK PDU\n");
+			/* fall through */
 		case ST21NFCA_NFC_DEP_PFB_I_PDU:
 			info->dep_info.curr_nfc_dep_pni =
 			    ST21NFCA_NFC_DEP_PFB_PNI(dep_res->pfb + 1);

Signature · 1 line

2.7.4