mmc: meson-mx-sdio: mark expected switch fall-through

PATCH In review Gustavo A. R. Silva 3 participants 4 messages Oct 5, 2018

Subsystems (2)

Arm/Amlogic Meson SoC support MMC, SD and SDIO

lore

Share & tools

lore

Gustavo A. R. Silva

author

2018-10-05 10:09 UTC #0 lore raw

PATCH 1/1 mmc: meson-mx-sdio: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Notice that in this particular case, I replaced the "fall-through:" comment with a proper "fall through", which is what GCC is expecting to find.

Addresses-Coverity-ID: 1373880 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/mmc/host/meson-mx-sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mmc/host/meson-mx-sdio.c +1 -1

index 2cfec33..abe253c 100644
@@ -294,7 +294,7 @@ static void meson_mx_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
 	switch (ios->power_mode) {
 	case MMC_POWER_OFF:
 		vdd = 0;
-		/* fall-through: */
+		/* fall through */
 	case MMC_POWER_UP:
 		if (!IS_ERR(mmc->supply.vmmc)) {
 			host->error = mmc_regulator_set_ocr(mmc,

Signature · 1 line

2.7.4

Ulf Hansson

2018-10-05 13:54 UTC #1 lore raw

Quoted 9 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case, I replaced the "fall-through:" comment with a proper "fall through", which is what GCC is expecting to find.
Addresses-Coverity-ID: 1373880 ("Missing break in switch")
Signed-off-by Gustavo A. R. Silva <[email protected]>

Applied for next, thanks!

Kind regards
Uffe

Quoted 20 lines

---
 drivers/mmc/host/meson-mx-sdio.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

drivers/mmc/host/meson-mx-sdio.c +1 -2

index 2cfec33..abe253c 100644
@@ -294,7 +294,7 @@ static void meson_mx_mmc_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
        switch (ios->power_mode) {
        case MMC_POWER_OFF:
                vdd = 0;
-               /* fall-through: */
+               /* fall through */
        case MMC_POWER_UP:
                if (!IS_ERR(mmc->supply.vmmc)) {
                        host->error = mmc_regulator_set_ocr(mmc,
--

2.7.4

Martin Blumenstingl

reviewer Acked-by on v1 1/1

2018-10-05 21:10 UTC #2 lore raw

In reply to Gustavo A. R. Silva

Quoted 10 lines · Gustavo A. R. Silva

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case, I replaced the "fall-through:" comment with a proper "fall through", which is what GCC is expecting to find.
Addresses-Coverity-ID: 1373880 ("Missing break in switch")
Signed-off-by Gustavo A. R. Silva <[email protected]>

Acked-by Martin Blumenstingl <[email protected]>

thank you for taking care of this!

Regards
Martin

Gustavo A. R. Silva

author

2018-10-05 21:20 UTC #3 lore raw

Hi Martin,

Quoted 10 lines · Martin Blumenstingl

Quoted 8 lines · Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.
Notice that in this particular case, I replaced the "fall-through:" comment with a proper "fall through", which is what GCC is expecting to find.

Quoted 6 lines

Quoted 2 lines
Addresses-Coverity-ID: 1373880 ("Missing break in switch")
Signed-off-by Gustavo A. R. Silva <[email protected]>
Acked-by Martin Blumenstingl <[email protected]>
thank you for taking care of this!

Glad to help. :)

Thanks
--
Gustavo