Skip to contentSkip to conversation

travis: add OpenSSL 1.1 Windows build

PATCH In review Steffan Karger 3 participants 4 messages Oct 5, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 travis: add OpenSSL 1.1 Windows build

So we catch both compilation errors against OpenSSL 1.0 and 1.1 on Windows.

---
 .travis.yml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
.travis.yml +4 -1
index 216f0a04..ede2aaa6 100644
@@ -53,7 +53,10 @@ matrix:
       os: osx
       osx_image: xcode7.3
       compiler: clang
-    - env: SSLLIB="openssl" CHOST=x86_64-w64-mingw32
+    - env: SSLLIB="openssl" CHOST=x86_64-w64-mingw32 OPENSSL_VERSION="1.0.1u"
+      os: linux
+      compiler: ": Win64 build only"
+    - env: SSLLIB="openssl" CHOST=x86_64-w64-mingw32 OPENSSL_VERSION="1.1.0h"
       os: linux
       compiler: ": Win64 build only"
     - env: SSLLIB="openssl" CHOST=i686-w64-mingw32
Signature · 1 line
2.17.1
Acked-by on v1 1/1
#1 lore raw

Thanks. As we figured out, we miss testing openssl 1.0 <-> 1.1 for the windows builds - no we do, and the test results nicely show the "1.0 only" breakage before Arne's fix that just went in.

Your patch has been applied to the master and release/2.4 branch.

commit a29b60c9577a7ea1302cd761645234a174a7e3cb (master) commit b8d8e492604b5691c66178605b6c5362f98f6c9d (release/2.4)

Author: Steffan Karger
Date:   Fri Oct 5 14:39:38 2018 +0200
     travis: add OpenSSL 1.1 Windows build

     Signed-off-by: Steffan Karger <[email protected]...>
     Acked-by: Gert Doering <[email protected]...>
     Message-Id: <[email protected]...>
     URL: https://www.mail-archive.com/search?l=mid&[email protected]...
     Signed-off-by: Gert Doering <[email protected]...>

--
kind regards,

Gert Doering

#2 lore raw
In reply to Steffan Karger

openssl versions were aligned to those used in "openvpn-build" repo, i.e. the same version were used as in installer creation.
not sure why do we want to have big matrix for cross builds.

but I do not mind, the more tests the better :)

пт, 5 окт. 2018 г. в 17:40, Steffan Karger <[email protected]...>:

Quoted 35 lines

So we catch both compilation errors against OpenSSL 1.0 and 1.1 on Windows.

---
 .travis.yml | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)
.travis.yml +1 -1
index 216f0a04..ede2aaa6 100644
@@ -53,7 +53,10 @@ matrix:
       os: osx
       osx_image: xcode7.3
       compiler: clang
-    - env: SSLLIB="openssl" CHOST=x86_64-w64-mingw32
+    - env: SSLLIB="openssl" CHOST=x86_64-w64-mingw32

OPENSSL_VERSION="1.0.1u"

.travis.yml +3 -0
+      os: linux
+      compiler: ": Win64 build only"
+    - env: SSLLIB="openssl" CHOST=x86_64-w64-mingw32

OPENSSL_VERSION="1.1.0h"
os: linux
compiler: ": Win64 build only"
- env: SSLLIB="openssl" CHOST=i686-w64-mingw32
--
2.17.1

_______________________________________________
Openvpn-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/openvpn-devel

#3 lore raw

Hi,

Quoted 5 lines · ???????? ??????????????

openssl versions were aligned to those used in "openvpn-build" repo, i.e. the same version were used as in installer creation.
not sure why do we want to have big matrix for cross builds.

but I do not mind, the more tests the better :)

With the cryptoapi code, we have code paths now that are "only windows" and "care needs to be taken for openssl 1.0 <-> 1.1" (RSA_meth_set_sign()).

That's the new thing...

gert

Signature · 6 lines
"If was one thing all people took for granted, was conviction that if you 
 feed honest figures into a computer, honest figures come out. Never doubted 
 it myself till I met a computer with a sense of humor."
                             Robert A. Heinlein, The Moon is a Harsh Mistress

Gert Doering - Munich, Germany                             [email protected]...