memstick: tifm_ms: mark expected switch fall-through

PATCH New Gustavo A. R. Silva 1 participant 1 message Oct 5, 2018

Subsystems (2)

Sony memorystick TI flash media memorystick/MMC drivers

lore

Share & tools

lore

Gustavo A. R. Silva

author

2018-10-05 12:54 UTC #0 lore raw

PATCH 1/1 memstick: tifm_ms: mark expected switch fall-through

In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through.

Addresses-Coverity-ID: 1357317 ("Missing break in switch")
Addresses-Coverity-ID: 1460342 ("Missing break in switch")

Signed-off-by Gustavo A. R. Silva <[email protected]>

---
 drivers/memstick/host/tifm_ms.c | 2 ++
 1 file changed, 2 insertions(+)

drivers/memstick/host/tifm_ms.c +2 -0

index bed2058..1bbb2ea 100644
@@ -166,9 +166,11 @@ static unsigned int tifm_ms_write_data(struct tifm_ms *host,
 	case 3:
 		host->io_word |= buf[off + 2] << 16;
 		host->io_pos++;
+		/* fall through */
 	case 2:
 		host->io_word |= buf[off + 1] << 8;
 		host->io_pos++;
+		/* fall through */
 	case 1:
 		host->io_word |= buf[off];
 		host->io_pos++;

Signature · 1 line

2.7.4