ixgbevf: add support for software timestamps
Subsystems (2)
PATCH 1/2 ixgbevf: add support for software timestamps
Add a call to skb_tx_timestamp in the ixgbevf_tx_map function. This enables software timestamping for packets sent over this device driver. The call is placed just prior to when we notify hardware of the new packet, in order to software timestamp as close as possible to when the hardware will transmit.
--- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 ++ 1 file changed, 2 insertions(+)
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c +2 -0
@@ -4016,6 +4016,8 @@ static void ixgbevf_tx_map(struct ixgbevf_ring *tx_ring,/* set the timestamp */ first->time_stamp = jiffies; +skb_tx_timestamp (skb); +/* Force memory writes to complete before letting h/w know there * are new descriptors to fetch. (Only applicable for weak-ordered * memory model archs, such as IA-64).
Signature · 1 line
2.18.0.219.gaf81d287a9da
PATCH 2/2 intel-ethernet: software timestamp skbs as late as possible
Many of the Intel Ethernet drivers call skb_tx_timestamp() earlier than necessary. Move the calls to this function to the latest point possible, just prior to notifying hardware of the new Tx packet when we bump the tail register.
This affects i40e, iavf, igb, igc, and ixgbe.
The e100, e1000, e1000e, fm10k, and ice drivers already call the skb_tx_timestamp() function just prior to indicating the Tx packet to hardware, so they do not need to be changed.
--- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 4 ++-- drivers/net/ethernet/intel/iavf/iavf_txrx.c | 4 ++-- drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- drivers/net/ethernet/intel/igc/igc_main.c | 4 ++-- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-)
drivers/net/ethernet/intel/i40e/i40e_txrx.c +2 -2
@@ -3474,6 +3474,8 @@ static inline int i40e_tx_map(struct i40e_ring *tx_ring, struct sk_buff *skb, tx_desc->cmd_type_offset_bsz =build_ctob (td_cmd, td_offset, size, td_tag); +skb_tx_timestamp (skb); +/* Force memory writes to complete before letting h/w know there * are new descriptors to fetch. *
@@ -3653,8 +3655,6 @@ static netdev_tx_t i40e_xmit_frame_ring(struct sk_buff *skb,if (tsyn) tx_flags |=I40E_TX_FLAGS_TSYN ; -skb_tx_timestamp (skb); -/* always enable CRC insertion offload */ td_cmd |=I40E_TX_DESC_CMD_ICRC ;
drivers/net/ethernet/intel/iavf/iavf_txrx.c +2 -2
@@ -2344,6 +2344,8 @@ static inline void iavf_tx_map(struct iavf_ring *tx_ring, struct sk_buff *skb, tx_desc->cmd_type_offset_bsz =build_ctob (td_cmd, td_offset, size, td_tag); +skb_tx_timestamp (skb); +/* Force memory writes to complete before letting h/w know there * are new descriptors to fetch. *
@@ -2462,8 +2464,6 @@ static netdev_tx_t iavf_xmit_frame_ring(struct sk_buff *skb,if (tso <0 ) goto out_drop; -skb_tx_timestamp (skb); -/* always enable CRC insertion offload */ td_cmd |=IAVF_TX_DESC_CMD_ICRC ;
drivers/net/ethernet/intel/igb/igb_main.c +2 -2
@@ -6019,6 +6019,8 @@ static int igb_tx_map(struct igb_ring *tx_ring,/* set the timestamp */ first->time_stamp = jiffies; +skb_tx_timestamp (skb); +/* Force memory writes to complete before letting h/w know there * are new descriptors to fetch. (Only applicable for weak-ordered * memory model archs, such as IA-64).
@@ -6147,8 +6149,6 @@ netdev_tx_t igb_xmit_frame_ring(struct sk_buff *skb,else if (!tso)igb_tx_csum (tx_ring, first); -skb_tx_timestamp (skb); -if (igb_tx_map (tx_ring, first, hdr_len)) goto cleanup_tx_tstamp;
drivers/net/ethernet/intel/igc/igc_main.c +2 -2
@@ -895,6 +895,8 @@ static int igc_tx_map(struct igc_ring *tx_ring,/* set the timestamp */ first->time_stamp = jiffies; +skb_tx_timestamp (skb); +/* Force memory writes to complete before letting h/w know there * are new descriptors to fetch. (Only applicable for weak-ordered * memory model archs, such as IA-64).
@@ -989,8 +991,6 @@ static netdev_tx_t igc_xmit_frame_ring(struct sk_buff *skb, first->bytecount = skb->len; first->gso_segs =1 ; -skb_tx_timestamp (skb); -/* record initial flags and protocol */ first->tx_flags = tx_flags; first->protocol = protocol;
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c +2 -2
@@ -8268,6 +8268,8 @@ static int ixgbe_tx_map(struct ixgbe_ring *tx_ring,/* set the timestamp */ first->time_stamp = jiffies; +skb_tx_timestamp (skb); +/* * Force memory writes to complete before letting h/w know there * are new descriptors to fetch. (Only applicable for weak-ordered
@@ -8645,8 +8647,6 @@ netdev_tx_t ixgbe_xmit_frame_ring(struct sk_buff *skb, } } -skb_tx_timestamp (skb); -#ifdef CONFIG_PCI_IOV /* * Use the l2switch_enable flag - would be false if the DMA
Signature · 1 line
2.18.0.219.gaf81d287a9da
Bowers
PATCH 2/2 intel-ethernet: software timestamp skbs as late as possible
Quoted 19 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Jacob Keller
Sent: Friday, October 5, 2018 9:34 AM
To: Intel Wired LAN <[email protected]>
Subject: [Intel-wired-lan] [net-next 2/2] intel-ethernet: software timestamp skbs as late as possibleMany of the Intel Ethernet drivers call
skb_tx_timestamp()earlier than necessary. Move the calls to this function to the latest point possible, just prior to notifying hardware of the new Tx packet when we bump the tail register.This affects i40e, iavf, igb, igc, and ixgbe.
The e100, e1000, e1000e, fm10k, and ice drivers already call the
skb_tx_timestamp()function just prior to indicating the Tx packet to hardware, so they do not need to be changed.
Quoted 8 lines
Signed-off-by Jacob Keller <[email protected]>--- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 4 ++-- drivers/net/ethernet/intel/iavf/iavf_txrx.c | 4 ++-- drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- drivers/net/ethernet/intel/igc/igc_main.c | 4 ++-- drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++-- 5 files changed, 10 insertions(+), 10 deletions(-)
Bowers
PATCH 1/2 ixgbevf: add support for software timestamps
In reply to Jacob KellerQuoted 14 lines
-----Original Message-----
From: Intel-wired-lan [mailto:intel-wired-lan-bounces at osuosl.org] On Behalf Of Jacob Keller
Sent: Friday, October 5, 2018 9:34 AM
To: Intel Wired LAN <[email protected]>
Subject: [Intel-wired-lan] [net-next 1/2] ixgbevf: add support for software timestampsAdd a call to
skb_tx_timestampin theixgbevf_tx_mapfunction. This enables software timestamping for packets sent over this device driver. The call is placed just prior to when we notify hardware of the new packet, in order to software timestamp as close as possible to when the hardware will transmit.
Quoted 4 lines
Signed-off-by Jacob Keller <[email protected]>--- drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 ++ 1 file changed, 2 insertions(+)