staging: media: davinci_vpfe: Use __func__ instead of function name
Subsystems (2)
PATCH v3 1/1 staging: media: davinci_vpfe: Use __func__ instead of function name
Access current function name using __func__.
Use %s and __func__ instead of function name.
Predefined identifier __func__ gives the name of current function name.
Issue found with checkpatch.pl
---
change in v3:
-change in commit message.
change in v2:
-Put useful information above ---
drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/staging/media/davinci_vpfe/dm365_ipipe.c +3 -3
@@ -695,21 +695,21 @@ static int ipipe_get_gamma_params(struct vpfe_ipipe_device *ipipe, void *param)if (!gamma->bypass_r) {dev_err (dev, -"ipipe_get_gamma_params: table ptr empty for R\n" ); +"%s: table ptr empty for R\n" , __func__);return -EINVAL ; }memcpy (gamma_param->table_r, gamma->table_r, (table_size *sizeof (struct vpfe_ipipe_gamma_entry )));if (!gamma->bypass_g) { -dev_err (dev,"ipipe_get_gamma_params: table ptr empty for G\n" ); +dev_err (dev,"%s: table ptr empty for G\n" , __func__);return -EINVAL ; }memcpy (gamma_param->table_g, gamma->table_g, (table_size *sizeof (struct vpfe_ipipe_gamma_entry )));if (!gamma->bypass_b) { -dev_err (dev,"ipipe_get_gamma_params: table ptr empty for B\n" ); +dev_err (dev,"%s: table ptr empty for B\n" , __func__);return -EINVAL ; } memcpy(gamma_param->table_b, gamma->table_b,
Signature · 1 line
1.9.1
Quoted 3 lines · Mamta Shukla
Access current function name using
__func__.
Use %s and__func__instead of function name.
Predefined identifier__func__gives the name of current function name.
The third sentence pretty much says the same thing as the first one. An important reason for using __func__ is that it is more robust. Actually there have been a number of print calls in the kernel where the function name was spelled incorrectly.
julia
Quoted 54 lines
Issue found with checkpatch.pl
Signed-off-by Mamta Shukla <[email protected]>---
change in v3:(quoted diff) +0
-1-change in commit message. change in v2: -Put useful information above --- drivers/staging/media/davinci_vpfe/dm365_ipipe.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/staging/media/davinci_vpfe/dm365_ipipe.c +3
-4@@ -695,21 +695,21 @@ static int ipipe_get_gamma_params(struct vpfe_ipipe_device *ipipe, void *param)if (!gamma->bypass_r) {dev_err (dev, -"ipipe_get_gamma_params: table ptr empty for R\n" ); +"%s: table ptr empty for R\n" , __func__);return -EINVAL ; }memcpy (gamma_param->table_r, gamma->table_r, (table_size *sizeof (struct vpfe_ipipe_gamma_entry )));if (!gamma->bypass_g) { -dev_err (dev,"ipipe_get_gamma_params: table ptr empty for G\n" ); +dev_err (dev,"%s: table ptr empty for G\n" , __func__);return -EINVAL ; }memcpy (gamma_param->table_g, gamma->table_g, (table_size *sizeof (struct vpfe_ipipe_gamma_entry )));if (!gamma->bypass_b) { -dev_err (dev,"ipipe_get_gamma_params: table ptr empty for B\n" ); +dev_err (dev,"%s: table ptr empty for B\n" , __func__);return -EINVAL ; } memcpy(gamma_param->table_b, gamma->table_b, --1.9.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181006220157.GA13993%40armorer.
For more options, visit https://groups.google.com/d/optout.