Skip to contentSkip to conversation

ffmpeg: use bfd linker always for x86 target

PATCH New Khem Raj 1 participant 2 messages Oct 7, 2018

lore
Share & tools
lore

Khem Raj

author
#0 lore raw

PATCH 1/2 ffmpeg: use bfd linker always for x86 target

gold crashes when linking, so use bfd linker here, another option is to use --disable-asm but then we loose performance.

Signed-off-by Khem Raj <[email protected]>
---
 meta/recipes-multimedia/ffmpeg/ffmpeg_4.0.2.bb | 4 ++++
 1 file changed, 4 insertions(+)
meta/recipes-multimedia/ffmpeg/ffmpeg_4.0.2.bb +4 -0
index 58f58fc5c8..7d1af04047 100644
@@ -117,6 +117,10 @@ EXTRA_OECONF = " \
 "
 
 EXTRA_OECONF_append_linux-gnux32 = " --disable-asm"
+# gold crashes on x86, another solution is to --disable-asm but thats more hacky
+# ld.gold: internal error in relocate_section, at ../../gold/i386.cc:3684
+
+LDFLAGS_append_x86 = "${@bb.utils.contains('DISTRO_FEATURES', 'ld-is-gold', ' -fuse-ld=bfd ', '', d)}"
 
 do_configure() {
     ${S}/configure ${EXTRA_OECONF}
Signature · 1 line
2.19.0
author
#1 lore raw

PATCH 2/2 x264: Disable asm on musl/x86

Fixes

WARNING: x264-r2854+gitAUTOINC+e9a5903edf-r0 do_package_qa: QA Issue: ELF binary '/mnt/a/yoe/build/tmp/work/i586-yoe-linux-musl/x264/r2854+gitAUTOINC+e9a5903edf-r0/packages-split/x264/usr/lib/libx264.so.152' has relocations in .text [textrel]
WARNING: x264-r2854+gitAUTOINC+e9a5903edf-r0 do_package_qa: QA Issue: ELF binary '/mnt/a/yoe/build/tmp/work/i586-yoe-linux-musl/x264/r2854+gitAUTOINC+e9a5903edf-r0/packages-split/x264-bin/usr/bin/x264' has relocations in .text [textrel]

Signed-off-by Khem Raj <[email protected]>
---
 meta/recipes-multimedia/x264/x264_git.bb | 1 +
 1 file changed, 1 insertion(+)
meta/recipes-multimedia/x264/x264_git.bb +1 -0
index c445d15e69..4174cb2819 100644
@@ -23,6 +23,7 @@ S = "${WORKDIR}/git"
 inherit lib_package pkgconfig perlnative
 
 X264_DISABLE_ASM = ""
+X264_DISABLE_ASM_x86_libc-musl = "--disable-asm"
 X264_DISABLE_ASM_armv4 = "--disable-asm"
 X264_DISABLE_ASM_armv5 = "--disable-asm"
 X264_DISABLE_ASM_powerpc = "${@bb.utils.contains("TUNE_FEATURES", "spe", "--disable-asm", "", d)}"
Signature · 1 line
2.19.0