Skip to contentSkip to conversation

generic: test project id recovery after power failure

PATCH New Chao Yu 1 participant 3 messages Oct 7, 2018

lore
Share & tools
lore

Chao Yu

author
#0 lore raw

PATCH v2 1/3 generic: test project id recovery after power failure

From: Chao Yu <[email protected]>

After fsync, filesystem should guarantee inode metadata including project id being persisted, so even after sudden power-cut, during mount, we should recover project_id fields correctly, in order to not loss those meta info.

So adding this testcase to check whether generic filesystem can guarantee that.

---
v2:
- export and use $LSATTR_PROG in common/rc
- use $CHATTR_PROG instead of chattr
- fix wrong comments
- add -f parameter for rm

 common/config         |  1 +
 tests/generic/506     | 97 +++++++++++++++++++++++++++++++++++++++++++
 tests/generic/506.out |  2 +
 tests/generic/group   |  1 +
 4 files changed, 101 insertions(+)
 create mode 100755 tests/generic/506
 create mode 100644 tests/generic/506.out
common/config +1 -0
index 1ba8d96c..a87cb4a2 100644
@@ -170,6 +170,7 @@ export WIPEFS_PROG="$(type -P wipefs)"
 export DUMP_PROG="$(type -P dump)"
 export RESTORE_PROG="$(type -P restore)"
 export LVM_PROG="$(type -P lvm)"
+export LSATTR_PROG="$(type -P lsattr)"
 export CHATTR_PROG="$(type -P chattr)"
 export DEBUGFS_PROG="$(type -P debugfs)"
 export UUIDGEN_PROG="$(type -P uuidgen)"
tests/generic/506 new file +97 -0

97 lines not on this page · raw message

tests/generic/506.out new file +2 -0
new file mode 100644
index 00000000..cb46b201
@@ -0,0 +1,2 @@
+QA output created by 506
+Silence is golden
tests/generic/group +1 -0
index 4da0e188..c7d42ff9 100644
@@ -508,3 +508,4 @@
 503 auto quick dax punch collapse zero
 504 auto quick locks
 505 shutdown auto quick metadata
+506 shutdown auto quick metadata quota
Signature · 1 line
2.18.0
author
#1 lore raw

PATCH v2 2/3 generic: test i_flags recovery after power failure

From: Chao Yu <[email protected]>

After fsync, filesystem should guarantee inode metadata including i_flags being persisted, so even after sudden power-cut, during mount, we should recover i_flags fields correctly, in order to not loss those meta info.

So adding this testcase to check whether generic filesystem can guarantee that.

We only check below attribute modification which most filesystem supports:
- no atime updates (A)
- secure deletion (s)
- synchronous updates (S)
- undeletable (u)

---
v2:
- add missing _require_chattr
- use $CHATTR_PROG/$LSATTR_PROG
- add -f parameter for rm
- cleanup codes of traversing each parameter for chattr

 tests/generic/507     | 134 ++++++++++++++++++++++++++++++++++++++++++
 tests/generic/507.out |   2 +
 tests/generic/group   |   1 +
 3 files changed, 137 insertions(+)
 create mode 100755 tests/generic/507
 create mode 100644 tests/generic/507.out
tests/generic/507 new file +134 -0
new file mode 100755
index 00000000..7af8c5ef
@@ -0,0 +1,134 @@
+#! /bin/bash
+# SPDX-License-Identifier: GPL-2.0
+# Copyright (c) 2018 Huawei.  All Rights Reserved.
+#
+# FS QA Test 507
+#
+# This testcase is trying to test recovery flow of generic filesystem, w/ below
+# steps, once i_flags changes, after we fsync that file, we can expect that
+# i_flags can be recovered after sudden power-cuts.
+# 1. touch testfile;
+# 1.1 sync (optional)
+# 2. chattr +[AsSu] testfile
+# 3. xfs_io -f testfile -c "fsync";
+# 4. godown;
+# 5. umount;
+# 6. mount;
+# 7. check i_flags
+# 8. chattr -[AsSu] testfile
+# 9. xfs_io -f testfile -c "fsync";
+# 10. godown;
+# 11. umount;
+# 12. mount;
+# 13. check i_flags
+#
+seq=`basename $0`
+seqres=$RESULT_DIR/$seq
+echo "QA output created by $seq"
+
+here=`pwd`
+tmp=/tmp/$$
+status=1	# failure is the default!
+trap "_cleanup; exit \$status" 0 1 2 3 15
+
+_cleanup()
+{
+	cd /
+	rm -f $tmp.*
+}
+
+# get standard environment, filters and checks
+. ./common/rc
+. ./common/filter
+
+# remove previous $seqres.full before test
+rm -f $seqres.full
+
+# real QA test starts here
+_supported_fs generic
+_supported_os Linux
+
+_require_command "$LSATTR_PROG" lasttr
+_require_command "$CHATTR_PROG" chattr
+_require_chattr AsSu
+
+_require_scratch
+_require_scratch_shutdown
+
+_scratch_mkfs >/dev/null 2>&1
+_require_metadata_journaling $SCRATCH_DEV
+
+testfile=$SCRATCH_MNT/testfile
+opt="AsSu"
+
+do_check()
+{
+	attr=$1
+
+	_scratch_mount
+
+	touch $testfile
+
+	if [ "$2" == "sync" ]; then
+		echo "sync" >> $seqres.full
+		sync
+	fi
+
+	echo "Test chattr +$1" >> $seqres.full
+
+	# add attribute
+	$CHATTR_PROG +$attr $testfile
+
+	before=`$LSATTR_PROG $testfile`
+
+	$XFS_IO_PROG -f $testfile -c "fsync" | _filter_xfs_io
+
+	_scratch_shutdown | tee -a $seqres.full
+	_scratch_cycle_mount
+
+	after=`$LSATTR_PROG $testfile`
+
+	# check inode's i_flags
+	if [ "$before" != "$after" ]; then
+		echo "Before: $before"
+		echo "After : $after"
+	fi
+	echo "Before: $before" >> $seqres.full
+	echo "After : $after" >> $seqres.full
+
+	echo "Test chattr -$1" >> $seqres.full
+
+	# delete attribute
+	$CHATTR_PROG -$attr $testfile
+
+	before=`$LSATTR_PROG $testfile`
+
+	$XFS_IO_PROG -f $testfile -c "fsync" | _filter_xfs_io
+
+	_scratch_shutdown | tee -a $seqres.full
+	_scratch_cycle_mount
+
+	after=`$LSATTR_PROG $testfile`
+
+	# check inode's i_flags
+	if [ "$before" != "$after" ]; then
+		echo "Before: $before"
+		echo "After : $after"
+	fi
+	echo "Before: $before" >> $seqres.full
+	echo "After : $after" >> $seqres.full
+
+	rm -f $testfile
+	_scratch_unmount
+}
+
+echo "Silence is golden"
+
+opts="A s S u"
+for i in $opts; do
+	do_check $i
+	do_check $i sync
+done
+
+status=0
+exit
tests/generic/507.out new file +2 -0
new file mode 100644
index 00000000..3d8672f8
@@ -0,0 +1,2 @@
+QA output created by 507
+Silence is golden
tests/generic/group +1 -0
index c7d42ff9..e94253dc 100644
@@ -509,3 +509,4 @@
 504 auto quick locks
 505 shutdown auto quick metadata
 506 shutdown auto quick metadata quota
+507 shutdown auto quick metadata
Signature · 1 line
2.18.0
author
#2 lore raw

PATCH v2 3/3 generic: test creation time recovery after power failure

In reply to Chao Yu

From: Chao Yu <[email protected]>

After fsync, filesystem should guarantee inode metadata including creation time being persisted, so even after sudden power-cut, during mount, we should recover i_crtime_{,nsec} fields correctly, in order to not loss those meta info.

So adding this testcase to check whether generic filesystem can guarantee that.

Note that, it needs inode creation time support on specified filesystem.

---
v2:
- remove unneeded './common/quota"
- add missing _require_statx
- add a helper _require_btime to check inode creation time support.
- fix wrong comments
- use -f parameter for rm

 common/rc             | 11 +++++
 tests/generic/508     | 96 +++++++++++++++++++++++++++++++++++++++++++
 tests/generic/508.out |  2 +
 tests/generic/group   |  1 +
 4 files changed, 110 insertions(+)
 create mode 100755 tests/generic/508
 create mode 100644 tests/generic/508.out
common/rc +11 -0
index c8cccb38..6ab5b066 100644
@@ -3835,6 +3835,17 @@ _dmsetup_create()
 	$UDEV_SETTLE_PROG >/dev/null 2>&1
 }
 
+_require_btime()
+{
+	local mnt_point=${!#}
+	_get_mount $*
+	$XFS_IO_PROG -f $mnt_point/test_creation_time -c "statx -v" \
+		| grep btime >>$seqres.full 2>&1 || \
+		_notrun "inode creation time not supported by this filesystem"
+	rm -f $mnt_point/test_creation_time
+	_put_mount
+}
+
 init_rc
 
 ################################################################################
tests/generic/508 new file +96 -0

96 lines not on this page · raw message

tests/generic/508.out new file +2 -0
new file mode 100644
index 00000000..a5ceec05
@@ -0,0 +1,2 @@
+QA output created by 508
+Silence is golden
tests/generic/group +1 -0
index e94253dc..8f26ee6a 100644
@@ -510,3 +510,4 @@
 505 shutdown auto quick metadata
 506 shutdown auto quick metadata quota
 507 shutdown auto quick metadata
+508 shutdown auto quick metadata
Signature · 1 line
2.18.0