hwmon: (ina3221) Validate shunt resistor value from DT
PATCH v2 1/1 hwmon: (ina3221) Validate shunt resistor value from DT
The input->shunt_resistor is int type while the value from DT is unsigned int. Meanwhile, a divide-by-zero error would happen if the value is 0. So this patch just simply validates the value.
Signed-off-by Nicolin Chen <[email protected]>
---
Changelogv1->v2:
* Validate the value and error out
drivers/hwmon/ina3221.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)
drivers/hwmon/ina3221.c +7 -1
@@ -536,8 +536,14 @@ static int ina3221_probe_child_from_dt(struct device *dev,of_property_read_string (child,"label" , &input->label);/* Overwrite default shunt resistor value optionally */ -if (!of_property_read_u32 (child,"shunt-resistor-micro-ohms" , &val)) +if (!of_property_read_u32 (child,"shunt-resistor-micro-ohms" , &val)) { +if (val <1 || val >INT_MAX ) { +dev_err (dev,"invalid shunt resistor value %u of %s\n" , + val, child->name); +return -EINVAL ; + } input->shunt_resistor = val; + }return 0 ; }
Signature · 1 line
2.17.1
Quoted 5 lines · Nicolin Chen
The
input->shunt_resistoris int type while the value from DT is unsigned int. Meanwhile, a divide-by-zero error would happen if the value is 0. So this patch just simply validates the value.Signed-off-by Nicolin Chen <[email protected]>
Applied.
Thanks,
Guenter
Quoted 28 lines
---
Changelogv1->v2:
* Validate the value and error outdrivers/hwmon/ina3221.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-)drivers/hwmon/ina3221.c +7
-1@@ -536,8 +536,14 @@ static int ina3221_probe_child_from_dt(struct device *dev,of_property_read_string (child,"label" , &input->label);/* Overwrite default shunt resistor value optionally */ -if (!of_property_read_u32 (child,"shunt-resistor-micro-ohms" , &val)) +if (!of_property_read_u32 (child,"shunt-resistor-micro-ohms" , &val)) { +if (val <1 || val >INT_MAX ) { +dev_err (dev,"invalid shunt resistor value %u of %s\n" , + val, child->name); +return -EINVAL ; + } input->shunt_resistor = val; + }return 0 ; }