drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
Subsystems (2)
PATCH 1/1 drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
VESA eDP 1.4 specification has separate fields defined in EDP_DPCD_REV for eDP 1.4a and 1.4b eDP revisions. This patch defines those. Found this when one of my eDP panels advertises eDP 1.4a (04h) in the EDP_DPCD_REV DPCD field.
--- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+)
include/drm/drm_dp_helper.h +2 -0
@@ -685,6 +685,8 @@# define DP_EDP_12 0x01# define DP_EDP_13 0x02# define DP_EDP_14 0x03 +# define DP_EDP_14a 0x04/* eDP 1.4a */ +# define DP_EDP_14b 0x05/* eDP 1.4b */ #define DP_EDP_GENERAL_CAP_1 0x701# define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0)
Signature · 6 lines
2.18.0 _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.BAT: success for drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
== Series Details ==
== Series Details ==
Series: drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
URL : https://patchwork.freedesktop.org/series/50720/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4951 -> Patchwork_10395 =
== Summary - SUCCESS ==
No regressions found.
External URL: https://patchwork.freedesktop.org/api/1.0/series/50720/revisions/1/mbox/
== Known issues ==
Here are the changes found in Patchwork_10395 that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_exec_suspend@basic-s3:
fi-blb-e6850: PASS -> INCOMPLETE (fdo#107718)
igt@kms_frontbuffer_tracking@basic:
fi-byt-clapper: PASS -> FAIL (fdo#103167)
==== Possible fixes ====
igt@drv_selftest@live_hangcheck:
fi-cfl-8109u: INCOMPLETE (fdo#106070) -> PASS
fi-kbl-7567u: DMESG-FAIL (fdo#107860) -> PASS
igt@gem_exec_suspend@basic-s3:
fi-cfl-8109u: DMESG-WARN (fdo#107345) -> PASS +3 fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#106070 https://bugs.freedesktop.org/show_bug.cgi?id=106070
fdo#107345 https://bugs.freedesktop.org/show_bug.cgi?id=107345
fdo#107718 https://bugs.freedesktop.org/show_bug.cgi?id=107718
fdo#107860 https://bugs.freedesktop.org/show_bug.cgi?id=107860
== Participating hosts (47 -> 44) ==
Additional (2): fi-skl-guc fi-pnv-d510
Missing (5): fi-kbl-soraka fi-ctg-p8600 fi-byt-squawks fi-bsw-cyan fi-ilk-m540
== Build changes ==
* Linux: CI_DRM_4951 -> Patchwork_10395
CI_DRM_4951: 07b09b512d6ef0f5b0673ae611507c8a61ce6c7b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4671: b121f7d42c260ae3a050c3f440d1c11f7cff7d1a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10395: 5ee17799fe627790d7061f4d2b16c72d7f4c051d @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
5ee17799fe62 drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10395/issues.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Patchwork
CI✓ Fi.CI.IGT: success for drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
In reply to Manasi Navare== Series Details ==
== Series Details ==
Series: drm/dp: Add definitions for eDP Rev 1.4a and 1.4b
URL : https://patchwork.freedesktop.org/series/50720/
State : success
== Summary ==
= CI Bug Log - changes from CI_DRM_4951_full -> Patchwork_10395_full =
== Summary - SUCCESS ==
No regressions found.
== Known issues ==
Here are the changes found in Patchwork_10395_full that come from known issues:
=== IGT changes ===
==== Issues hit ====
igt@gem_cpu_reloc@full:
shard-skl: NOTRUN -> INCOMPLETE (fdo#108073)
igt@gem_exec_schedule@pi-ringfull-bsd:
shard-skl: NOTRUN -> FAIL (fdo#103158)
igt@gem_userptr_blits@readonly-unsync:
shard-skl: NOTRUN -> INCOMPLETE (fdo#108074)
igt@kms_busy@extended-modeset-hang-newfb-with-reset-render-b:
shard-skl: NOTRUN -> DMESG-WARN (fdo#107956) +3
igt@kms_busy@extended-pageflip-hang-newfb-render-b:
shard-glk: PASS -> DMESG-WARN (fdo#107956)
igt@kms_chv_cursor_fail@pipe-b-128x128-top-edge:
shard-apl: PASS -> DMESG-WARN (fdo#105602, fdo#103558) +1
igt@kms_cursor_crc@cursor-128x128-sliding:
shard-apl: PASS -> FAIL (fdo#103232) +1
igt@kms_cursor_crc@cursor-128x42-onscreen:
shard-skl: NOTRUN -> FAIL (fdo#103232) +1
igt@kms_cursor_legacy@2x-cursor-vs-flip-legacy:
shard-glk: NOTRUN -> INCOMPLETE (fdo#103359, k.org#198133)
igt@kms_flip@flip-vs-fences-interruptible:
shard-snb: NOTRUN -> INCOMPLETE (fdo#105411)
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-mmap-gtt:
shard-apl: PASS -> FAIL (fdo#103167) +2
{igt@kms_plane_alpha_blend@pipe-a-coverage-7efc}:
shard-skl: PASS -> FAIL (fdo#108145)
{igt@kms_plane_alpha_blend@pipe-c-alpha-transparant-fb}:
shard-skl: NOTRUN -> FAIL (fdo#108145) +3
igt@kms_plane_multiple@atomic-pipe-a-tiling-y:
shard-apl: PASS -> FAIL (fdo#103166) +1
igt@kms_setmode@basic:
shard-hsw: PASS -> FAIL (fdo#99912)
igt@pm_backlight@fade_with_suspend:
shard-skl: NOTRUN -> FAIL (fdo#107847)
==== Possible fixes ====
igt@gem_exec_await@wide-contexts:
shard-apl: FAIL (fdo#106680) -> PASS
igt@kms_busy@extended-pageflip-modeset-hang-oldfb-render-a:
shard-kbl: DMESG-WARN (fdo#107956) -> PASS
igt@kms_ccs@pipe-a-crc-primary-rotation-180:
shard-skl: FAIL (fdo#107725) -> PASS
igt@kms_color@pipe-a-legacy-gamma:
shard-apl: FAIL (fdo#104782, fdo#108145) -> PASS +1
igt@kms_cursor_crc@cursor-64x64-random:
shard-apl: FAIL (fdo#103232) -> PASS
igt@kms_cursor_legacy@cursora-vs-flipa-toggle:
shard-glk: DMESG-WARN (fdo#106538, fdo#105763) -> PASS
igt@kms_flip@2x-flip-vs-rmfb-interruptible:
shard-glk: INCOMPLETE (fdo#103359, k.org#198133) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-offscren-pri-shrfb-draw-mmap-gtt:
shard-glk: DMESG-FAIL (fdo#106538, fdo#103167) -> PASS
igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-blt:
shard-apl: FAIL (fdo#103167) -> PASS +1
igt@kms_frontbuffer_tracking@fbc-1p-rte:
shard-apl: FAIL (fdo#103167, fdo#105682) -> PASS
{igt@kms_plane_alpha_blend@pipe-a-coverage-7efc}:
shard-glk: DMESG-FAIL (fdo#106538) -> PASS
igt@kms_setmode@basic:
shard-kbl: FAIL (fdo#99912) -> PASS
igt@pm_rpm@pc8-residency:
shard-skl: INCOMPLETE (fdo#107807) -> SKIP {name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
fdo#103158 https://bugs.freedesktop.org/show_bug.cgi?id=103158
fdo#103166 https://bugs.freedesktop.org/show_bug.cgi?id=103166
fdo#103167 https://bugs.freedesktop.org/show_bug.cgi?id=103167
fdo#103232 https://bugs.freedesktop.org/show_bug.cgi?id=103232
fdo#103359 https://bugs.freedesktop.org/show_bug.cgi?id=103359
fdo#103558 https://bugs.freedesktop.org/show_bug.cgi?id=103558
fdo#104782 https://bugs.freedesktop.org/show_bug.cgi?id=104782
fdo#105411 https://bugs.freedesktop.org/show_bug.cgi?id=105411
fdo#105602 https://bugs.freedesktop.org/show_bug.cgi?id=105602
fdo#105682 https://bugs.freedesktop.org/show_bug.cgi?id=105682
fdo#105763 https://bugs.freedesktop.org/show_bug.cgi?id=105763
fdo#106538 https://bugs.freedesktop.org/show_bug.cgi?id=106538
fdo#106680 https://bugs.freedesktop.org/show_bug.cgi?id=106680
fdo#107725 https://bugs.freedesktop.org/show_bug.cgi?id=107725
fdo#107807 https://bugs.freedesktop.org/show_bug.cgi?id=107807
fdo#107847 https://bugs.freedesktop.org/show_bug.cgi?id=107847
fdo#107956 https://bugs.freedesktop.org/show_bug.cgi?id=107956
fdo#108073 https://bugs.freedesktop.org/show_bug.cgi?id=108073
fdo#108074 https://bugs.freedesktop.org/show_bug.cgi?id=108074
fdo#108145 https://bugs.freedesktop.org/show_bug.cgi?id=108145
fdo#99912 https://bugs.freedesktop.org/show_bug.cgi?id=99912
k.org#198133 https://bugzilla.kernel.org/show_bug.cgi?id=198133
== Participating hosts (6 -> 6) ==
No changes in participating hosts
== Build changes ==
* Linux: CI_DRM_4951 -> Patchwork_10395
CI_DRM_4951: 07b09b512d6ef0f5b0673ae611507c8a61ce6c7b @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_4671: b121f7d42c260ae3a050c3f440d1c11f7cff7d1a @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_10395: 5ee17799fe627790d7061f4d2b16c72d7f4c051d @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_10395/shards.html
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 17 lines · Manasi Navare
VESA eDP 1.4 specification has separate fields defined in
EDP_DPCD_REVfor eDP 1.4a and 1.4b eDP revisions. This patch defines those. Found this when one of my eDP panels advertises eDP 1.4a (04h) in theEDP_DPCD_REVDPCD field.Cc Jani Nikula <[email protected]>Cc Ville Syrjala <[email protected]>Signed-off-by Manasi Navare <[email protected]>--- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+)include/drm/drm_dp_helper.h +0
-0
include/drm/drm_dp_helper.h line 689
Quoted 5 lines
include/drm/drm_dp_helper.h +2
-0@@ -685,6 +685,8 @@# define DP_EDP_12 0x01# define DP_EDP_13 0x02# define DP_EDP_14 0x03 +# define DP_EDP_14a 0x04/* eDP 1.4a */ +# define DP_EDP_14b 0x05/* eDP 1.4b */
The comments seem a bit redundant.
Either way
Quoted 5 lines
include/drm/drm_dp_helper.h +0
-0#define DP_EDP_GENERAL_CAP_1 0x701# define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0)Signature · 1 line
2.18.0
Signature · 6 lines
Ville Syrjälä Intel _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 26 lines · Ville Syrjälä
Quoted 17 lines · Manasi Navare
VESA eDP 1.4 specification has separate fields defined in
EDP_DPCD_REVfor eDP 1.4a and 1.4b eDP revisions. This patch defines those. Found this when one of my eDP panels advertises eDP 1.4a (04h) in theEDP_DPCD_REVDPCD field.Cc Jani Nikula <[email protected]>Cc Ville Syrjala <[email protected]>Signed-off-by Manasi Navare <[email protected]>--- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+)include/drm/drm_dp_helper.h +0
-0include/drm/drm_dp_helper.h line 689
Quoted 5 lines
include/drm/drm_dp_helper.h +2
-0@@ -685,6 +685,8 @@# define DP_EDP_12 0x01# define DP_EDP_13 0x02# define DP_EDP_14 0x03 +# define DP_EDP_14a 0x04/* eDP 1.4a */ +# define DP_EDP_14b 0x05/* eDP 1.4b */ The comments seem a bit redundant.
Quoted 2 lines
Either way
Reviewed-by Ville Syrjälä <[email protected]>
So I guess we'll need code changing our == checks to >= checks.
BR,
Jani.
Quoted 6 lines
Quoted 6 lines
include/drm/drm_dp_helper.h +0
-0#define DP_EDP_GENERAL_CAP_1 0x701# define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0)Signature · 1 line
2.18.0
Signature · 5 lines
Jani Nikula, Intel Open Source Graphics Center _______________________________________________ Intel-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 27 lines · Jani Nikula
Quoted 26 lines · Ville Syrjälä
Quoted 17 lines · Manasi Navare
VESA eDP 1.4 specification has separate fields defined in
EDP_DPCD_REVfor eDP 1.4a and 1.4b eDP revisions. This patch defines those. Found this when one of my eDP panels advertises eDP 1.4a (04h) in theEDP_DPCD_REVDPCD field.Cc Jani Nikula <[email protected]>Cc Ville Syrjala <[email protected]>Signed-off-by Manasi Navare <[email protected]>--- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+)include/drm/drm_dp_helper.h +0
-0include/drm/drm_dp_helper.h line 689
Quoted 5 lines
include/drm/drm_dp_helper.h +2
-0@@ -685,6 +685,8 @@# define DP_EDP_12 0x01# define DP_EDP_13 0x02# define DP_EDP_14 0x03 +# define DP_EDP_14a 0x04/* eDP 1.4a */ +# define DP_EDP_14b 0x05/* eDP 1.4b */ The comments seem a bit redundant.
Quoted 5 lines
Quoted 2 lines
Either way
Reviewed-by Ville Syrjälä <[email protected]>So I guess we'll need code changing our == checks to >= checks.
We already have >= check in edp_init_dpcd and then in compute_config, we check for < DP_EDP_14 to set to max link rate /lane count. So checks wise we shuld be good for now.
Manasi
Quoted 5 lines
BR,
Jani.Quoted 2 lines
Quoted 2 lines
Quoted 7 lines
Quoted 4 lines
Quoted 4 lines
#define
DP_EDP_GENERAL_CAP_10x701# define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0)Signature · 1 line
2.18.0Signature · 1 line
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Quoted 13 lines · Ville Syrjälä
Quoted 12 lines · Manasi Navare
VESA eDP 1.4 specification has separate fields defined in
EDP_DPCD_REVfor eDP 1.4a and 1.4b eDP revisions. This patch defines those. Found this when one of my eDP panels advertises eDP 1.4a (04h) in theEDP_DPCD_REVDPCD field.Cc Jani Nikula <[email protected]>Cc Ville Syrjala <[email protected]>Signed-off-by Manasi Navare <[email protected]>--- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+)
Quoted 13 lines
include/drm/drm_dp_helper.h line 689
Quoted 10 lines
include/drm/drm_dp_helper.h +2
-0@@ -685,6 +685,8 @@# define DP_EDP_12 0x01# define DP_EDP_13 0x02# define DP_EDP_14 0x03 +# define DP_EDP_14a 0x04/* eDP 1.4a */ +# define DP_EDP_14b 0x05/* eDP 1.4b */ The comments seem a bit redundant.
Thanks for the review.
I added the comments since for all other defs there is comment of eDP 1.2 at the top of defs.
If you feel strongly about it I can remove the comments before merging. What do you think?
Manasi
Quoted 12 lines
Either way
Reviewed-by Ville Syrjälä <[email protected]>Quoted 5 lines
include/drm/drm_dp_helper.h +0
-0#define DP_EDP_GENERAL_CAP_1 0x701# define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0)Signature · 1 line
2.18.0Signature · 2 lines
Ville Syrjälä Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Thanks for the review.
Pushed to drm-misc
Manasi
Quoted 26 lines · Ville Syrjälä
Quoted 17 lines · Manasi Navare
VESA eDP 1.4 specification has separate fields defined in
EDP_DPCD_REVfor eDP 1.4a and 1.4b eDP revisions. This patch defines those. Found this when one of my eDP panels advertises eDP 1.4a (04h) in theEDP_DPCD_REVDPCD field.Cc Jani Nikula <[email protected]>Cc Ville Syrjala <[email protected]>Signed-off-by Manasi Navare <[email protected]>--- include/drm/drm_dp_helper.h | 2 ++ 1 file changed, 2 insertions(+)include/drm/drm_dp_helper.h +0
-0include/drm/drm_dp_helper.h line 689
Quoted 5 lines
include/drm/drm_dp_helper.h +2
-0@@ -685,6 +685,8 @@# define DP_EDP_12 0x01# define DP_EDP_13 0x02# define DP_EDP_14 0x03 +# define DP_EDP_14a 0x04/* eDP 1.4a */ +# define DP_EDP_14b 0x05/* eDP 1.4b */ The comments seem a bit redundant.
Quoted 12 lines
Either way
Reviewed-by Ville Syrjälä <[email protected]>Quoted 5 lines
include/drm/drm_dp_helper.h +0
-0#define DP_EDP_GENERAL_CAP_1 0x701# define DP_EDP_TCON_BACKLIGHT_ADJUSTMENT_CAP (1 << 0)Signature · 1 line
2.18.0Signature · 2 lines
Ville Syrjälä Intel
_______________________________________________
Intel-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/intel-gfx