Skip to contentSkip to conversation

xen/xsm: remove unnecessary #define

PATCH Superseded Xin Li 3 participants 6 messages Oct 9, 2018

v1 of 5 Superseded Latest is v5 →

lore
Share & tools
lore

Xin Li

author
#0 lore raw

PATCH 1/3 xen/xsm: remove unnecessary #define

this #define is unnecessary since XSM_INLINE is redefined in xsm/dummy.h, it's a risk of build breakage, so remove it.

Signed-off-by Xin Li <[email protected]>

---
CC: Daniel De Graaf <[email protected]>
CC: George Dunlap <[email protected]>
CC: Jan Beulich <[email protected]>
CC: Konrad Rzeszutek Wilk <[email protected]>
CC: Stefano Stabellini <[email protected]>
CC: Tim Deegan <[email protected]>
CC: Wei Liu <[email protected]>
CC: Sergey Dyasli <[email protected]>
CC: Andrew Cooper <[email protected]>
CC: Ming Lu <[email protected]>

v5:
1. move the removal of #define to this new patch.
2. fix wrong git author

---
 xen/xsm/dummy.c | 1 -
 1 file changed, 1 deletion(-)
xen/xsm/dummy.c +0 -1
index 3290d04527..06a674fad0 100644
@@ -11,7 +11,6 @@
  */
 
 #define XSM_NO_WRAPPERS
-#define XSM_INLINE /* */
 #include <xsm/dummy.h>
 
 struct xsm_operations dummy_xsm_ops;
Signature · 7 lines
2.18.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
#1 lore raw
Quoted 4 lines
Quoted 1 line
Quoted 1 line · On 09.10.18 at 02:28, <[email protected]> wrote:

v5:
1. move the removal of #define to this new patch.
2. fix wrong git author

Thanks, but one more formal request: Would you please include the version of a patch/series in side the square brackets of the mail subject, like everyone else does? This allows to easily identify what belongs where without having to open each mail.

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw
Quoted 9 lines
Quoted 4 lines
Quoted 1 line
Quoted 1 line · On 09.10.18 at 02:28, <[email protected]> wrote:

v5:
1. move the removal of #define to this new patch.
2. fix wrong git author

Thanks, but one more formal request: Would you please include the version of a patch/series in side the square brackets of the mail subject, like everyone else does? This allows to easily identify what belongs where without having to open each mail.

OK. I will follow this style to resend path set v5.

Re: [Xen-devel] [PATCH v3 1/2] x86: fix comment on super page alignment requirement

Quoted 3 lines

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw
In reply to Xin Li
Quoted 18 lines
Quoted 1 line
Quoted 1 line · On 09.10.18 at 02:28, <[email protected]> wrote:

this #define is unnecessary since XSM_INLINE is redefined in xsm/dummy.h, it's a risk of build breakage, so remove it.

Signed-off-by Xin Li <[email protected]>

---
CC: Daniel De Graaf <[email protected]>
CC: George Dunlap <[email protected]>
CC: Jan Beulich <[email protected]>
CC: Konrad Rzeszutek Wilk <[email protected]>
CC: Stefano Stabellini <[email protected]>
CC: Tim Deegan <[email protected]>
CC: Wei Liu <[email protected]>
CC: Sergey Dyasli <[email protected]>
CC: Andrew Cooper <[email protected]>
CC: Ming Lu <[email protected]>

Quoted 3 lines

v5:
1. move the removal of #define to this new patch.
2. fix wrong git author

Oh, and please, when you send new versions, add previously provided (of course unless they've been invalidated meanwhile) tags, to aid both committers and future readers/reviewers.

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#4 lore raw
Quoted 12 lines
Quoted 12 lines

---
CC: Daniel De Graaf <[email protected]>
CC: George Dunlap <[email protected]>
CC: Jan Beulich <[email protected]>
CC: Konrad Rzeszutek Wilk <[email protected]>
CC: Stefano Stabellini <[email protected]>
CC: Tim Deegan <[email protected]>
CC: Wei Liu <[email protected]>
CC: Sergey Dyasli <[email protected]>
CC: Andrew Cooper <[email protected]>
CC: Ming Lu <[email protected]>

Quoted 8 lines
Quoted 3 lines

v5:
1. move the removal of #define to this new patch.
2. fix wrong git author

Oh, and please, when you send new versions, add previously provided (of course unless they've been invalidated meanwhile) tags, to aid both committers and future readers/reviewers.

Do you mean all the changes from v1 to v5, like:

v1:
xxx

v2:
xxx
..

v5

Quoted 2 lines

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#5 lore raw
Quoted 24 lines
Quoted 13 lines
Quoted 13 lines · On 09.10.18 at 09:50, <[email protected]> wrote:

---
CC: Daniel De Graaf <[email protected]>
CC: George Dunlap <[email protected]>
CC: Jan Beulich <[email protected]>
CC: Konrad Rzeszutek Wilk <[email protected]>
CC: Stefano Stabellini <[email protected]>
CC: Tim Deegan <[email protected]>
CC: Wei Liu <[email protected]>
CC: Sergey Dyasli <[email protected]>
CC: Andrew Cooper <[email protected]>
CC: Ming Lu <[email protected]>

Quoted 6 lines
Quoted 3 lines

v5:
1. move the removal of #define to this new patch.
2. fix wrong git author

Oh, and please, when you send new versions, add previously provided (of course unless they've been invalidated meanwhile) tags, to aid both

committers

Quoted 2 lines

and future readers/reviewers.

Do you mean all the changes from v1 to v5, like:

Quoted 8 lines

v1:
xxx

v2:
xxx
..

v5

No, this is occasionally helpful, but not what I mean. I gave my R-b on v4, so you should have recorded it in v5.

Jan

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel