Skip to contentSkip to conversation

glib-2.0: add missing locale dependencies to PN-ptest

PATCH In review Ross Burton 3 participants 4 messages Oct 9, 2018 – Nov 8, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 glib-2.0: add missing locale dependencies to PN-ptest

The test suite skips several tests if the required locales are not found, so add them as dependencies of glib-2.0-ptest.

---
 meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++
 1 file changed, 13 insertions(+)
meta/recipes-core/glib-2.0/glib.inc +13 -0
index ad4f2aebd71..f78aa9bfe6d 100644
@@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\
             glibc-gconv-iso8859-15 \
             glibc-charmap-invariant \
             glibc-localedata-translit-cjk-variants \
+            locale-base-tr-tr \
+            locale-base-lt-lt \
+            locale-base-ja-jp.euc-jp \
+            locale-base-fa-ir \
+            locale-base-ru-ru \
+            locale-base-de-de \
+            locale-base-pl-pl \
+            locale-base-hr-hr \
+            locale-base-el-gr \
+            locale-base-fr-fr \
+            locale-base-fr-fr \
+            locale-base-es-es \
+            locale-base-en-gb \
            "
 
 INSANE_SKIP_${PN}-ptest += "libdir"
Signature · 1 line
2.11.0
#1 lore raw
Quoted 23 lines · Ross Burton

The test suite skips several tests if the required locales are not found, so add them as dependencies of glib-2.0-ptest.

---
  meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++
  1 file changed, 13 insertions(+)
meta/recipes-core/glib-2.0/glib.inc +6 -0
index ad4f2aebd71..f78aa9bfe6d 100644
@@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\
              glibc-gconv-iso8859-15 \
              glibc-charmap-invariant \
              glibc-localedata-translit-cjk-variants \
+            locale-base-tr-tr \
+            locale-base-lt-lt \
+            locale-base-ja-jp.euc-jp \
+            locale-base-fa-ir \
+            locale-base-ru-ru \
+            locale-base-de-de \

meta/recipes-core/glib-2.0/glib.inc RDEPENDS_${PN}-ptest_append_libc-glibc = "\ · line 170

Quoted 10 lines
meta/recipes-core/glib-2.0/glib.inc +7 -0
+            locale-base-pl-pl \
+            locale-base-hr-hr \
+            locale-base-el-gr \
+            locale-base-fr-fr \
+            locale-base-fr-fr \
+            locale-base-es-es \
+            locale-base-en-gb \
             "
 
  INSANE_SKIP_${PN}-ptest += "libdir"

Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in DISTRO_FEATURES, it would seem after this commit I'm seeing following warnings during bitbake:

WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps]

If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer appear.

-Niko

#2 lore raw

Sounds about right. Not sure what would count as a solution here?

Ross

Quoted 53 lines · Mauno Niko
Quoted 23 lines · Ross Burton

The test suite skips several tests if the required locales are not found, so add them as dependencies of glib-2.0-ptest.

---
  meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++
  1 file changed, 13 insertions(+)
meta/recipes-core/glib-2.0/glib.inc +6 -0
index ad4f2aebd71..f78aa9bfe6d 100644
@@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\
              glibc-gconv-iso8859-15 \
              glibc-charmap-invariant \
              glibc-localedata-translit-cjk-variants \
+            locale-base-tr-tr \
+            locale-base-lt-lt \
+            locale-base-ja-jp.euc-jp \
+            locale-base-fa-ir \
+            locale-base-ru-ru \
+            locale-base-de-de \

meta/recipes-core/glib-2.0/glib.inc RDEPENDS_${PN}-ptest_append_libc-glibc = "\ · line 170

Quoted 10 lines
meta/recipes-core/glib-2.0/glib.inc +7 -0
+            locale-base-pl-pl \
+            locale-base-hr-hr \
+            locale-base-el-gr \
+            locale-base-fr-fr \
+            locale-base-fr-fr \
+            locale-base-es-es \
+            locale-base-en-gb \
             "
 
  INSANE_SKIP_${PN}-ptest += "libdir"

Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in DISTRO_FEATURES, it would seem after this commit I'm seeing following warnings during bitbake:

WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps]
WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps]

If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer appear.

-Niko

#3 lore raw

It was also discussed here:
http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156591.html

and resulted in few fixes for _remove operator and:
http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156695.html
http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156696.html

Quoted 80 lines · Ross

Sounds about right. Not sure what would count as a solution here?

Ross

Quoted 3 lines · Mauno Niko
Quoted 1 line · Ross Burton

The test suite skips several tests if the required locales are not

found, so add

Quoted 8 lines

Review

Quoted 8 lines

them as dependencies of glib-2.0-ptest.

---
  meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++
  1 file changed, 13 insertions(+)
(quoted diff) +0 -0

b/meta/recipes-core/glib-2.0/glib.inc

Quoted 22 lines
Quoted 22 lines

index ad4f2aebd71..f78aa9bfe6d 100644

meta/recipes-core/glib-2.0/glib.inc +13 -0
@@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\
              glibc-gconv-iso8859-15 \
              glibc-charmap-invariant \
              glibc-localedata-translit-cjk-variants \
+            locale-base-tr-tr \
+            locale-base-lt-lt \
+            locale-base-ja-jp.euc-jp \
+            locale-base-fa-ir \
+            locale-base-ru-ru \
+            locale-base-de-de \
+            locale-base-pl-pl \
+            locale-base-hr-hr \
+            locale-base-el-gr \
+            locale-base-fr-fr \
+            locale-base-fr-fr \
+            locale-base-es-es \
+            locale-base-en-gb \
             "
 
Quoted 4 lines

meta/recipes-core/glib-2.0/glib.inc RDEPENDS_${PN}-ptest_append_libc-glibc = "\ · line 170

Quoted 2 lines
meta/recipes-core/glib-2.0/glib.inc +0 -0
  INSANE_SKIP_${PN}-ptest += "libdir"

Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in

DISTRO_FEATURES, it would seem after this commit I'm seeing following warnings during bitbake:

Quoted 2 lines

WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps]

Quoted 1 line

WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps]

Quoted 1 line

WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps]

Quoted 1 line

WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps]

Quoted 1 line

WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps]

Quoted 1 line

WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps]

Quoted 1 line

WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps]

Quoted 1 line

WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency? [build-deps]

Quoted 1 line

WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps]

Quoted 1 line

WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps]

Quoted 1 line

WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest

rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps]

Quoted 2 lines

If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer

appear.

Quoted 2 lines

-Niko

--
_______________________________________________
Openembedded-core mailing list
[email protected]
http://lists.openembedded.org/mailman/listinfo/openembedded-core