Skip to contentSkip to conversation

smb2: fix uninitialized variable bug in smb2_ioctl_query_info

PATCH Superseded Gustavo A. R. Silva 1 participant 2 messages Oct 9, 2018

Subsystems (2)

v1 of 3 Superseded Latest is v3 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 smb2: fix uninitialized variable bug in smb2_ioctl_query_info

There is a potential execution path in which variable *resp_buftype* is passed as an argument to function free_rsp_buf(), in which is used without being properly initialized previously.

Fix this by initializing variable *resp_buftype* to -1 in order to avoid unpredictable or unintended results.

Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable")

Fixes 1473971 ("Uninitialized scalar variable")
---
 fs/cifs/smb2ops.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
fs/cifs/smb2ops.c +1 -1
index c6c6450d..927aadd 100644
@@ -1133,7 +1133,7 @@ smb2_ioctl_query_info(const unsigned int xid,
 	struct smb_rqst rqst;
 	struct kvec iov[1];
 	struct kvec rsp_iov;
-	int resp_buftype;
+	int resp_buftype = -1;
 	struct smb2_query_info_rsp *rsp = NULL;
 	void *buffer;
 
Signature · 1 line
2.7.4
#1 lore raw
Quoted 9 lines · Gustavo A. R. Silva

There is a potential execution path in which variable *resp_buftype* is passed as an argument to function free_rsp_buf(), in which is used without being properly initialized previously.

Fix this by initializing variable *resp_buftype* to -1 in order to avoid unpredictable or unintended results.

Addresses-Coverity-ID: 1472116 ("Uninitialized scalar variable")

Fixes 1473971 ("Uninitialized scalar variable")

ugh... sorry, the line above is wrong... I'll send v2 shotly.

Thanks
--
Gustavo