staging: vboxvideo: make a couple of funcs static
PATCH 1/1 staging: vboxvideo: make a couple of funcs static
Fix Sparse warnings:drivers/staging/vboxvideo/vbox_mode.c:309:6: warning:
symbol 'vbox_primary_atomic_disable' was not declared. Should it be static?
drivers/staging/vboxvideo/vbox_mode.c:452:6: warning:
symbol 'vbox_cursor_atomic_disable' was not declared. Should it be static?
Signed-off-by Craig Kewley <[email protected]>
--- drivers/staging/vboxvideo/vbox_mode.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/vboxvideo/vbox_mode.c +4 -4
@@ -306,8 +306,8 @@ static void vbox_primary_atomic_update(struct drm_plane *plane, plane->state->src_y >> 16); } -void vbox_primary_atomic_disable (struct drm_plane *plane, -struct drm_plane_state *old_state) +static void vbox_primary_atomic_disable (struct drm_plane *plane, +struct drm_plane_state *old_state) {struct drm_crtc *crtc = old_state->crtc;
@@ -449,8 +449,8 @@ static void vbox_cursor_atomic_update(struct drm_plane *plane,mutex_unlock (&vbox->hw_mutex); } -void vbox_cursor_atomic_disable (struct drm_plane *plane, -struct drm_plane_state *old_state) +static void vbox_cursor_atomic_disable (struct drm_plane *plane, +struct drm_plane_state *old_state) {struct vbox_private *vbox = container_of(plane->dev, struct vbox_private, ddev);
Signature · 1 line
2.17.1
Hi,
Quoted 8 lines · Craig Kewley
Fix Sparse warnings:
drivers/staging/vboxvideo/vbox_mode.c:309:6: warning:
symbol 'vbox_primary_atomic_disable' was not declared. Should it be static?
drivers/staging/vboxvideo/vbox_mode.c:452:6: warning:
symbol 'vbox_cursor_atomic_disable' was not declared. Should it be static?Signed-off-by Craig Kewley <[email protected]>
Thanks.
Reviewed-by Hans de Goede <[email protected]>
Regards,
Hans
Quoted 31 lines
--- drivers/staging/vboxvideo/vbox_mode.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/vboxvideo/vbox_mode.c +4
-4@@ -306,8 +306,8 @@ static void vbox_primary_atomic_update(struct drm_plane *plane, plane->state->src_y >> 16); } -void vbox_primary_atomic_disable (struct drm_plane *plane, -struct drm_plane_state *old_state) +static void vbox_primary_atomic_disable (struct drm_plane *plane, +struct drm_plane_state *old_state) {struct drm_crtc *crtc = old_state->crtc;@@ -449,8 +449,8 @@ static void vbox_cursor_atomic_update(struct drm_plane *plane,mutex_unlock (&vbox->hw_mutex); } -void vbox_cursor_atomic_disable (struct drm_plane *plane, -struct drm_plane_state *old_state) +static void vbox_cursor_atomic_disable (struct drm_plane *plane, +struct drm_plane_state *old_state) {struct vbox_private *vbox = container_of(plane->dev, struct vbox_private, ddev);