Updated comment accuracy in PSP SOS/Sysdriver loading sequence to target bootloader instead of bootrom
Subsystems (2)
PATCH 1/1 Updated comment accuracy in PSP SOS/Sysdriver loading sequence to target bootloader instead of bootrom
From: John Clements <[email protected]>
--- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)
drivers/gpu/drm/amd/amdgpu/psp_v11_0.c +2 -2
@@ -167,7 +167,7 @@ static int psp_v11_0_bootloader_load_sysdrv(struct psp_context *psp)/* Copy PSP System Driver binary to memory */ memcpy (psp->fw_pri_buf, psp->sys_start_addr, psp->sys_bin_size); -/* Provide the sys driver to bootrom */ +/* Provide the sys driver to bootloader */ WREG32_SOC15 (MP0 ,0 , mmMP0_SMN_C2PMSG_36, (uint32_t )(psp->fw_pri_mc_addr >>20 )); psp_gfxdrv_command_reg =1 <<16 ;
@@ -208,7 +208,7 @@ static int psp_v11_0_bootloader_load_sos(struct psp_context *psp)/* Copy Secure OS binary to PSP memory */ memcpy (psp->fw_pri_buf, psp->sos_start_addr, psp->sos_bin_size); -/* Provide the PSP secure OS to bootrom */ +/* Provide the PSP secure OS to bootloader */ WREG32_SOC15 (MP0 ,0 , mmMP0_SMN_C2PMSG_36, (uint32_t )(psp->fw_pri_mc_addr >>20 )); psp_gfxdrv_command_reg =2 <<16 ;
drivers/gpu/drm/amd/amdgpu/psp_v3_1.c +2 -2
@@ -194,7 +194,7 @@ static int psp_v3_1_bootloader_load_sysdrv(struct psp_context *psp)/* Copy PSP System Driver binary to memory */ memcpy (psp->fw_pri_buf, psp->sys_start_addr, psp->sys_bin_size); -/* Provide the sys driver to bootrom */ +/* Provide the sys driver to bootloader */ WREG32_SOC15 (MP0 ,0 , mmMP0_SMN_C2PMSG_36, (uint32_t )(psp->fw_pri_mc_addr >>20 )); psp_gfxdrv_command_reg =1 <<16 ;
@@ -254,7 +254,7 @@ static int psp_v3_1_bootloader_load_sos(struct psp_context *psp)/* Copy Secure OS binary to PSP memory */ memcpy (psp->fw_pri_buf, psp->sos_start_addr, psp->sos_bin_size); -/* Provide the PSP secure OS to bootrom */ +/* Provide the PSP secure OS to bootloader */ WREG32_SOC15 (MP0 ,0 , mmMP0_SMN_C2PMSG_36, (uint32_t )(psp->fw_pri_mc_addr >>20 )); psp_gfxdrv_command_reg =2 <<16 ;
Signature · 6 lines
2.17.1 _______________________________________________ amd-gfx mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/amd-gfx
A message that is not in the archive (sent off-list or not yet received): 20181016012316.10874-1-clements.jm-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Quoted 11 lines
-----Original Message-----
From: amd-gfx [mailto:[email protected]] On Behalf Of John Clements
Sent: Tuesday, October 16, 2018 9:23 AM
To: [email protected]
Cc: John Clements <[email protected]>
Subject: [PATCH 1/1] Updated comment accuracy in PSP SOS/Sysdriver loading sequence to target bootloader instead of bootromFrom: John Clements <[email protected]>
The commit message should not be empty, please add a line of words even like "refine the comments for PSP".
With that fixed, patch is Reviewed-by: Huang Rui <[email protected]>
Quoted 59 lines
Signed-off-by John Clements <[email protected]>--- drivers/gpu/drm/amd/amdgpu/psp_v11_0.c | 4 ++-- drivers/gpu/drm/amd/amdgpu/psp_v3_1.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-)drivers/gpu/drm/amd/amdgpu/psp_v11_0.c +1
-1@@ -167,7 +167,7 @@ static int psp_v11_0_bootloader_load_sysdrv(struct psp_context *psp)/* Copy PSP System Driver binary to memory */ memcpy(psp->fw_pri_buf, psp->sys_start_addr, psp->sys_bin_size); -/* Provide the sys driver to bootrom */ +/* Provide the sys driver to bootloader */ WREG32_SOC15 (MP0 ,0 , mmMP0_SMN_C2PMSG_36, (uint32_t )(psp->fw_pri_mc_addr >>20 ));drivers/gpu/drm/amd/amdgpu/psp_v11_0.c +1
-1psp_gfxdrv_command_reg =1 <<16 ;@@ -208,7 +208,7 @@ static int psp_v11_0_bootloader_load_sos(struct psp_context *psp)/* Copy Secure OS binary to PSP memory */ memcpy(psp->fw_pri_buf, psp->sos_start_addr, psp->sos_bin_size); -/* Provide the PSP secure OS to bootrom */ +/* Provide the PSP secure OS to bootloader */ WREG32_SOC15 (MP0 ,0 , mmMP0_SMN_C2PMSG_36, (uint32_t )(psp->fw_pri_mc_addr >>20 ));drivers/gpu/drm/amd/amdgpu/psp_v11_0.c +0
-0psp_gfxdrv_command_reg =2 <<16 ;drivers/gpu/drm/amd/amdgpu/psp_v3_1.c +1
-1@@ -194,7 +194,7 @@ static int psp_v3_1_bootloader_load_sysdrv(struct psp_context *psp)/* Copy PSP System Driver binary to memory */ memcpy(psp->fw_pri_buf, psp->sys_start_addr, psp->sys_bin_size); -/* Provide the sys driver to bootrom */ +/* Provide the sys driver to bootloader */ WREG32_SOC15 (MP0 ,0 , mmMP0_SMN_C2PMSG_36, (uint32_t )(psp->fw_pri_mc_addr >>20 ));drivers/gpu/drm/amd/amdgpu/psp_v3_1.c +1
-1psp_gfxdrv_command_reg =1 <<16 ;@@ -254,7 +254,7 @@ static int psp_v3_1_bootloader_load_sos(struct psp_context *psp)/* Copy Secure OS binary to PSP memory */ memcpy(psp->fw_pri_buf, psp->sos_start_addr, psp->sos_bin_size); -/* Provide the PSP secure OS to bootrom */ +/* Provide the PSP secure OS to bootloader */ WREG32_SOC15 (MP0 ,0 , mmMP0_SMN_C2PMSG_36, (uint32_t )(psp->fw_pri_mc_addr >>20 ));
psp_gfxdrv_command_reg= 2 << 16;
--
2.17.1
Quoted 4 lines
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/amd-gfx