drm/msm: dpu: Don't set legacy plane->crtc pointer
PATCH 1/1 drm/msm: dpu: Don't set legacy plane->crtc pointer
From: Sean Paul <[email protected]>
It causes a WARN in drm_atomic_get_plane_state(), and is not used by atomic (or dpu).
--- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 1 - 1 file changed, 1 deletion(-)
drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +0 -1
@@ -1517,7 +1517,6 @@ struct drm_crtc *dpu_crtc_init(struct drm_device *dev, struct drm_plane *plane, NULL);drm_crtc_helper_add (crtc, &dpu_crtc_helper_funcs); - plane->crtc = crtc;/* save user friendly CRTC name for later */ snprintf (dpu_crtc->name,DPU_CRTC_NAME_SIZE ,"crtc%u" , crtc->base.id);
Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ Freedreno mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/freedreno
Quoted 6 lines · Sean Paul
From: Sean Paul <[email protected]>
It causes a WARN in
drm_atomic_get_plane_state(), and is not used by atomic (or dpu).Signed-off-by Sean Paul <[email protected]>
I guess leftover from refactoring and upstreaming in parallel? -Daniel
Quoted 23 lines
--- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 1 - 1 file changed, 1 deletion(-)drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +0
-1@@ -1517,7 +1517,6 @@ struct drm_crtc *dpu_crtc_init(struct drm_device *dev, struct drm_plane *plane, NULL);drm_crtc_helper_add (crtc, &dpu_crtc_helper_funcs); - plane->crtc = crtc;/* save user friendly CRTC name for later */ snprintf (dpu_crtc->name,DPU_CRTC_NAME_SIZE ,"crtc%u" , crtc->base.id);Signature · 6 lines
Sean Paul, Software Engineer, Google / Chromium OS _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
Signature · 7 lines
Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch _______________________________________________ dri-devel mailing list [email protected] https://lists.freedesktop.org/mailman/listinfo/dri-devel
A message that is not in the archive (sent off-list or not yet received): 20181016164422.GC31561-dv86pmgwkMBes7Z6vYuT8azUEOm+Xw19@public.gmane.org
Quoted 4 lines · Daniel Vetter
Quoted 2 lines · Sean Paul
From: Sean Paul <[email protected]>
Quoted 8 lines
Quoted 4 lines
It causes a WARN in
drm_atomic_get_plane_state(), and is not used by atomic (or dpu).Signed-off-by Sean Paul <[email protected]>Reviewed-by Daniel Vetter <[email protected]>I guess leftover from refactoring and upstreaming in parallel?
Yep, we're still working out some kinks :( The bring-up and validation was using 4.14 kernel with as many drm core/msm backports as we could fit, but this
one slipped through. Fortunately we've got CrOS on 4.19 with all dpu patches upstream (or on list), so this won't be a reoccurring issue.
Sean
Quoted 21 lines
-Daniel
Quoted 19 lines
--- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 1 - 1 file changed, 1 deletion(-)drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c +0
-2@@ -1517,7 +1517,6 @@ struct drm_crtc *dpu_crtc_init(struct drm_device *dev, struct drm_plane *plane, NULL);drm_crtc_helper_add (crtc, &dpu_crtc_helper_funcs); - plane->crtc = crtc;/* save user friendly CRTC name for later */ snprintf (dpu_crtc->name,DPU_CRTC_NAME_SIZE ,"crtc%u" , crtc->base.id); --Sean Paul, Software Engineer, Google / Chromium OS
Quoted 9 lines
Quoted 4 lines
_______________________________________________
dri-devel mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/dri-devel--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
_______________________________________________
Freedreno mailing list
[email protected]
https://lists.freedesktop.org/mailman/listinfo/freedreno