Skip to contentSkip to conversation

target: remove some unused stats

RFC PATCH In review David Disseldorp 2 participants 4 messages Oct 17, 2018 – Nov 16, 2018 SCSI target

lore
Share & tools
lore
#0 lore raw

cover target: remove some unused stats

This patchset removes a couple of unused error stat counters and a redundant cumulative counter.
I've tagged this patchset RFC, as it may be considered a kernel<->user (configfs) API change.

Cheers, David

---
 drivers/target/iscsi/iscsi_target_stat.c | 40 ----------------------------------------
 include/target/iscsi/iscsi_target_stat.h |  4 ----
 2 files changed, 44 deletions(-)
#1 lore raw
Quoted 4 lines · David Disseldorp

This patchset removes a couple of unused error stat counters and a redundant cumulative counter.
I've tagged this patchset RFC, as it may be considered a kernel<->user (configfs) API change.

Ping, any thoughts on this patchset?

Cheers, David

#2 lore raw
In reply to David Disseldorp
Quoted 9 lines · David Disseldorp
Quoted 4 lines · David Disseldorp

This patchset removes a couple of unused error stat counters and a redundant cumulative counter.
I've tagged this patchset RFC, as it may be considered a kernel<->user (configfs) API change.

Ping, any thoughts on this patchset?

I think these stats were supposed to match the iSCSI MIB definitions. It was not clear why we didn't just fix them so they report the correct values?

#3 lore raw
In reply to David Disseldorp

Hi Mike

Quoted 10 lines · Mike Christie
Quoted 7 lines
Quoted 4 lines

This patchset removes a couple of unused error stat counters and a redundant cumulative counter.
I've tagged this patchset RFC, as it may be considered a kernel<->user (configfs) API change.

Ping, any thoughts on this patchset?

I think these stats were supposed to match the iSCSI MIB definitions. It was not clear why we didn't just fix them so they report the correct values?

I finally got a chance to look through rfc#4544. It does indeed look like these counters correspond to:
IscsiInstanceSsnErrorStatsEntry ::= SEQUENCE {

    iscsiInstSsnDigestErrors       Counter32,
    iscsiInstSsnCxnTimeoutErrors   Counter32,
    iscsiInstSsnFormatErrors       Counter32

}

There doesn't appear to be anything stopping us from plumbing them into the corresponding error paths, so I'll withdraw this patchset.

Cheers, David