Skip to contentSkip to conversation

staging: wlan-ng: Replace long int with long

PATCH Superseded Maya Nakamura 2 participants 2 messages Oct 18, 2018 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 staging: wlan-ng: Replace long int with long

Replace long int with long as int is unnecessary. Issue found by checkpatch.pl.

---
 drivers/staging/wlan-ng/p80211conv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wlan-ng/p80211conv.c +1 -1
index 91debcf20646..0ff5fda81b05 100644
@@ -430,7 +430,7 @@ int skb_p80211_to_ether(struct wlandevice *wlandev, u32 ethconv,
 			/* A bogus length ethfrm has been sent. */
 			/* Is someone trying an oflow attack? */
 			netdev_err(netdev, "DIXII frame too large (%ld > %d)\n",
-				   (long int)(payload_length -
+				   (long)(payload_length -
 				   sizeof(struct wlan_llc) -
 				   sizeof(struct wlan_snap)), netdev->mtu);
 			return 1;
Signature · 1 line
2.17.1
#1 lore raw
Quoted 3 lines · Maya Nakamura

Replace long int with long as int is unnecessary. Issue found by checkpatch.pl.

It'll be good to explain why do you think 'long int' is unnecessary here.

Quoted 27 lines
---
 drivers/staging/wlan-ng/p80211conv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/staging/wlan-ng/p80211conv.c +1 -2
index 91debcf20646..0ff5fda81b05 100644
@@ -430,7 +430,7 @@ int skb_p80211_to_ether(struct wlandevice *wlandev, u32 ethconv,
                        /* A bogus length ethfrm has been sent. */
                        /* Is someone trying an oflow attack? */
                        netdev_err(netdev, "DIXII frame too large (%ld > %d)\n",
-                                  (long int)(payload_length -
+                                  (long)(payload_length -
                                   sizeof(struct wlan_llc) -
                                   sizeof(struct wlan_snap)), netdev->mtu);
                        return 1;
--

2.17.1

--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181018043801.GA4248%40k-vBox.
For more options, visit https://groups.google.com/d/optout.