4.14/4.18: Please add "eeprom: at24: Add support for address-width property"
Subsystems (3)
Please cherry-pick the following commit to 4.14 and 4.18:
commit a2b3bf4846e5eed62ea6abb096af2c950961033c
Author: Alan Chiang <[email protected]>
Date: Wed Jul 25 11:20:22 2018 +0800
eeprom: at24: Add support for address-width property
Provide a flexible way to determine the addressing bits of eeprom. Pass the addressing bits to driver through address-width property.
Confirmed to work on 4.14 with the Identification Page of an ST M24M02-DR (256 bytes but 16 bit addressing).
Cannot be cherry-picked trivially on 4.9.
The corresponding documentation commit 21d04054501fb27b56e995b54ac74e39aee79a46 can be cherry-picked to 4.18, the backport for 4.14 is below.
Thanks
Adrian
Quoted 1 line
From
2562e333f39b8077ffb06bdf79430f10b74c11f5Mon Sep 17 00:00:00 2001
From: Alan Chiang <[email protected]>
Date: Wed, 25 Jul 2018 11:20:21 +0800
Subject: [PATCH] dt-bindings: at24: Add address-width property
Currently the only way to use a variant of a supported model with a different address width is to define a new compatible string and the corresponding chip data structure.
Provide a flexible way to specify the size of the address pointer by defining a new property: address-width.
--- Documentation/devicetree/bindings/eeprom/eeprom.txt | 2 ++ 1 file changed, 2 insertions(+)
Documentation/devicetree/bindings/eeprom/eeprom.txt +2 -0
@@ -36,6 +36,8 @@ Optional properties: - read-only: this parameterless property disables writes to the eeprom + - address-width: number of address bits (one of 8, 16). + Example: eeprom@52 {
Signature · 1 line
2.11.0
Sasha Levin
maintainerQuoted 11 lines · Adrian Bunk
Please cherry-pick the following commit to 4.14 and 4.18:
commit
a2b3bf4846e5eed62ea6abb096af2c950961033c
Author: Alan Chiang <[email protected]>
Date: Wed Jul 25 11:20:22 2018 +0800eeprom: at24: Add support for address-width property
Provide a flexible way to determine the addressing bits of eeprom. Pass the addressing bits to driver through address-width property.
Quoted 7 lines
Signed-off-by Alan Chiang <[email protected]>Signed-off-by Andy Yeh <[email protected]>Signed-off-by Bartosz Golaszewski <[email protected]>Confirmed to work on 4.14 with the Identification Page of an ST M24M02-DR (256 bytes but 16 bit addressing).
This patch doesn't look like stable material. The hardware never worked before, so this is not a regression and falls under new hardware enablement, but the patch is more complex than what we usually allow for hardware enablement (adding various IDs/quirks/etc).
Am I missing something?
Quoted 20 lines · Sasha Levin
Quoted 11 lines · Adrian Bunk
Please cherry-pick the following commit to 4.14 and 4.18:
commit
a2b3bf4846e5eed62ea6abb096af2c950961033c
Author: Alan Chiang <[email protected]>
Date: Wed Jul 25 11:20:22 2018 +0800eeprom: at24: Add support for address-width property
Provide a flexible way to determine the addressing bits of eeprom. Pass the addressing bits to driver through address-width property.
Quoted 7 lines
Signed-off-by Alan Chiang <[email protected]>Signed-off-by Andy Yeh <[email protected]>Signed-off-by Bartosz Golaszewski <[email protected]>Confirmed to work on 4.14 with the Identification Page of an ST M24M02-DR (256 bytes but 16 bit addressing).
Quoted 6 lines
This patch doesn't look like stable material. The hardware never worked before, so this is not a regression and falls under new hardware enablement, but the patch is more complex than what we usually allow for hardware enablement (adding various IDs/quirks/etc).
Am I missing something?
IMHO it is a pretty straightforward quirk for hardware enablement.
Note that the quirk will only be used if explicitely enabled in the device tree, for everyone else this code is a nop.
Quoted 2 lines
Thanks,
Sasha
cu
Adrian
Signature · 4 lines
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon SeedSasha Levin
maintainerQuoted 26 lines · Adrian Bunk
Quoted 25 lines · Sasha Levin
Quoted 11 lines · Adrian Bunk
Please cherry-pick the following commit to 4.14 and 4.18:
commit
a2b3bf4846e5eed62ea6abb096af2c950961033c
Author: Alan Chiang <[email protected]>
Date: Wed Jul 25 11:20:22 2018 +0800eeprom: at24: Add support for address-width property
Provide a flexible way to determine the addressing bits of eeprom. Pass the addressing bits to driver through address-width property.
Quoted 7 lines
Signed-off-by Alan Chiang <[email protected]>Signed-off-by Andy Yeh <[email protected]>Signed-off-by Bartosz Golaszewski <[email protected]>Confirmed to work on 4.14 with the Identification Page of an ST M24M02-DR (256 bytes but 16 bit addressing).
This patch doesn't look like stable material. The hardware never worked before, so this is not a regression and falls under new hardware enablement, but the patch is more complex than what we usually allow for hardware enablement (adding various IDs/quirks/etc).
Quoted 6 lines
Quoted 1 line
Am I missing something?
IMHO it is a pretty straightforward quirk for hardware enablement.
Note that the quirk will only be used if explicitely enabled in the device tree, for everyone else this code is a nop.
Fair enough. I've queued it for 4.18 and 4.14.
All,
The original author Alanx chiang has left the company. I assigned Ken to help handle the cherrypick task (4.14 and 4.18).
Regards, Andy
Quoted 79 lines
-----Original Message-----
From: Adrian Bunk [mailto:[email protected]]
Sent: Monday, October 22, 2018 4:39 PM
To: [email protected]
Cc: Alan Chiang <[email protected]>; Yeh, Andy <[email protected]>; Bartosz Golaszewski <[email protected]>; [email protected]
Subject: 4.14/4.18: Please add "eeprom: at24: Add support for address-width property"Please cherry-pick the following commit to 4.14 and 4.18:
commit
a2b3bf4846e5eed62ea6abb096af2c950961033c
Author: Alan Chiang <[email protected]>
Date: Wed Jul 25 11:20:22 2018 +0800eeprom: at24: Add support for address-width property
Provide a flexible way to determine the addressing bits of eeprom. Pass the addressing bits to driver through address-width property.
Signed-off-by Alan Chiang <[email protected]>Signed-off-by Andy Yeh <[email protected]>Signed-off-by Bartosz Golaszewski <[email protected]>Confirmed to work on 4.14 with the Identification Page of an ST M24M02-DR (256 bytes but 16 bit addressing).
Cannot be cherry-picked trivially on 4.9.
The corresponding documentation commit
21d04054501fb27b56e995b54ac74e39aee79a46
can be cherry-picked to 4.18, the backport for 4.14 is below.Thanks
AdrianFrom
2562e333f39b8077ffb06bdf79430f10b74c11f5Mon Sep 17 00:00:00 2001
From: Alan Chiang <[email protected]>
Date: Wed, 25 Jul 2018 11:20:21 +0800
Subject: [PATCH] dt-bindings: at24: Add address-width propertyCurrently the only way to use a variant of a supported model with a different address width is to define a new compatible string and the corresponding chip data structure.
Provide a flexible way to specify the size of the address pointer by defining a new property: address-width.
Signed-off-by Alan Chiang <[email protected]>Signed-off-by Andy Yeh <[email protected]>Acked-by Sakari Ailus <[email protected]>Reviewed-by Rob Herring <[email protected]>[Bartosz: fixed the commit message]to 4.14]
Signed-off-by Adrian Bunk <[email protected]>---
Documentation/devicetree/bindings/eeprom/eeprom.txt| 2 ++1 file changed, 2 insertions(+)Documentation/devicetree/bindings/eeprom/eeprom.txt +2
-0@@ -36,6 +36,8 @@ Optional properties: - read-only: this parameterless property disables writes to the eeprom + - address-width: number of address bits (one of 8, 16). +Example:
eeprom@52 {
--
2.11.0