staging: vboxvideo: Removed unnecessary parentheses
PATCH 1/1 staging: vboxvideo: Removed unnecessary parentheses
This patch fixes the checkpatch.pl check:
vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 < crtc->x'
vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].y2 < crtc->y'
--- drivers/staging/vboxvideo/vbox_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)
drivers/staging/vboxvideo/vbox_main.c +4 -4
@@ -116,10 +116,10 @@ void vbox_framebuffer_dirty_rectangles(struct drm_framebuffer *fb,struct vbva_cmd_hdr cmd_hdr;unsigned int crtc_id =to_vbox_crtc (crtc)->crtc_id; -if ((rects[i].x1 > crtc->x + crtc->hwmode.hdisplay) || - (rects[i].y1 > crtc->y + crtc->hwmode.vdisplay) || - (rects[i].x2 < crtc->x) || - (rects[i].y2 < crtc->y)) +if (rects[i].x1 > crtc->x + crtc->hwmode.hdisplay || + rects[i].y1 > crtc->y + crtc->hwmode.vdisplay || + rects[i].x2 < crtc->x || + rects[i].y2 < crtc->y)continue ; cmd_hdr.x = (s16 )rects[i].x1;
Signature · 1 line
2.19.1
Quoted 6 lines · Shayenne da Luz Moura
This patch fixes the checkpatch.pl check:
vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].x2 <
crtc->x'
vbox_main.c:119: CHECK: Unnecessary parentheses around 'rects[i].y2 <crtc->y'
Please use the imperative, in the subject line and in the patch. Also, try to say something other than "fixes" about what you do, which is not very descriptive. Say what you actually did and why, eg remove unneeded parentheses around the arguments of || to reduce clutter.
It is useful to mention that the change was suggested by checkpatch. It is not essential to copy the whole checkpatch message, or at least not all of them.
thanks,
julia
Quoted 35 lines
Signed-off-by Shayenne da Luz Moura <[email protected]>--- drivers/staging/vboxvideo/vbox_main.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)drivers/staging/vboxvideo/vbox_main.c +4
-5@@ -116,10 +116,10 @@ void vbox_framebuffer_dirty_rectangles(struct drm_framebuffer *fb,struct vbva_cmd_hdr cmd_hdr;unsigned int crtc_id =to_vbox_crtc (crtc)->crtc_id; -if ((rects[i].x1 > crtc->x + crtc->hwmode.hdisplay) || - (rects[i].y1 > crtc->y + crtc->hwmode.vdisplay) || - (rects[i].x2 < crtc->x) || - (rects[i].y2 < crtc->y)) +if (rects[i].x1 > crtc->x + crtc->hwmode.hdisplay || + rects[i].y1 > crtc->y + crtc->hwmode.vdisplay || + rects[i].x2 < crtc->x || + rects[i].y2 < crtc->y)continue ; cmd_hdr.x = (s16 )rects[i].x1; --2.19.1
--
You received this message because you are subscribed to the Google Groups "outreachy-kernel" group.
To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. To post to this group, send email to [email protected].
To view this discussion on the web visit https://groups.google.com/d/msgid/outreachy-kernel/20181022223126.smnsopiu4cavq6zh%40smtp.gmail.com.
For more options, visit https://groups.google.com/d/optout.