Skip to contentSkip to conversation

staging: rtl8192e: Add SPDX-License-Identifier - Style

PATCH Superseded Zach Turner 3 participants 3 messages Oct 23, 2018 – Oct 30, 2018 Staging

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Zach Turner

author
#0 lore raw

PATCH 1/1 staging: rtl8192e: Add SPDX-License-Identifier - Style

Add SPDX-License-Identifier tag to the start of the file. This is a coding style change which should not impact runtime code execution.

Signed-off-by Zach Turner <[email protected]>
---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +2 -2
index bc45cf098b04..8cfc2a1a5c48 100644
@@ -1,5 +1,5 @@
-/*
- * Host AP crypt: host-based CCMP encryption implementation for Host AP driver
+// SPDX-License-Identifier: GPL-2.0-or-later
+/* Host AP crypt: host-based CCMP encryption implementation for Host AP driver
  *
  * Copyright (c) 2003-2004, Jouni Malinen <[email protected]>
  *
Signature · 1 line
2.17.1
#1 lore raw
Quoted 13 lines · Zach Turner

Add SPDX-License-Identifier tag to the start of the file. This is a coding style change which should not impact runtime code execution.

Signed-off-by Zach Turner <[email protected]>
---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +0 -0
index bc45cf098b04..8cfc2a1a5c48 100644

drivers/staging/rtl8192e/rtllib_crypt_ccmp.c line 1

Quoted 3 lines
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +1 -2
@@ -1,5 +1,5 @@
-/*
- * Host AP crypt: host-based CCMP encryption implementation for Host AP driver
+// SPDX-License-Identifier: GPL-2.0-or-later

I believe it should be:

// SPDX-License-Identifier: GPL-2.0+

considering MODULE_LICENSE("GPL")

check Documentation/process/license-rules.rst

Also, the purpose of SPDX tag was to remove bolierplate text:

```
    * This program is free software; you can redistribute it and/or modify
    * it under the terms of the GNU General Public License version 2 as
    * published by the Free Software Foundation. See README and COPYING for
    * more details.
    */
```

But this above text suggest GPLv2 which is inconsistent with MODULE_LICENSE("GPL"); present at the bottom of the file.

Lastly, for these copyrights changes Cc the author of the file too.

Signature · 4 lines
Himanshu Jha
Undergraduate Student
Department of Electronics & Communication
Guru Tegh Bahadur Institute of Technology
maintainer
#2 lore raw
In reply to Zach Turner
Quoted 13 lines · Zach Turner

Add SPDX-License-Identifier tag to the start of the file. This is a coding style change which should not impact runtime code execution.

Signed-off-by Zach Turner <[email protected]>
---
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +0 -0
index bc45cf098b04..8cfc2a1a5c48 100644

drivers/staging/rtl8192e/rtllib_crypt_ccmp.c line 1

Quoted 3 lines
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +1 -2
@@ -1,5 +1,5 @@
-/*
- * Host AP crypt: host-based CCMP encryption implementation for Host AP driver
+// SPDX-License-Identifier: GPL-2.0-or-later

Please read Documentation/process/license-rules.rst for the proper string to put here (hint do not use "or-later" in it...)

thanks,

greg k-h