x86: Remove -pipe from KBUILD_CFLAGS
PATCH 1/1 x86: Remove -pipe from KBUILD_CFLAGS
Commit 77b0bf55bc67 ("kbuild/Makefile: Prepare for using macros in inline assembly code to work around asm() related GCC inlining bugs") added -Wa,- to KBUILD_CFLAGS, which breaks compiling with Clang (hangs indefinitely at compiling init/main.o). This happens because while Clang accepts -pipe (and has it documented in its list of supported flags), it silently ignores it after this 2010 commit (thanks to Nick Desaulniers for tracking this down), meaning that gas just infinitely waits for stdin and never receives it.
https://github.com/llvm-mirror/clang/commit/c19a12dc3d441bec62eed55e312b76c12d6d9022
Initially, I had suggested just add -Wa,- to KBUILD_CFLAGS when GCC was being used but that was before realizing it is because Clang doesn't do anything with -pipe. H. Peter Anvin suggested checking to see if -pipe gives us any gains out of GCC. Turns out it might actually be hurting:
With -pipe:
real 3m40.813s real 3m44.449s real 3m39.648s
Without -pipe:
real 3m38.492s real 3m38.335s real 3m38.975s
The issue of -Wa,- being passed along to gas without -pipe being supported should still probably be fixed on the LLVM side (open issue:
https://bugs.llvm.org/show_bug.cgi?id=39410) but this is not as much of a workaround anymore since it helps both GCC and Clang.
--- arch/x86/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
arch/x86/Makefile +1 -3
@@ -213,8 +213,6 @@ ifdef CONFIG_X86_64 KBUILD_LDFLAGS += $(call ld-option, -z max-page-size=0x200000) endif -# Speed up the build -KBUILD_CFLAGS += -pipe # Workaround for a gcc prelease that unfortunately was shipped in a suse release KBUILD_CFLAGS += -Wno-sign-compare #
@@ -239,7 +237,7 @@ archheaders: archmacros: $(Q)$(MAKE) $(build)=arch/x86/kernel arch/x86/kernel/macros.s -ASM_MACRO_FLAGS = -Wa,arch/x86/kernel/macros.s -Wa,- +ASM_MACRO_FLAGS = -Wa,arch/x86/kernel/macros.s export ASM_MACRO_FLAGS KBUILD_CFLAGS += $(ASM_MACRO_FLAGS)
Signature · 1 line
2.19.1
Quoted 29 lines · Nathan Chancellor
Commit
77b0bf55bc67("kbuild/Makefile: Prepare for using macros in inline assembly code to work aroundasm()related GCC inlining bugs") added -Wa,- toKBUILD_CFLAGS, which breaks compiling with Clang (hangs indefinitely at compilinginit/main.o). This happens because while Clang accepts -pipe (and has it documented in its list of supported flags), it silently ignores it after this 2010 commit (thanks to Nick Desaulniers for tracking this down), meaning that gas just infinitely waits for stdin and never receives it.https://github.com/llvm-mirror/clang/commit/c19a12dc3d441bec62eed55e312b76c12d6d9022
Initially, I had suggested just add -Wa,- to
KBUILD_CFLAGSwhen GCC was being used but that was before realizing it is because Clang doesn't do anything with -pipe. H. Peter Anvin suggested checking to see if -pipe gives us any gains out of GCC. Turns out it might actually be hurting:With -pipe:
real 3m40.813s real 3m44.449s real 3m39.648sWithout -pipe:
real 3m38.492s real 3m38.335s real 3m38.975s
Quoted 8 lines
The issue of -Wa,- being passed along to gas without -pipe being supported should still probably be fixed on the LLVM side (open issue:
https://bugs.llvm.org/show_bug.cgi?id=39410) but this is not as much of a workaround anymore since it helps both GCC and Clang.Suggested-by H. Peter Anvin <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>
Thanks Nathan for this patch and the timings and HPA for the suggestions.
Quoted 29 lines
--- arch/x86/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)arch/x86/Makefile +1
-4@@ -213,8 +213,6 @@ ifdef CONFIG_X86_64 KBUILD_LDFLAGS += $(call ld-option, -z max-page-size=0x200000) endif -# Speed up the build -KBUILD_CFLAGS += -pipe # Workaround for a gcc prelease that unfortunately was shipped in a suse release KBUILD_CFLAGS += -Wno-sign-compare #@@ -239,7 +237,7 @@ archheaders: archmacros: $(Q)$(MAKE) $(build)=arch/x86/kernel arch/x86/kernel/macros.s -ASM_MACRO_FLAGS = -Wa,arch/x86/kernel/macros.s -Wa,- +ASM_MACRO_FLAGS = -Wa,arch/x86/kernel/macros.s export ASM_MACRO_FLAGS KBUILD_CFLAGS += $(ASM_MACRO_FLAGS) --2.19.1
Signature · 2 lines
Thanks, ~Nick Desaulniers
From: Nathan Chancellor <[email protected]>
Sent: October 23, 2018 at 11:11:25 PM GMT
Quoted 64 lines
To: Thomas Gleixner; Ingo Molnar; Borislav Petkov
Cc: H. Peter Anvin; [email protected], [email protected], Nadav Amit; Kees Cook; Masahiro Yamada; Nick Desaulniers; Nathan Chancellor
Subject: [PATCH] x86: Remove -pipe fromKBUILD_CFLAGSCommit
77b0bf55bc67("kbuild/Makefile: Prepare for using macros in inline assembly code to work aroundasm()related GCC inlining bugs") added -Wa,- toKBUILD_CFLAGS, which breaks compiling with Clang (hangs indefinitely at compilinginit/main.o). This happens because while Clang accepts -pipe (and has it documented in its list of supported flags), it silently ignores it after this 2010 commit (thanks to Nick Desaulniers for tracking this down), meaning that gas just infinitely waits for stdin and never receives it.Initially, I had suggested just add -Wa,- to
KBUILD_CFLAGSwhen GCC was being used but that was before realizing it is because Clang doesn't do anything with -pipe. H. Peter Anvin suggested checking to see if -pipe gives us any gains out of GCC. Turns out it might actually be hurting:With -pipe:
real 3m40.813s real 3m44.449s real 3m39.648sWithout -pipe:
real 3m38.492s real 3m38.335s real 3m38.975sThe issue of -Wa,- being passed along to gas without -pipe being
supported should still probably be fixed on the LLVM side (open issue:
https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugs.llvm.org%2Fshow_bug.cgi%3Fid%3D39410&data=02%7C01%7Cnamit%40vmware.com%7C56678e0018894955601908d6393ce6d2%7Cb39138ca3cee4b4aa4d6cd83d9dd62f0%7C1%7C0%7C636759331072082215&sdata=MlOeR1p8%2BRROFxhjw3SQi0Uai9zuUeEesBxSMaM8wsg%3D&reserved=0) but this is not as much of a workaround anymore since it helps both GCC and Clang.Suggested-by H. Peter Anvin <[email protected]>Signed-off-by Nathan Chancellor <[email protected]>---
arch/x86/Makefile| 4 +---1 file changed, 1 insertion(+), 3 deletions(-)arch/x86/Makefile +0
-0@@ -213,8 +213,6 @@ ifdef CONFIG_X86_64 KBUILD_LDFLAGS += $(call ld-option, -z max-page-size=0x200000)endif
arch/x86/Makefile +0
-2-# Speed up the build -KBUILD_CFLAGS += -pipe# Workaround for a gcc prelease that unfortunately was shipped in a suse release
KBUILD_CFLAGS+= -Wno-sign-compare
#arch/x86/Makefile +0
-0@@ -239,7 +237,7 @@ archheaders:archmacros:
$(Q)$(MAKE) $(build)=arch/x86/kernel arch/x86/kernel/macros.sarch/x86/Makefile +1
-1-ASM_MACRO_FLAGS = -Wa,arch/x86/kernel/macros.s -Wa,- +ASM_MACRO_FLAGS = -Wa,arch/x86/kernel/macros.s
Quoted 5 lines
export
ASM_MACRO_FLAGSKBUILD_CFLAGS+= $(ASM_MACRO_FLAGS)Signature · 1 line
2.19.1
This pipe was a pain in the … I have actually already removed it in one version of the versions of my patch-set.
tip-bot for Nathan Chancellor
merge bot[tip:x86/urgent] x86/build: Remove -pipe from KBUILD_CFLAGS
In reply to Nathan Chancellorx86/build: Remove -pipe from KBUILD_CFLAGS
Commit-ID: f87419e1c9b5d38ea8a81b31e90aefa1be3fde5d Gitweb: https://git.kernel.org/tip/f87419e1c9b5d38ea8a81b31e90aefa1be3fde5d Author: Nathan Chancellor <[email protected]> AuthorDate: Tue, 23 Oct 2018 16:11:25 -0700 Committer: Thomas Gleixner <[email protected]> CommitDate: Mon, 5 Nov 2018 15:32:40 +0100
x86/build: Remove -pipe from KBUILD_CFLAGS
Commit 77b0bf55bc67 ("kbuild/Makefile: Prepare for using macros in inline assembly code to work around asm() related GCC inlining bugs") added -Wa,- to KBUILD_CFLAGS, which breaks compiling with Clang (hangs indefinitely at compiling init/main.o). This happens because while Clang accepts -pipe (and has it documented in its list of supported flags), it silently ignores it after this 2010 commit (thanks to Nick Desaulniers for tracking this down), meaning that gas just infinitely waits for stdin and never receives it.
https://github.com/llvm-mirror/clang/commit/c19a12dc3d441bec62eed55e312b76c12d6d9022
Initially, I had suggested just add -Wa,- to KBUILD_CFLAGS when GCC was being used but that was before realizing it is because Clang doesn't do anything with -pipe. H. Peter Anvin suggested checking to see if -pipe gives us any gains out of GCC. Turns out it might actually be hurting:
With -pipe:
real 3m40.813s real 3m44.449s real 3m39.648s
Without -pipe:
real 3m38.492s real 3m38.335s real 3m38.975s
The issue of -Wa,- being passed along to gas without -pipe being supported should still probably be fixed on the LLVM side (open issue:
https://bugs.llvm.org/show_bug.cgi?id=39410) but this is not as much of a workaround anymore since it helps both GCC and Clang.
--- arch/x86/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
arch/x86/Makefile +1 -3
@@ -213,8 +213,6 @@ ifdef CONFIG_X86_64 KBUILD_LDFLAGS += $(call ld-option, -z max-page-size=0x200000) endif -# Speed up the build -KBUILD_CFLAGS += -pipe # Workaround for a gcc prelease that unfortunately was shipped in a suse release KBUILD_CFLAGS += -Wno-sign-compare #
@@ -239,7 +237,7 @@ archheaders: archmacros: $(Q)$(MAKE) $(build)=arch/x86/kernel arch/x86/kernel/macros.s -ASM_MACRO_FLAGS = -Wa,arch/x86/kernel/macros.s -Wa,- +ASM_MACRO_FLAGS = -Wa,arch/x86/kernel/macros.s export ASM_MACRO_FLAGS KBUILD_CFLAGS += $(ASM_MACRO_FLAGS)
tip-bot for Nathan Chancellor
merge bot[tip:x86/urgent] x86/build: Remove -pipe from KBUILD_CFLAGS
In reply to Nathan Chancellorx86/build: Remove -pipe from KBUILD_CFLAGS
Commit-ID: 437e88ab8f9e2ad90576ab74c4cf8f527bbf51cd Gitweb: https://git.kernel.org/tip/437e88ab8f9e2ad90576ab74c4cf8f527bbf51cd Author: Nathan Chancellor <[email protected]> AuthorDate: Tue, 23 Oct 2018 16:11:25 -0700 Committer: Thomas Gleixner <[email protected]> CommitDate: Mon, 5 Nov 2018 16:45:32 +0100
x86/build: Remove -pipe from KBUILD_CFLAGS
Commit 77b0bf55bc67 ("kbuild/Makefile: Prepare for using macros in inline assembly code to work around asm() related GCC inlining bugs") added -Wa,- to KBUILD_CFLAGS, which breaks compiling with Clang (hangs indefinitely at compiling init/main.o). This happens because while Clang accepts -pipe (and has it documented in its list of supported flags), it silently ignores it after this 2010 commit (thanks to Nick Desaulniers for tracking this down), meaning that gas just infinitely waits for stdin and never receives it.
https://github.com/llvm-mirror/clang/commit/c19a12dc3d441bec62eed55e312b76c12d6d9022
Initially, I had suggested just add -Wa,- to KBUILD_CFLAGS when GCC was being used but that was before realizing it is because Clang doesn't do anything with -pipe. H. Peter Anvin suggested checking to see if -pipe gives us any gains out of GCC. Turns out it might actually be hurting:
With -pipe:
real 3m40.813s real 3m44.449s real 3m39.648s
Without -pipe:
real 3m38.492s real 3m38.335s real 3m38.975s
The issue of -Wa,- being passed along to gas without -pipe being supported should still probably be fixed on the LLVM side (open issue:
https://bugs.llvm.org/show_bug.cgi?id=39410) but this is not as much of a workaround anymore since it helps both GCC and Clang.
--- arch/x86/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
arch/x86/Makefile +1 -3
@@ -213,8 +213,6 @@ ifdef CONFIG_X86_64 KBUILD_LDFLAGS += $(call ld-option, -z max-page-size=0x200000) endif -# Speed up the build -KBUILD_CFLAGS += -pipe # Workaround for a gcc prelease that unfortunately was shipped in a suse release KBUILD_CFLAGS += -Wno-sign-compare #
@@ -239,7 +237,7 @@ archheaders: archmacros: $(Q)$(MAKE) $(build)=arch/x86/kernel arch/x86/kernel/macros.s -ASM_MACRO_FLAGS = -Wa,arch/x86/kernel/macros.s -Wa,- +ASM_MACRO_FLAGS = -Wa,arch/x86/kernel/macros.s export ASM_MACRO_FLAGS KBUILD_CFLAGS += $(ASM_MACRO_FLAGS)