Skip to contentSkip to conversation

KVM: s390: factor out nullify_gisa()

PATCH Janosch Frank 2 participants 2 messages Oct 31, 2018 – Nov 6, 2018 1 message not in the archive s390

lore
Share & tools
lore

Janosch Frank

author Reviewed-by
#1 lore raw
In reply to a message not in the archive

This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --JF45VwyApr2jbkjJCwlTai9KI2MNjxteo
Content-Type: multipart/mixed; boundary="EmG1HoKllkhti7jROSn5AWFoSmiDAVvvN";
protected-headers="v1"
From: Janosch Frank <[email protected]>
To: Michael Mueller <[email protected]>, [email protected]
Cc: Martin Schwidefsky <[email protected]>,
Heiko Carstens <[email protected]>,
Christian Borntraeger <[email protected]>,
David Hildenbrand <[email protected]>, Cornelia Huck <[email protected]>, Sebastian Ott <[email protected]>,
Peter Oberparleiter <[email protected]>,
Vasily Gorbik <[email protected]>, Julian Wiedmann <[email protected]>, Tony Krowiak <[email protected]>,
Claudio Imbrenda <[email protected]>,
Halil Pasic <[email protected]>, Thomas Huth <[email protected]>, Pierre Morel <[email protected]>
Message-ID: <[email protected]>
Subject: Re: [PATCH 03/10] KVM: s390: factor out nullify_gisa()
References: <[email protected]>
<[email protected]>
In-Reply-To: <[email protected]>

--EmG1HoKllkhti7jROSn5AWFoSmiDAVvvN
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: quoted-printable

Quoted 5 lines · Michael Mueller

This function will be used by the GIB alert handler and during the GISA clear operation. Thus it gets factored out here. =20

arch/s390/kvm/interrupt.c int kvm_s390_get_irq_state(struct kvm_vcpu *vcp=

Quoted 9 lines
---
 arch/s390/kvm/interrupt.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

=20

arch/s390/kvm/interrupt.c +0 -0
index 3789a9ad8dee..ce258d6b7c06 100644
@@ -2886,11 +2886,16 @@ int kvm_s390_get_irq_state(struct kvm_vcpu *vcp=

u, __u8 __user *buf, int len)

Quoted 18 lines
arch/s390/kvm/interrupt.c +0 -0
 	return n;
 }

=20

arch/s390/kvm/interrupt.c +7 -2
+static void nullify_gisa(struct kvm_s390_gisa *gisa)
+{
+	memset(gisa, 0, sizeof(struct kvm_s390_gisa));
+	gisa->next_alert =3D (u32)(u64)gisa;
+}
+
 void kvm_s390_gisa_clear(struct kvm *kvm)
 {
 	if (kvm->arch.gisa) {
-		memset(kvm->arch.gisa, 0, sizeof(struct kvm_s390_gisa));
-		kvm->arch.gisa->next_alert =3D (u32)(u64)kvm->arch.gisa;
+		nullify_gisa(kvm->arch.gisa);
 		VM_EVENT(kvm, 3, "gisa 0x%pK cleared", kvm->arch.gisa);
 	}
 }
Quoted 1 line

=20

--EmG1HoKllkhti7jROSn5AWFoSmiDAVvvN--

--JF45VwyApr2jbkjJCwlTai9KI2MNjxteo
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: OpenPGP digital signature
Content-Disposition: attachment; filename="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJb2WboAAoJEONU5rjiOLn4m8kP/RLHoKSSHnfLDpiy+Ewpq6zm 7RQb46SWK7TJyKV34ZsUc76edtoLgFiG2qLYmgbomvZReNBrrIfAhXcqOyPeW99+ 7PMLwMfKn/G74YH0jHQNbrckWVfNOMCqzgV4pX7FocF2QH1hNJcyhd7EsynlL2Ul tgU+xzNRZeDbTfEFDnA4QlI5gNbSDklAbtu9iO7XaEIs/AX2HDoA06s552MRCRLM vU4/Q422kgs+n8RqHJBqjRxWyfGz9KnaC/HM55437G6vw+Ki5c9BdLdPbtxflKvV IHnI3oHYJkp/iFWEagruHMqezytFltLRnpUssOt24WbyYecnSSJo7pl+34mNXNW7 ptWWMhk/jc8aWfSaJsZqyAaGmX7IBgA8da7h/CapImmhuOAmf57tVrHVuC/AIqVU 5FYujBNzGvmGq4WE4XDSr/OnNyT/qVlq5NPSBmMSk1r0U8v+DEIRK+vQOqvLCI/u LjMdvsqxlfsQSDatokEpd7v8zYnSAVoJUo82gwBbX0tHxjO1CoiHKAy5ZepnsLrC +dtKGNehl/kwvsP0atP3nW4rPJA9cxDkYZc0oMSdfRhWqTHZhYXPtIXNHTXCKY22 0gDVlgrgcMD3Q8Cd045bsxveFvUiVcPLFZ179W9kG/2d1RUFGQ+MqoM7kLfB6M2n Y73o1oOp+/sqt6SxG53T
=N4mK
-----END PGP SIGNATURE-----

--JF45VwyApr2jbkjJCwlTai9KI2MNjxteo--

Reviewed-by
#2 lore raw
Quoted 8 lines · On Thu, 25 Oct 2018 14:37:44 +0200 Michael Mueller <[email protected]> wrote:

This function will be used by the GIB alert handler and during the GISA clear operation. Thus it gets factored out here.

---
 arch/s390/kvm/interrupt.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)