arm64: dts: rockchip: sapphire: add chosen node
Subsystems (2)
PATCH 1/1 arm64: dts: rockchip: sapphire: add chosen node
In order to use earlycon, the stdout-path property needs to be set in the chosen node.
---
Also, this works around this kexec bug:
http://lists.infradead.org/pipermail/kexec/2018-October/021746.html
--- arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts +4 -0
@@ -9,4 +9,8 @@ / { model = "Sapphire-RK3399 Board"; compatible = "rockchip,rk3399-sapphire", "rockchip,rk3399"; + + chosen { + stdout-path = "serial2:1500000n8"; + }; };
Signature · 1 line
2.19.1
A message that is not in the archive (sent off-list or not yet received): 20181026133655.1605-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Hi Vicente,
Am Freitag, 26. Oktober 2018, 15:36:55 CET schrieb Vicente Bergas:
Quoted 18 lines
In order to use earlycon, the stdout-path property needs to be set in the chosen node.
---
Also, this works around this kexec bug:
http://lists.infradead.org/pipermail/kexec/2018-October/021746.htmlSigned-off-by Vicente Bergas <[email protected]>--- arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts | 4 ++++ 1 file changed, 4 insertions(+)arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts +0
-0
arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts line 15
Quoted 7 lines
arch/arm64/boot/dts/rockchip/rk3399-sapphire.dts +4
-0@@ -9,4 +9,8 @@ / { model = "Sapphire-RK3399 Board"; compatible = "rockchip,rk3399-sapphire", "rockchip,rk3399"; + + chosen { + stdout-path = "serial2:1500000n8"; + };
shouldn't that maybe live in the shared .dtsi instead? I do guess the excavator will have the same default serial?
Heiko
PATCH v2 1/1 arm64: dts: rockchip: sapphire: add chosen node
In order to use earlycon, the stdout-path property needs to be set in the chosen node.
---
Hi Heiko,
Quoted 1 line
shouldn't that maybe live in the shared .dtsi instead?
this v2 applies the change in the .dtsi as suggested.
Quoted 1 line
I do guess the excavator will have the same default serial?
Well, in fact it seems to me that serial2 is set as the default serial port at the chip level, although there are some exceptions. But on the other hand the baud rate is more free form.
So, as suggested, it could be a good compromise to put it at the daugther-card level.
The point for working around the kexec bug is still valid, but with the update from the maintainer it is not enough to fix everything:
http://lists.infradead.org/pipermail/kexec/2018-October/021762.html
Regards,
Vicenç.
--- arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi | 4 ++++ 1 file changed, 4 insertions(+)
arch/arm64/boot/dts/rockchip/rk3399-sapphire.dtsi +4 -0
@@ -11,6 +11,10 @@ / { compatible = "rockchip,rk3399-sapphire", "rockchip,rk3399"; + chosen { + stdout-path = "serial2:1500000n8"; + }; + backlight: backlight { compatible = "pwm-backlight"; brightness-levels = <
Signature · 7 lines
2.19.1 _______________________________________________ Linux-rockchip mailing list [email protected] http://lists.infradead.org/mailman/listinfo/linux-rockchip
A message that is not in the archive (sent off-list or not yet received): 20181030145941.15975-1-vicencb-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Am Dienstag, 30. Oktober 2018, 15:59:41 CET schrieb Vicente Bergas:
Quoted 16 lines
In order to use earlycon, the stdout-path property needs to be set in the chosen node.
---
Hi Heiko,
Quoted 1 line
shouldn't that maybe live in the shared .dtsi instead?
this v2 applies the change in the .dtsi as suggested.
Quoted 1 line
I do guess the excavator will have the same default serial?
Well, in fact it seems to me that serial2 is set as the default serial port at the chip level, although there are some exceptions. But on the other hand the baud rate is more free form.
So, as suggested, it could be a good compromise to put it at the daugther-card level.
Quoted 8 lines
The point for working around the kexec bug is still valid, but with the update from the maintainer it is not enough to fix everything:
http://lists.infradead.org/pipermail/kexec/2018-October/021762.htmlRegards,
Vicenç.Signed-off-by Vicente Bergas <[email protected]>
applied for 4.21
Thanks
Heiko