platform/x86: wmi: declare device_type structure as constant
PATCH 1/1 platform/x86: wmi: declare device_type structure as constant
The only usage of device_type structure is getting stored as a reference in the type field of device structure. This type field is declared const. Therefore, the device_type structure can never be modified and can be declared as const.
Signed-off-by Bhumika Goyal <[email protected]>
--- drivers/platform/x86/wmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/platform/x86/wmi.c +3 -3
@@ -987,19 +987,19 @@ static struct bus_type wmi_bus_type = { .remove = wmi_dev_remove, }; -static struct device_type wmi_type_event = { +static const struct device_type wmi_type_event = { .name ="event" , .groups = wmi_event_groups, .release = wmi_dev_release, }; -static struct device_type wmi_type_method = { +static const struct device_type wmi_type_method = { .name ="method" , .groups = wmi_method_groups, .release = wmi_dev_release, }; -static struct device_type wmi_type_data = { +static const struct device_type wmi_type_data = { .name ="data" , .groups = wmi_data_groups, .release = wmi_dev_release,
Signature · 1 line
2.14.5
Quoted 6 lines · Bhumika Goyal
The only usage of
device_typestructure is getting stored as a reference in the type field of device structure. This type field is declared const. Therefore, thedevice_typestructure can never be modified and can be declared as const.
Pushed to my review and testing queue, thanks!
Quoted 35 lines
Signed-off-by Bhumika Goyal <[email protected]>--- drivers/platform/x86/wmi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)drivers/platform/x86/wmi.c +3
-4@@ -987,19 +987,19 @@ static struct bus_type wmi_bus_type = { .remove = wmi_dev_remove, }; -static struct device_type wmi_type_event = { +static const struct device_type wmi_type_event = { .name ="event" , .groups = wmi_event_groups, .release = wmi_dev_release, }; -static struct device_type wmi_type_method = { +static const struct device_type wmi_type_method = { .name ="method" , .groups = wmi_method_groups, .release = wmi_dev_release, }; -static struct device_type wmi_type_data = { +static const struct device_type wmi_type_data = { .name ="data" , .groups = wmi_data_groups, .release = wmi_dev_release, --2.14.5
Signature · 2 lines
With Best Regards, Andy Shevchenko