Skip to contentSkip to conversation

xen/grant_table: Remove stall comment on top of map_grant_ref

PATCH In review Julien Grall 3 participants 4 messages Nov 1, 2018

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 xen/grant_table: Remove stall comment on top of map_grant_ref

Remove the 2 part comment on top of map_grant_ref:
- The first part mention the return value which has been void since 2006!
- The second part mention a local variable 'addr' which does not exist anymore.

---
 xen/common/grant_table.c | 7 -------
 1 file changed, 7 deletions(-)
xen/common/grant_table.c +0 -7
index 878e668bf5..0b5894a070 100644
@@ -890,13 +890,6 @@ static unsigned int mapkind(
     return kind;
 }
 
-/*
- * Returns 0 if TLB flush / invalidate required by caller.
- * va will indicate the address to be invalidated.
- *
- * addr is _either_ a host virtual address, or the address of the pte to
- * update, as indicated by the GNTMAP_contains_pte flag.
- */
 static void
 map_grant_ref(
     struct gnttab_map_grant_ref *op)
Signature · 7 lines
2.11.0


_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Julien Grall

Remove the 2 part comment on top of map_grant_ref:
- The first part mention the return value which has been void since 2006!
- The second part mention a local variable 'addr' which does not exist anymore.

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#2 lore raw
In reply to Julien Grall
Quoted 7 lines · Julien Grall

Remove the 2 part comment on top of map_grant_ref:
- The first part mention the return value which has been void since 2006!
- The second part mention a local variable 'addr' which does not exist anymore.

Nit: s/stall/stale/; in title

-George

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel

#3 lore raw

Hi George,

Quoted 10 lines · George Dunlap
Quoted 7 lines · Julien Grall

Remove the 2 part comment on top of map_grant_ref:
- The first part mention the return value which has been void since 2006!
- The second part mention a local variable 'addr' which does not exist anymore.

Nit: s/stall/stale/; in title

I will fix this on commit.

Cheers,

Quoted 3 lines

-George

Signature · 6 lines
Julien Grall

_______________________________________________
Xen-devel mailing list
[email protected]
https://lists.xenproject.org/mailman/listinfo/xen-devel