Skip to contentSkip to conversation

MIPS: math-emu: Change to use DEFINE_SHOW_ATTRIBUTE macro

PATCH In review Yangtao Li 2 participants 2 messages Nov 5, 2018 MIPS

lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 MIPS: math-emu: Change to use DEFINE_SHOW_ATTRIBUTE macro

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Yangtao Li <[email protected]>
---
 arch/mips/math-emu/me-debugfs.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)
arch/mips/math-emu/me-debugfs.c +1 -11
index 62566385ce0e..58798f527356 100644
@@ -183,17 +183,7 @@ static int fpuemustats_clear_show(struct seq_file *s, void *unused)
 	return 0;
 }
 
-static int fpuemustats_clear_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, fpuemustats_clear_show, inode->i_private);
-}
-
-static const struct file_operations fpuemustats_clear_fops = {
-	.open                   = fpuemustats_clear_open,
-	.read			= seq_read,
-	.llseek			= seq_lseek,
-	.release		= single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(fpuemustats_clear);
 
 static int __init debugfs_fpuemu(void)
 {
Signature · 1 line
2.17.0
#1 lore raw

Hi Yangtao,

Quoted 6 lines · Yangtao Li

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Yangtao Li <[email protected]>
---
 arch/mips/math-emu/me-debugfs.c | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

Thanks - applied to mips-next for v4.21.

Paul