Skip to contentSkip to conversation

ARM: OMAP1: clock: Change to use DEFINE_SHOW_ATTRIBUTE macro

PATCH In review Yangtao Li 2 participants 2 messages Nov 6, 2018 – Nov 29, 2018

Subsystems (4)
Arm (32-bit) Arm sub-architectures OMAP1 support OMAP clock framework support
lore
Share & tools
lore

Yangtao Li

author
#0 lore raw

PATCH 1/1 ARM: OMAP1: clock: Change to use DEFINE_SHOW_ATTRIBUTE macro

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Signed-off-by Yangtao Li <[email protected]>
---
 arch/arm/mach-omap1/clock.c | 14 ++------------
 1 file changed, 2 insertions(+), 12 deletions(-)
arch/arm/mach-omap1/clock.c +2 -12
index fa512413a471..c8c6fe88b2d6 100644
@@ -968,7 +968,7 @@ late_initcall(omap_clk_enable_autoidle_all);
 
 static struct dentry *clk_debugfs_root;
 
-static int clk_dbg_show_summary(struct seq_file *s, void *unused)
+static int debug_clock_show(struct seq_file *s, void *unused)
 {
 	struct clk *c;
 	struct clk *pa;

@@ -988,17 +988,7 @@ static int clk_dbg_show_summary(struct seq_file *s, void *unused)
 	return 0;
 }
 
-static int clk_dbg_open(struct inode *inode, struct file *file)
-{
-	return single_open(file, clk_dbg_show_summary, inode->i_private);
-}
-
-static const struct file_operations debug_clock_fops = {
-	.open           = clk_dbg_open,
-	.read           = seq_read,
-	.llseek         = seq_lseek,
-	.release        = single_release,
-};
+DEFINE_SHOW_ATTRIBUTE(debug_clock);
 
 static int clk_debugfs_register_one(struct clk *c)
 {
Signature · 1 line
2.17.0
reviewer
#1 lore raw
Quoted 1 line · Yangtao Li

Use DEFINE_SHOW_ATTRIBUTE macro to simplify the code.

Applying into omap-for-v4.21/omap1 thanks.

Tony