Skip to contentSkip to conversation

fpga: altera-cvp: clean checkpatch faults

PATCH In review [email protected] 2 participants 4 messages Nov 8, 2018 – Nov 12, 2018 FPGA manager framework

lore
Share & tools
lore

[email protected]

author
#0 lore raw

cover fpga: altera-cvp: clean checkpatch faults

From: Carlos A Petry <[email protected]>

Insert missing or malformed SPDX-License-Identifier tag
WARNING: Missing or malformed SPDX-License-Identifier tag
Fix function definition argument 'struct altera_cvp_conf *'
WARNING: function definition argument 'struct altera_cvp_conf *'

Run checkpatch and all problem was fixed in the file. This is my first contribution to the Kernel Project, please let me know if something is wrong, thanks.

Carlos A Petry (2):
fpga: altera-cvp: Insert SPDX-License-Identifier
fpga: altera-cvp: Fix function definition argument

 drivers/fpga/altera-cvp.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
Signature · 1 line
2.17.1
author
#1 lore raw

PATCH 1/2 fpga: altera-cvp: Insert SPDX-License-Identifier

From: Carlos A Petry <[email protected]>

Fix the following checkpatch warning:

WARNING: Missing or malformed SPDX-License-Identifier tag in line 1

Signed-off-by Carlos A Petry <[email protected]>
---
 drivers/fpga/altera-cvp.c | 1 +
 1 file changed, 1 insertion(+)
drivers/fpga/altera-cvp.c +1 -0
index 610a1558e..45b7c8c0b 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0
 /*
  * FPGA Manager Driver for Altera Arria/Cyclone/Stratix CvP
  *
Signature · 1 line
2.17.1
#2 lore raw

Re: [PATCH 1/2] fpga: altera-cvp: Insert SPDX-License-Identifier

On Wed, 7 Nov 2018 23:13:11 -0200 [email protected] [email protected] wrote:
...

drivers/fpga/altera-cvp.c line 1

Quoted 6 lines
drivers/fpga/altera-cvp.c +1 -0
index 610a1558e..45b7c8c0b 100644
@@ -1,3 +1,4 @@
+// SPDX-License-Identifier: GPL-2.0

when SPDX identifier is in place, shouldn't the GPL boilerplate below be removed?

Anatolij

author
#3 lore raw

PATCH 2/2 fpga: altera-cvp: Fix function definition argument

In reply to [email protected]

From: Carlos A Petry <[email protected]>

Fix the following checkpatch warning:
WARNING: function definition argument 'struct altera_cvp_conf *'

Signed-off-by Carlos A Petry <[email protected]>
---
 drivers/fpga/altera-cvp.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/fpga/altera-cvp.c +2 -1
index 45b7c8c0b..150a9f5dd 100644
@@ -66,7 +66,8 @@ struct altera_cvp_conf {
 	struct fpga_manager	*mgr;
 	struct pci_dev		*pci_dev;
 	void __iomem		*map;
-	void			(*write_data)(struct altera_cvp_conf *, u32);
+	void			(*write_data)(struct altera_cvp_conf *conf,
+					      u32 data);
 	char			mgr_name[64];
 	u8			numclks;
 };
Signature · 1 line
2.17.1