zfcp: the action field of zfcp_erp_action is actually the type
A message that is not in the archive (sent off-list or not yet received): [email protected]
Hannes Reinecke
Reviewed-byQuoted 17 lines · Steffen Maier
&zfcp_erp_action.action ==> &zfcp_erp_action.type
While at it, make use of the already defined enum for this purpose to get at least some build checking (even though an enum is type equivalent to an int in C). v2.6.27 commit
287ac01acf22("[SCSI] zfcp: Cleanup code inzfcp_erp.c") introduced the enum which was cpp defines previously.To prevent compiler warnings with the
switch(act->type), we have to separate the recently added eyecatchers from enumzfcp_erp_act_type.Since struct
zfcp_erp_actiontype is embedded into other structures living inzfcp_def.h, we have to move enumzfcp_erp_act_typefrom its private definition inzfcp_erp.cto the zfcp-globalzfcp_def.h.Silence one false -Wswitch compiler warning case: LUNs as the leaves in our object tree do not have any follow-up success recovery.
Quoted 8 lines
Signed-off-by Steffen Maier <[email protected]>Reviewed-by Benjamin Block <[email protected]>--- drivers/s390/scsi/zfcp_dbf.c | 2 +- drivers/s390/scsi/zfcp_def.h | 20 +++++++++++- drivers/s390/scsi/zfcp_erp.c | 77 +++++++++++++++++++++----------------------- 3 files changed, 56 insertions(+), 43 deletions(-)
Cheers,
Hannes
Signature · 5 lines
Dr. Hannes Reinecke Teamlead Storage & Networking [email protected] +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg GF: F. Imend�rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG N�rnberg)