Skip to contentSkip to conversation

zfcp: drop unnecessary forward prototype for struct zfcp_reqlist

PATCH Hannes Reinecke 1 participant 1 message Nov 16, 2018 1 message not in the archive s390

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Hannes Reinecke

author Reviewed-by
#1 lore raw
Quoted 27 lines · Steffen Maier

While struct zfcp_adapter contains a pointer to zfcp_reqlist, the pointer field does not need to know the structure or even a prototype.

The prototype was introduced with v2.6.34 commit b6bd2fb92a7b ("[SCSI]
zfcp: Move FSF request tracking code to new file").

---
  drivers/s390/scsi/zfcp_def.h | 4 +---
  1 file changed, 1 insertion(+), 3 deletions(-)
drivers/s390/scsi/zfcp_def.h +1 -1
index 3396a47721a7..1b6d64eb66b7 100644
@@ -4,7 +4,7 @@
   *
   * Global definitions for the zfcp device driver.
   *
- * Copyright IBM Corp. 2002, 2010
+ * Copyright IBM Corp. 2002, 2017
   */
 
  #ifndef ZFCP_DEF_H

drivers/s390/scsi/zfcp_def.h line 46

Quoted 8 lines
drivers/s390/scsi/zfcp_def.h +0 -2
@@ -41,8 +41,6 @@
  #include "zfcp_fc.h"
  #include "zfcp_qdio.h"
 
-struct zfcp_reqlist;
-
  /********************* SCSI SPECIFIC DEFINES *********************************/
  #define ZFCP_SCSI_ER_TIMEOUT                    (10*HZ)
 

Cheers,

Hannes

Signature · 5 lines
Dr. Hannes Reinecke		   Teamlead Storage & Networking
[email protected]			               +49 911 74053 688
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: F. Imend�rffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton
HRB 21284 (AG N�rnberg)